Re: [PATCH v4 1/2] media: uapi: Add H264 low-level decoder API compound controls.

From: Ezequiel Garcia <ezequiel@collabora.com>
To: Maxime Ripard <maxime.ripard@bootlin.com>,
	hans.verkuil@cisco.com,  acourbot@chromium.org,
	sakari.ailus@linux.intel.com,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: jonas@kwiboo.se, jenskuske@gmail.com,
	linux-sunxi@googlegroups.com, linux-kernel@vger.kernel.org,
	jernej.skrabec@gmail.com, tfiga@chromium.org,
	Paul Kocialkowski <paul.kocialkowski@bootlin.com>,
	Chen-Yu Tsai <wens@csie.org>,
	posciak@chromium.org,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Guenter Roeck <groeck@chromium.org>,
	nicolas.dufresne@collabora.com,
	linux-arm-kernel@lists.infradead.org,
	linux-media@vger.kernel.org
Subject: Re: [PATCH v4 1/2] media: uapi: Add H264 low-level decoder API compound controls.
Date: Mon, 04 Mar 2019 15:49:11 -0300	[thread overview]
Message-ID: <4aac6476ffe6a6be021c69a708f19d5da30a79e4.camel@collabora.com> (raw)
In-Reply-To: <9817c9875638ed2484d61e6e128e2551cf3bda4c.1550672228.git-series.maxime.ripard@bootlin.com>

On Wed, 2019-02-20 at 15:17 +0100, Maxime Ripard wrote:
> From: Pawel Osciak <posciak@chromium.org>
> 
> Stateless video codecs will require both the H264 metadata and slices in
> order to be able to decode frames.
> 
> This introduces the definitions for a new pixel format for H264 slices that
> have been parsed, as well as the structures used to pass the metadata from
> the userspace to the kernel.
> 
> Co-Developped-by: Maxime Ripard <maxime.ripard@bootlin.com>
> Signed-off-by: Pawel Osciak <posciak@chromium.org>
> Signed-off-by: Guenter Roeck <groeck@chromium.org>
> Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
> ---
>  Documentation/media/uapi/v4l/biblio.rst            |   9 +-
>  Documentation/media/uapi/v4l/extended-controls.rst | 547 ++++++++++++++-

It seems Hans splitted the documentation and so this should now
go to Documentation/media/uapi/v4l/ext-ctrls-codec.rst.

[..]
> 
> +#define V4L2_PIX_FMT_H264_SLICE v4l2_fourcc('S', '2', '6', '4') /* H264 parsed slices */
>  #define V4L2_PIX_FMT_H263     v4l2_fourcc('H', '2', '6', '3') /* H263          */
>  #define V4L2_PIX_FMT_MPEG1    v4l2_fourcc('M', 'P', 'G', '1') /* MPEG-1 ES     */
>  #define V4L2_PIX_FMT_MPEG2    v4l2_fourcc('M', 'P', 'G', '2') /* MPEG-2 ES     */

I haven't seen any objections to renaming this to V4L2_PIX_FMT_H264_SLICE_RAW,
so if you could be so kind to push v5 with this rename (or similar), and also
rebasing to the master branch, I could then submit the H264 decoder support for
the Rockchip VPU.

There is still the question brought up by Tomasz, about moving this pixel format
to a non-public header. Perhaps someone has some ideas on this?

Thanks a lot!
Ezequiel

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel