From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4E75FC3DA49 for ; Thu, 11 Jul 2024 15:01:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=GzBikCsSxwa4tIaAjDkzHb0YSqrYlEjXJ+NMt8JmEcc=; b=WY5nh7d79z2fWysMRrpbK3Zhc4 h1dOvb8/gzObXlbhJsLC1Yz1HiEDET99RCRFQemfCE6HSlNw6WHkqgnFWeDBCpIPDl0+045V8XU0y JUG6xXI0SakNq1t03F/bkMm74W5TP4b08KSIDC7S/ISpypUxMquGYskRaUK9F9mrZC6Igf0jNonge f7pGfOEiynCbh1K8cFhzJYF8HglHsRDbh0oJmS8WLgd4n670EvSzz91+FeoHHg0yFl6UXFUE1jqgj wzJxEmTtc35oIHZGQlnDtHSu73TT8pU3fCWIToYm28nX4HjsG6Hm+UXtICAotWzyA1ytftn9wIw5I tWNTwnOg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sRvHs-0000000EQw9-2kJY; Thu, 11 Jul 2024 15:00:48 +0000 Received: from madrid.collaboradmins.com ([2a00:1098:ed:100::25]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sRvHa-0000000EQqw-3b4d; Thu, 11 Jul 2024 15:00:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1720710028; bh=itsb3ZhOZhDxbRFDuhwPmOmd5B61fMqvju+ZGjeXyag=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OHjL7T02nlYOYz3aiCp07/l5asG9Ed/PCld4oMyOu9qgYD9chneaaV+4joG//kLzR uPA0SbAC4zTnxeBabO21Z92YcFXP8GopO91sC+WpEBecjQQUNfyjPxa0cNzLPnOIsx ieumt/wiGFAX/adpNibPQA1gUmaQJXET1ARhukYEY91NAjTHMCGk9Sk1oSkSyS/QkC 3+xwLLD1T3LsPOSkHg0m8rUieNOAt/JD9oHIe6VgtZifSmxMw3/je2rTi+gbld9vF6 qT28i+0F/b5HiJrZRs6yS4ZlOaiMAqaezQJhJSGlDW5meKRIAdl0IP4ZV5/PDW79mI lkfCqdfF1U3cg== Received: from notapiano (zone.collabora.co.uk [167.235.23.81]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nfraprado) by madrid.collaboradmins.com (Postfix) with ESMTPSA id DC6FA3780627; Thu, 11 Jul 2024 15:00:25 +0000 (UTC) Date: Thu, 11 Jul 2024 11:00:23 -0400 From: =?utf-8?B?TsOtY29sYXMgRi4gUi4gQS4=?= Prado To: AngeloGioacchino Del Regno Cc: linux-mediatek@lists.infradead.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, matthias.bgg@gmail.com, tinghan.shen@mediatek.com, seiya.wang@mediatek.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, wenst@chromium.org Subject: Re: [PATCH] arm64: dts: mediatek: mt8195: Add power domain to secondary XHCI Message-ID: <4ac0e464-5ef6-445d-a784-fe367ea23a2d@notapiano> References: <20240711093230.118534-1-angelogioacchino.delregno@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240711093230.118534-1-angelogioacchino.delregno@collabora.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240711_080031_057388_266F9A5D X-CRM114-Status: GOOD ( 17.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jul 11, 2024 at 11:32:30AM +0200, AngeloGioacchino Del Regno wrote: > The secondary XHCI controller, using a PHY that is shared between > it and the secondary PCI-Express controller, gets powered by the > PCIE_MAC_P1 power domain. > > Add this power domain to the usb@11290000 node to fix probe. > > Fixes: 37f2582883be ("arm64: dts: Add mediatek SoC mt8195 and evaluation board") > Reported-by: Nícolas F. R. A. Prado #KernelCI > Signed-off-by: AngeloGioacchino Del Regno Hi Angelo, thanks for the patch, but unfortunately it doesn't fix the issue: [ 10.772128] mtk-pcie-gen3 112f8000.pcie: host bridge /soc/pcie@112f8000 ranges: [ 10.788914] mtk-pcie-gen3 112f8000.pcie: IO 0x0024000000..0x00241fffff -> 0x0024000000 [ 10.802111] mtk-pcie-gen3 112f8000.pcie: MEM 0x0024200000..0x0027ffffff -> 0x0024200000 [ 10.941278] mtk-pcie-gen3 112f8000.pcie: PCI host bridge to bus 0000:00 [ 10.785937] xhci-mtk 11290000.usb: uwk - reg:0x400, version:104 [ 10.796352] xhci-mtk 11290000.usb: xHCI Host Controller [ 10.810530] xhci-mtk 11290000.usb: new USB bus registered, assigned bus number 5 [ 10.844258] xhci-mtk 11290000.usb: clocks are not stable (0x1003d0f) [ 10.844262] xhci-mtk 11290000.usb: can't setup: -110 [ 10.844266] xhci-mtk 11290000.usb: USB bus 5 deregistered [ 10.861969] xhci-mtk 11290000.usb: probe with driver xhci-mtk failed with error -110 In fact it seems to have made the issue more frequent, as it happened every time for the 5 boots I tried. But that gives me idea to try booting with clk_ignore_unused and pd_ignore_unused. I'll update the report with the results. Thanks, Nícolas > --- > arch/arm64/boot/dts/mediatek/mt8195.dtsi | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8195.dtsi b/arch/arm64/boot/dts/mediatek/mt8195.dtsi > index 2ee45752583c..96ad1b14626e 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8195.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8195.dtsi > @@ -1445,6 +1445,7 @@ xhci1: usb@11290000 { > reg-names = "mac", "ippc"; > interrupts = ; > phys = <&u2port1 PHY_TYPE_USB2>; > + power-domains = <&spm MT8195_POWER_DOMAIN_PCIE_MAC_P1>; > assigned-clocks = <&topckgen CLK_TOP_USB_TOP_1P>, > <&topckgen CLK_TOP_SSUSB_XHCI_1P>; > assigned-clock-parents = <&topckgen CLK_TOP_UNIVPLL_D5_D4>, > -- > 2.45.2 >