From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 00B98C021B1 for ; Thu, 20 Feb 2025 11:03:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:Subject:References:In-Reply-To:Message-Id:Cc:To:From:Date: MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Qp160iELwUVLpaIl0+ASJx5ZNgXaK9DNbEoCN7xfpTA=; b=cmxMvrE3pmPsbK95ZY7ZxEqT71 Igqr+AxzRV+ZH+18wcAw12+r0yiKnnAjvz1pIjfKd6aGxKtq1hZqsN0O3UySfUOcN+mA1d9iucQ/p c6QQzu/aUrHkQaklMZ4jcCmidS8fHQ3rnwro1LlA0+CIHtK1y5cBY5DTHjy3w59BjNLB0ojF1Lt6/ hE8NsKVDSBibC4HP2qD7tR3nPEhadRezDHYYHapjl6HKIzcHh+nru+XtXfcalRhtRzqb0BrAHZYVA pDZADRIYs/yq4KH1sUbuh9289MpxJSIltaoQl7mX2LjGGSN4eJv61kO8IEFFO6Y1DPVDLeqPt70RC EW64DyRA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tl4Kw-00000000RD3-06wJ; Thu, 20 Feb 2025 11:03:22 +0000 Received: from fout-a7-smtp.messagingengine.com ([103.168.172.150]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tl4Gd-00000000PvX-1wQ6 for linux-arm-kernel@lists.infradead.org; Thu, 20 Feb 2025 10:58:57 +0000 Received: from phl-compute-11.internal (phl-compute-11.phl.internal [10.202.2.51]) by mailfout.phl.internal (Postfix) with ESMTP id 2148A138017F; Thu, 20 Feb 2025 05:58:52 -0500 (EST) Received: from phl-imap-11 ([10.202.2.101]) by phl-compute-11.internal (MEProxy); Thu, 20 Feb 2025 05:58:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1740049132; x=1740135532; bh=Qp160iELwUVLpaIl0+ASJx5ZNgXaK9DNbEoCN7xfpTA=; b= mCjBNOWFZmulhFFBOoOHFm71MoQD/R+gelap6lBfyAOl6sxV4TdMy3Im3w05Dm7t BAAmbbLZmA3zkftnXsAROmvXP/xMqMCXJWa7hXtenH23olIZl4l/W7CrA4F/LSoh XW/dT4Aoxk3hOSNn2YX6pkCvE69yN2kk773Gk1aorC54rJIfOm3gsVQPTqn9cfXL XekhmJWmaTd9lurdFoDMbs3HDTvdIkgApbuOhlyj1GBPcKYe/xZOMCu3wIAj8Z7v 3uwqayH5tDZhoPavVwv95WecGq3h+ZMaXEwuFSEWTJvT35rOf3QB2qSL6CCmgfC0 Q9O00xh/lGngF+9pgrDrlQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1740049132; x= 1740135532; bh=Qp160iELwUVLpaIl0+ASJx5ZNgXaK9DNbEoCN7xfpTA=; b=r wdVB45CP+Kp5k5dscauKGxGU5s6y2WVMsNVdETe1/e4hqMxRA8WDPS9Ra3bB6aFW UfcZDURkkwfZH/l2SKbOvyWfzcsU1d5vekBK9N9XxPP36A2PBMFFgd50MhJZD3hA C88su7xttUV2BtXGcABrUYnRxCbKEK0h++Id0plcQc+H4JXsot0r9XXdI193dv0K 3paLFyKQBua8hCdSV0Adg1QExMmh8ZucwjlT1M+Z/ggPhNaqfdM4Ynhe+SwCXT6m LlMDDcJdnPKQZ2E1hS2u81KYW9sbYYsvIepfKB8y7jR/ddzJDvYIZhGVwXevM+AS IhnL00Q/3gguM3r20Cf8Q== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdeiieeliecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpefoggffhffvvefkjghfufgtgfesthejredtredt tdenucfhrhhomhepfdetrhhnugcuuegvrhhgmhgrnhhnfdcuoegrrhhnugesrghrnhgusg druggvqeenucggtffrrghtthgvrhhnpefhtdfhvddtfeehudekteeggffghfejgeegteef gffgvedugeduveelvdekhfdvieenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmh epmhgrihhlfhhrohhmpegrrhhnugesrghrnhgusgdruggvpdhnsggprhgtphhtthhopedu uddpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtoheptggrthgrlhhinhdrmhgrrhhinh grshesrghrmhdrtghomhdprhgtphhtthhopegtihigqdhkvghrnhgvlhdquhhpshhtrhgv rghmsegtihigthgvtghhrdgtohhmpdhrtghpthhtohepfhhughgrnhhgrdguuhgrnhestg higihtvggthhdrtghomhdprhgtphhtthhopehpvghtvghrrdgthhgvnhestghigihtvggt hhdrtghomhdprhgtphhtthhopegtohhnohhrodgutheskhgvrhhnvghlrdhorhhgpdhrtg hpthhtohepkhhriihkodgutheskhgvrhhnvghlrdhorhhgpdhrtghpthhtoheprhhosghh sehkvghrnhgvlhdrohhrghdprhgtphhtthhopeifihhllheskhgvrhhnvghlrdhorhhgpd hrtghpthhtoheplhhinhhugidqrghrmhdqkhgvrhhnvghlsehlihhsthhsrdhinhhfrhgr uggvrggurdhorhhg X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id 7F3082220072; Thu, 20 Feb 2025 05:58:51 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface MIME-Version: 1.0 Date: Thu, 20 Feb 2025 11:58:21 +0100 From: "Arnd Bergmann" To: "Peter Chen" , "Rob Herring" , krzk+dt@kernel.org, "Conor Dooley" , "Catalin Marinas" , "Will Deacon" Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, cix-kernel-upstream@cixtech.com, "Fugang . duan" Message-Id: <4add2867-8c09-454a-b3e2-b4baaeccfd44@app.fastmail.com> In-Reply-To: <20250220084020.628704-7-peter.chen@cixtech.com> References: <20250220084020.628704-1-peter.chen@cixtech.com> <20250220084020.628704-7-peter.chen@cixtech.com> Subject: Re: [PATCH 6/6] arm64: dts: cix: add initial CIX P1(SKY1) dts support Content-Type: text/plain Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250220_025855_992675_EF8218AE X-CRM114-Status: GOOD ( 15.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Feb 20, 2025, at 09:40, Peter Chen wrote: > +#include "sky1.dtsi" > +/ { > + model = "Radxa Orion O6"; > + compatible = "radxa,orion-o6"; This should list both the compatible string for the board and the one for the SoC. > + > + aliases { > + serial2 = &uart2; > + }; Please put the aliases in the .dts file, not the chip specific .dtsi file, as each board typically wires these up differently. Note that the 'serial2' alias names are meant to correspond to whatever label you find on the board, not the internal numbering inside of the chip they are wired up to. Usually these start with 'serial0' for the first one that is enabled. > + CPU0: cpu0@0 { > + compatible = "arm,armv8"; > + enable-method = "psci"; This should list the actual identifier of the CPU core, not just "arm,armv8" which is the generic string used in the models for emulators that don't try to model a particular core. > + memory@80000000 { > + #address-cells = <2>; > + #size-cells = <2>; > + device_type = "memory"; > + reg = <0x00000000 0x80000000 0x1 0x00000000>; > + }; The memory size is not part of the SoC either, unless the only way to use this SoC is with on-chip eDRAM or similar. Normally this gets filled by the bootloader based on how much RAM gets detected. > + linux,cma { > + compatible = "shared-dma-pool"; > + reusable; > + size = <0x0 0x28000000>; > + linux,cma-default; > + }; Same here, this is a setting from the firmware, not the SoC. > + sky1_fixed_clocks: fixed-clocks { > + uartclk: uartclk { > + compatible = "fixed-clock"; > + #clock-cells = <0>; > + clock-frequency = <100000000>; > + clock-output-names = "uartclk"; > + uart_apb_pclk: uart_apb_pclk { > + compatible = "fixed-clock"; > + #clock-cells = <0>; > + clock-frequency = <200000000>; > + clock-output-names = "apb_pclk"; Clock names don't need "clk" in them, and there should be no underscore -- use '-' instead of '_' when separating strings in DT. > + soc@0 { > + compatible = "simple-bus"; > + #address-cells = <2>; > + #size-cells = <2>; > + ranges; > + dma-ranges; > + > + uart2: uart@040d0000 { > + compatible = "arm,pl011", "arm,primecell"; > + reg = <0x0 0x040d0000 0x0 0x1000>; > + interrupts = ; > + clock-names = "uartclk", "apb_pclk"; > + clocks = <&uartclk>, <&uart_apb_pclk>; > + status = "disabled"; > + }; It seems strange to list only "uart2" -- usually the dtsi file contains all of the instances that are present on the chip and leave it up to the .dts file to enable the ones that are used. Arnd