* [PATCH] KS8695: Fix macro definition bug in regs-switch.c
@ 2009-11-02 3:53 zealcook at gmail.com
2009-11-02 19:42 ` Andrew Victor
0 siblings, 1 reply; 2+ messages in thread
From: zealcook at gmail.com @ 2009-11-02 3:53 UTC (permalink / raw)
To: linux-arm-kernel
From: zeal <zealcook@gmail.com>
NOTE:
1. Macro style is so strange.
2. The value 0xc0 is not match with KS8695 manual. It should be 0x0c.
Signed-off-by: zeal <zealcook@gmail.com>
---
arch/arm/mach-ks8695/include/mach/regs-switch.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-ks8695/include/mach/regs-switch.h b/arch/arm/mach-ks8695/include/mach/regs-switch.h
index 56d12e8..97e8acb 100644
--- a/arch/arm/mach-ks8695/include/mach/regs-switch.h
+++ b/arch/arm/mach-ks8695/include/mach/regs-switch.h
@@ -25,7 +25,7 @@
#define KS8695_SEC1 (0x04) /* Switch Engine Control 1 */
#define KS8695_SEC2 (0x08) /* Switch Engine Control 2 */
-#define KS8695_P(x)_C(z) (0xc0 + (((x)-1)*3 + ((z)-1))*4) /* Port Configuration Registers */
+#define KS8695_SEPXCZ(x,z) (0x0c + (((x)-1)*3 + ((z)-1))*4) /* Port Configuration Registers */
#define KS8695_SEP12AN (0x48) /* Port 1 & 2 Auto-Negotiation */
#define KS8695_SEP34AN (0x4c) /* Port 3 & 4 Auto-Negotiation */
--
1.4.4.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] KS8695: Fix macro definition bug in regs-switch.c
2009-11-02 3:53 [PATCH] KS8695: Fix macro definition bug in regs-switch.c zealcook at gmail.com
@ 2009-11-02 19:42 ` Andrew Victor
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Victor @ 2009-11-02 19:42 UTC (permalink / raw)
To: linux-arm-kernel
hi,
> 1. Macro style is so strange.
> 2. The value 0xc0 is not match with KS8695 manual. It should be 0x0c.
>
> Signed-off-by: zeal <zealcook@gmail.com>
Acked-by: Andrew Victor <linux@maxim.org.za>
Please submit the patch to Russell King's patch-tracking system.
<http://www.arm.linux.org.uk/developer/patches/>
Regards,
Andrew Victor
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-11-02 19:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-11-02 3:53 [PATCH] KS8695: Fix macro definition bug in regs-switch.c zealcook at gmail.com
2009-11-02 19:42 ` Andrew Victor
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).