From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 74F6FC54E60 for ; Thu, 14 Mar 2024 13:30:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UcZqgmewLuoqIcrU0eKFPB8bmdShW326h1Ggq1hfTZU=; b=akr4DcsDjmuHiw f6WRcj3gnc8i0ehPt8ATFCAXIRaii/wVJKFxNskN5qX6kJXDuoWzsmt699N0+4O+fImKtFA1Uuz/O 55vliMn3mRsbzgT/aFNpeFMNArX3xhq90SEw9aSKwPeVTEM9gPK9TDkMG1DvQjTPT54l9uRHvGAZQ KEzs1xayO6Kx9i3UGSseas4X+wYrsfo2onb27/8GAPPiloVyJQgEHea+DNhc4eEVxlQ+1dJbASVeV 3O9ndICvaOkCs4j9cFpYoce1zaGyR985AfXP1b7Y7ynN6u0W8VTScYe+z4dr8Bs7D1PyKWOGYVYhU X/ulJtxgR0B3DAAtIyAw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rklA4-0000000ER8k-3BXy; Thu, 14 Mar 2024 13:30:20 +0000 Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rklA2-0000000ER7v-2J8O for linux-arm-kernel@lists.infradead.org; Thu, 14 Mar 2024 13:30:20 +0000 Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-413fd8e4b3cso476565e9.3 for ; Thu, 14 Mar 2024 06:30:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1710423014; x=1711027814; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=mD3qkQbPr9JbryhWa1YZ2ITHxrO+wsqWrxU8GdzivNU=; b=WgsLoror/SfVjKUaJI2SaVrNQ1DZL+jr840mgnoZUUt8KJrDJlpHqj1XyCHCIBuab4 +BDr3E0/MqieLOSEBVd5BZUa79/oX/56cSWsmTznthisMfggqzQ/w86Fm8p7EJGB/OKb Dttb1BX95sWv5TcaSap+F0w+Ga0Ur9R0EWgZY0NyOoI8ykH8YFyCk60FtUnuc/nTNwci 3fopbj1BL4XFMUlJLbIhk+I6zVu0DZuQFu2l/NMlW5koyWvUTRv0E85bGfPM8KmHtxLg IT5xUM45+uONZC/Z4qP+DHYUuFTEojkWy/Y5geVPMj3gm/GMD4aqgpXDQPl9pOjk4VKV cDGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710423014; x=1711027814; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=mD3qkQbPr9JbryhWa1YZ2ITHxrO+wsqWrxU8GdzivNU=; b=gwE3NnPTETRAUcu/ssROK2wdVKmVrfFPaSjxQ1ay6y9MQms+LVu64Xl9h8XF1rEjfx LF7nA4TOShNkJrMcn9eocJXxpgEOYOJ1wCoQhVTQd6AnSxl3U44U6tQ8PcnbkxV0uj3y XS/ndBkse+R0UELcJzOnHNe/RLeTaAZTmTO1Jl5vhM/H9FNBm3F9OP1XA+iGnqPs728V 4lkGlQ+z1QV1CYxHkjV5CM9sW8n5iUnDNnIQB9QakLLWoPGDL47rkx1lI1rZtal951cx pk99a2R+Fo/hcIpio96OXYYQjxAcgUmB1rFqn3z/k3pV9wham95K7fIaUuJ/P5tluxXy 7zFg== X-Forwarded-Encrypted: i=1; AJvYcCV4xwNiR0jnugZNEHN03DnECWi0WZ481dLBDRm4OnSu4mhJJLzg8ImQQ6REp0RhYINKS8jK/ICpe7TFyvZhNc94ew1gYq9z9GiUBoDt82QNZtS8jzY= X-Gm-Message-State: AOJu0YynKLUatslU2+fOT5fkAN87Oc2qJPsr8AHFCLPCfIAHVLxKCYnJ tfgl0M33GnL2XTfpEHnXO8Yo72hfQdUHgE9oBfJfW0mwJhllGgAaLzCysL3oVKY= X-Google-Smtp-Source: AGHT+IHUI8pInUMKMU6pURDI6IOrA5SjtV26vKKqsGZ89FUmkuJ+5HmZ3wmdkA2PC8r8vd1EStbYzQ== X-Received: by 2002:a05:600c:3d18:b0:413:1dcb:b618 with SMTP id bh24-20020a05600c3d1800b004131dcbb618mr1431873wmb.39.1710423013999; Thu, 14 Mar 2024 06:30:13 -0700 (PDT) Received: from localhost ([102.222.70.76]) by smtp.gmail.com with ESMTPSA id n2-20020a05600c4f8200b004134540ae3asm2499048wmq.3.2024.03.14.06.30.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Mar 2024 06:30:13 -0700 (PDT) Date: Thu, 14 Mar 2024 16:30:09 +0300 From: Dan Carpenter To: Bhargav Raviprakash Cc: linux-kernel@vger.kernel.org, m.nirmaladevi@ltts.com, lee@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, jpanis@baylibre.com, devicetree@vger.kernel.org, arnd@arndb.de, gregkh@linuxfoundation.org, lgirdwood@gmail.com, broonie@kernel.org, linus.walleij@linaro.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, nm@ti.com, vigneshr@ti.com, kristo@kernel.org, eblanc@baylibre.com Subject: Re: [PATCH v3 09/11] regulator: tps6594-regulator: Add TI TPS65224 PMIC regulators Message-ID: <4aee8c9a-43eb-45b4-bc23-e58aede18e54@moroto.mountain> References: <20240308103455.242705-1-bhargav.r@ltts.com> <20240308103455.242705-10-bhargav.r@ltts.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240308103455.242705-10-bhargav.r@ltts.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240314_063018_681997_91DA78C0 X-CRM114-Status: GOOD ( 11.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Mar 08, 2024 at 04:04:53PM +0530, Bhargav Raviprakash wrote: > @@ -374,11 +518,17 @@ static int tps6594_request_reg_irqs(struct platform_device *pdev, > { > struct tps6594_regulator_irq_type *irq_type; > struct tps6594 *tps = dev_get_drvdata(pdev->dev.parent); > - int j; > + size_t j; > int irq; > int error; > + size_t interrupt_cnt; > + > + if (tps->chip_id == TPS6594) > + interrupt_cnt = ARRAY_SIZE(tps6594_buck1_irq_types); > + else > + interrupt_cnt = ARRAY_SIZE(tps65224_buck1_irq_types); ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > > - for (j = 0; j < REGS_INT_NB; j++) { > + for (j = 0; j < interrupt_cnt; j++) { > irq_type = &tps6594_regs_irq_types[j]; ^^^^^^^^^^^^^^^^^^^^^^ > irq = platform_get_irq_byname(pdev, irq_type->irq_name); > if (irq < 0) The tps6594_regs_irq_types pointer needs to be renamed or people won't know it's holding tps65224_ data. Probably the function should be renamed too. regards, dan carpenter _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel