Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Leng Honglin <lenghonglin@axera-tech.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Shi Zhicheng <shizhicheng@axera-tech.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	Linus Walleij <linusw@kernel.org>,
	Drew Fustini <fustini@kernel.org>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, soc@lists.linux.dev
Subject: Re: [PATCH 5/6] arm64: dts: axera: add AX650 Demo initial support
Date: Fri, 21 Aug 2026 11:45:42 +0200	[thread overview]
Message-ID: <4af6ebe2-c476-4251-829b-2d41239da7ff@kernel.org> (raw)
In-Reply-To: <20260821-ax650-v1-v1-5-e1b013938e6b@axera-tech.com>

On 21/08/2026 11:30, Leng Honglin wrote:
> Add initial device tree support for the Axera AX650 SoC and Demo board.
> 
> Reviewed-by: Shi Zhicheng <shizhicheng@axera-tech.com>

I have more doubts, looks more like automated acking.

...

> +	/* GIC-400 block base; register frames start at offset 0x1000. */
> +	gic: interrupt-controller@4900000 {

MMIO nodes are not placed in top level and your internal review should
have tell you that.

Also, entire file looks like failing on dt-style-check.

Best regards,
Krzysztof


  reply	other threads:[~2026-08-21  9:46 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-21  9:30 [PATCH 0/6] arm64: Introduce Axera AX650 SoC and AX650 Demo board Leng Honglin
2026-08-21  9:30 ` [PATCH 1/6] dt-bindings: vendor-prefixes: add Axera Leng Honglin
2026-08-21  9:43   ` Krzysztof Kozlowski
2026-08-21  9:30 ` [PATCH 2/6] dt-bindings: arm: add Axera AX650 SoC and AX650 Demo board Leng Honglin
2026-08-21  9:30 ` [PATCH 3/6] arm64: Kconfig.platforms: add ARCH_AXERA Leng Honglin
2026-08-21  9:30 ` [PATCH 4/6] arm64: defconfig: enable ARCH_AXERA Leng Honglin
2026-08-21  9:30 ` [PATCH 5/6] arm64: dts: axera: add AX650 Demo initial support Leng Honglin
2026-08-21  9:45   ` Krzysztof Kozlowski [this message]
2026-08-21  9:30 ` [PATCH 6/6] MAINTAINERS: add Axera ARM SoC support Leng Honglin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4af6ebe2-c476-4251-829b-2d41239da7ff@kernel.org \
    --to=krzk@kernel.org \
    --cc=alexandre.belloni@bootlin.com \
    --cc=arnd@arndb.de \
    --cc=catalin.marinas@arm.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=fustini@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=lenghonglin@axera-tech.com \
    --cc=linusw@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=shizhicheng@axera-tech.com \
    --cc=soc@lists.linux.dev \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox