From: marek.vasut@gmail.com (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] mtd: physmap_of: Retire Gemini pad control
Date: Tue, 8 Aug 2017 23:44:39 +0200 [thread overview]
Message-ID: <4afc385a-688c-6dff-eabf-7f90ea92ca12@gmail.com> (raw)
In-Reply-To: <20170808190510.11496-1-linus.walleij@linaro.org>
On 08/08/2017 09:05 PM, Linus Walleij wrote:
> I wrote a proper pin control driver for the Gemini. Retire this
> SoC-specific pad control and rely on the pin controller to manage
> this.
>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Reviewed-by: Marek Vasut <marek.vasut@gmail.com>
Thanks!
> ---
> drivers/mtd/maps/physmap_of_gemini.c | 16 ----------------
> 1 file changed, 16 deletions(-)
>
> diff --git a/drivers/mtd/maps/physmap_of_gemini.c b/drivers/mtd/maps/physmap_of_gemini.c
> index 05b286b5289f..4ed1a6bb4d3c 100644
> --- a/drivers/mtd/maps/physmap_of_gemini.c
> +++ b/drivers/mtd/maps/physmap_of_gemini.c
> @@ -43,13 +43,6 @@
>
> #define FLASH_PARALLEL_HIGH_PIN_CNT (1 << 20) /* else low pin cnt */
>
> -/* Miscellaneous Control Register */
> -#define GLOBAL_MISC_CTRL 0x30
> -#define FLASH_PADS_MASK 0x07
> -#define NAND_PADS_DISABLE BIT(2)
> -#define PFLASH_PADS_DISABLE BIT(1)
> -#define SFLASH_PADS_DISABLE BIT(0)
> -
> static const struct of_device_id syscon_match[] = {
> { .compatible = "cortina,gemini-syscon" },
> { },
> @@ -102,15 +95,6 @@ int of_flash_probe_gemini(struct platform_device *pdev,
> map->bankwidth * 8);
> }
>
> - /* Activate parallel (NOR flash) mode */
> - ret = regmap_update_bits(rmap, GLOBAL_MISC_CTRL,
> - FLASH_PADS_MASK,
> - SFLASH_PADS_DISABLE | NAND_PADS_DISABLE);
> - if (ret) {
> - dev_err(dev, "unable to set up physmap pads\n");
> - return -ENODEV;
> - }
> -
> dev_info(&pdev->dev, "initialized Gemini-specific physmap control\n");
>
> return 0;
>
--
Best regards,
Marek Vasut
next prev parent reply other threads:[~2017-08-08 21:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-08 19:05 [PATCH] mtd: physmap_of: Retire Gemini pad control Linus Walleij
2017-08-08 21:44 ` Marek Vasut [this message]
2017-08-17 13:04 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4afc385a-688c-6dff-eabf-7f90ea92ca12@gmail.com \
--to=marek.vasut@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).