From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40EB2C2D0E4 for ; Mon, 23 Nov 2020 10:13:14 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B256D206F1 for ; Mon, 23 Nov 2020 10:13:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="s7qsM9VS"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="eQF2S0Cu" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B256D206F1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=XkUvO3kmxZtocCxAVgauNtWBRiiJqYUdsmAyqqy+bik=; b=s7qsM9VSwn/WwFnMgfIbSb4Fo oNzl5El4BuOeDGHvuF242iTPc8OrUJWrajKhJyUF76+VvZeNdG1MgVvb2Kq3xFwq1RBcrhSdqQf1g 1Mey9D3uBzCXEXCG+C+ZFJT0qyRbyMm1ZxEu/6EMEed9kuIE3QR+h9pf2EardojR2/JY/cRkL8OHW apbFuAiASZvF/DZgs4Yo4+9DlBqk/fDJZrcB47k3KU3epe0x0mclgpR5Y3gDfJJx+0CHnh0lO5HAm FH01hdwGLRJtLq3/JZlXiQtiArdKN8AjQllNCuRmrTLpUUTKX+t0cVg/GAs6mmwh1tT2xyQF2u0+l VLa/364pQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kh8ox-0002cJ-96; Mon, 23 Nov 2020 10:11:43 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kh8ov-0002cD-Cs for linux-arm-kernel@merlin.infradead.org; Mon, 23 Nov 2020 10:11:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender :Reply-To:Content-ID:Content-Description; bh=dG7qPH2WgoUgBWZMh4s3ULeMkUyx1Whmd5LxCMfKF6c=; b=eQF2S0Cuip/RQRc0lspDE5r5O9 UcAB3IVyWy+k2VuBrPlHY5Xw+fQjIYCVQcwFZl4iLiQbCWH5Fh/I1o0LCbrnXQ+PryAObrcLOs8TW uuqJwm+7jkRoRVmR7tGLPSsk+KWUXcl1ultsSmp54w6Pir99MgbghXSSkEqTdnFLSiV+hDN+zhDdM 4KZodUCOXwqaJR+98TGdpYvPvh36kUqOLXtDeW/0j5azpsiNMVU8vvNe8zivQDZs3LDcsarSn1kLA nk5+JaPQyHjxVbxVffkgtwzWvYJu2+JocPSOF8iY+XrPOVTB4YVaU2HKnrS1Puv4LEUWV7XTUV+lB SjzHQ9+Q==; Received: from foss.arm.com ([217.140.110.172]) by casper.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kh8aN-00068r-0E for linux-arm-kernel@lists.infradead.org; Mon, 23 Nov 2020 09:56:42 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CD6E1101E; Mon, 23 Nov 2020 01:56:36 -0800 (PST) Received: from [10.57.53.209] (unknown [10.57.53.209]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5C8B83F70D; Mon, 23 Nov 2020 01:56:35 -0800 (PST) Subject: Re: [RFC 06/11] coresight: ete: Detect ETE as one of the supported ETMs To: Tingwei Zhang , Anshuman Khandual References: <1605012309-24812-1-git-send-email-anshuman.khandual@arm.com> <1605012309-24812-7-git-send-email-anshuman.khandual@arm.com> <20201114053650.GA28964@codeaurora.org> From: Suzuki K Poulose Message-ID: <4b03b32c-edca-a19a-e10e-40d6fcd3cfcd@arm.com> Date: Mon, 23 Nov 2020 09:56:28 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <20201114053650.GA28964@codeaurora.org> Content-Language: en-GB X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201123_095639_748808_C2A81E93 X-CRM114-Status: GOOD ( 17.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: coresight@lists.linaro.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, mike.leach@linaro.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Tingwei, On 11/14/20 5:36 AM, Tingwei Zhang wrote: > Hi Anshuman, > > On Tue, Nov 10, 2020 at 08:45:04PM +0800, Anshuman Khandual wrote: >> From: Suzuki K Poulose >> >> Add ETE as one of the supported device types we support >> with ETM4x driver. The devices are named following the >> existing convention as ete. >> >> ETE mandates that the trace resource status register is programmed >> before the tracing is turned on. For the moment simply write to >> it indicating TraceActive. >> >> Signed-off-by: Suzuki K Poulose >> Signed-off-by: Anshuman Khandual >> --- >> @@ -1742,6 +1758,19 @@ static int etm4_probe(struct device *dev, void >> __iomem *base) >> if (!desc.access.io_mem || >> fwnode_property_present(dev_fwnode(dev), "qcom,skip-power-up")) >> drvdata->skip_power_up = true; >> + major = ETM_ARCH_MAJOR_VERSION(drvdata->arch); >> + minor = ETM_ARCH_MINOR_VERSION(drvdata->arch); >> + if (drvdata->arch >= ETM_ARCH_ETE) { >> + type_name = "ete"; >> + major -= 4; >> + } else { >> + type_name = "etm"; >> + } >> + > When trace unit supports ETE, could it be still compatible with ETMv4.4? > Can use selectively use it as ETM instead of ETE? No. Even though most of the register sets are compatible, there are additional restrictions and some new rules for the ETE. So, when you treat the ETE as an ETMv4.4, you could be treading into "UNPREDICTABLE" behaviors. Suzuki _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel