From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 204C0C433F5 for ; Tue, 15 Feb 2022 06:31:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:CC:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lb5D20kvRAA/hOy5WT8slLNDhokAQNMM+yDq3m4LDGA=; b=E0CinF1ndsMDZ4 G9Da3qHAJD3K4GkKCIe5LBsY2M/PvlyWxd4eurUihOr/ralLDtp+EiLh9+z9VftASQH+2YnG0wush kFp++rwBlSOSohW6u08SZvK2nwRVXoVv2vbrXMoitrgVZv0ECpuZphoWUxvJhj2S0hE2+BbSV6whg TtP6BLtEo2KPp/q/hmBujms2b6kDa/l1Sgn2/GClHzxdWJCQ4bSsh7CwAuqfg0GYj1lesp0EmJmUk niyrlEiJOek7VVuUP+CZw5/tWa7ADLOsgN9E+Ip1fubQk6qSx3ZPV/F2UVn6+OvokQHGV53QhYnRo iujx5fY6o9ad5b0jp0jg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nJrMJ-000f0G-Ca; Tue, 15 Feb 2022 06:30:43 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nJrMF-000eyE-QK; Tue, 15 Feb 2022 06:30:41 +0000 X-UUID: ee5650d0b9c1429baf6afd6eacb8262d-20220214 X-UUID: ee5650d0b9c1429baf6afd6eacb8262d-20220214 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1586090747; Mon, 14 Feb 2022 23:30:37 -0700 Received: from mtkexhb02.mediatek.inc (172.21.101.103) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 14 Feb 2022 22:24:41 -0800 Received: from mtkcas10.mediatek.inc (172.21.101.39) by mtkexhb02.mediatek.inc (172.21.101.103) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 15 Feb 2022 14:24:40 +0800 Received: from mtksdccf07 (172.21.84.99) by mtkcas10.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Tue, 15 Feb 2022 14:24:39 +0800 Message-ID: <4b0f347eb09a156e848dc89174e0123b9a37b14d.camel@mediatek.com> Subject: Re: [PATCH v3 05/31] clk: mediatek: gate: Clean up included headers From: Chun-Jie Chen To: Chen-Yu Tsai , Stephen Boyd , Michael Turquette , Matthias Brugger CC: AngeloGioacchino Del Regno , Miles Chen , , , , Date: Tue, 15 Feb 2022 14:24:40 +0800 In-Reply-To: <20220208124034.414635-6-wenst@chromium.org> References: <20220208124034.414635-1-wenst@chromium.org> <20220208124034.414635-6-wenst@chromium.org> X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220214_223039_877532_1A294C79 X-CRM114-Status: GOOD ( 15.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 2022-02-08 at 20:40 +0800, Chen-Yu Tsai wrote: > Some included headers aren't actually used anywhere, while other > headers > with the declaration of functions and structures aren't directly > included. > > Get rid of the unused ones, and add the ones that should be included > directly. > > On the header side, replace headers that are included purely for data > structure definitions with forward declarations. This decreases the > amount of preprocessing and compilation effort required for each > inclusion. > > Signed-off-by: Chen-Yu Tsai > Reviewed-by: Miles Chen > Reviewed-by: AngeloGioacchino Del Regno < > angelogioacchino.delregno@collabora.com> Reviewed-by: Chun-Jie Chen > --- > drivers/clk/mediatek/clk-gate.c | 11 +++-------- > drivers/clk/mediatek/clk-gate.h | 10 +++++++--- > 2 files changed, 10 insertions(+), 11 deletions(-) > > diff --git a/drivers/clk/mediatek/clk-gate.c > b/drivers/clk/mediatek/clk-gate.c > index ed1ad5535d41..e8881ae1489a 100644 > --- a/drivers/clk/mediatek/clk-gate.c > +++ b/drivers/clk/mediatek/clk-gate.c > @@ -4,18 +4,13 @@ > * Author: James Liao > */ > > -#include > -#include > - > -#include > -#include > -#include > -#include > #include > -#include > #include > #include > +#include > #include > +#include > +#include > > #include "clk-gate.h" > > diff --git a/drivers/clk/mediatek/clk-gate.h > b/drivers/clk/mediatek/clk-gate.h > index 344adffb6578..6b5738826a22 100644 > --- a/drivers/clk/mediatek/clk-gate.h > +++ b/drivers/clk/mediatek/clk-gate.h > @@ -7,9 +7,13 @@ > #ifndef __DRV_CLK_GATE_H > #define __DRV_CLK_GATE_H > > -#include > -#include > -#include > +#include > + > +struct clk; > +struct clk_onecell_data; > +struct clk_ops; > +struct device; > +struct device_node; > > extern const struct clk_ops mtk_clk_gate_ops_setclr; > extern const struct clk_ops mtk_clk_gate_ops_setclr_inv; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel