From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57D1CC433DB for ; Fri, 29 Jan 2021 15:37:26 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F220664E0E for ; Fri, 29 Jan 2021 15:37:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F220664E0E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=/7ljnHO5BaxpEay6lbstEzPHRESpgjKmtFyywR7Lsrw=; b=lrVbn0OxuM34XF8g+ZyJ4OgTA lXoxllwCbU5h01WmMFNc3lU7PiIpOItTt68JmPz/UQRfL0rJTVzEKD8t+Gl4TnEXZuykfA9Q7HTDR PYI6B0Bf3AUP4fhU3Rg/dviHek080CEiritfjR8nDfUXHlsliH59JHOJqPT6BRbHTr5HK8MGQuUK0 pXMmpSgM3urs4xYd6bRj3EG4DBBjC+5xJsRrfRxFvRouYPVpmpfQUk0+kb8Rwo7xx02AtuEhM8nkF LuHAo31/x36H1U7XWkA1qzN/uGicHkrMyZRO/yPDy5VhnNztTYoyRJJ0HlIUiM5nEQJcyxuqTJMWT 6Vh0/TnxQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l5Vom-000681-3f; Fri, 29 Jan 2021 15:36:16 +0000 Received: from frasgout.his.huawei.com ([185.176.79.56]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l5Voj-000646-51 for linux-arm-kernel@lists.infradead.org; Fri, 29 Jan 2021 15:36:14 +0000 Received: from fraeml709-chm.china.huawei.com (unknown [172.18.147.200]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4DS1Vc2BXVz67bPw; Fri, 29 Jan 2021 23:30:00 +0800 (CST) Received: from lhreml724-chm.china.huawei.com (10.201.108.75) by fraeml709-chm.china.huawei.com (10.206.15.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Fri, 29 Jan 2021 16:35:58 +0100 Received: from [10.210.172.213] (10.210.172.213) by lhreml724-chm.china.huawei.com (10.201.108.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Fri, 29 Jan 2021 15:35:57 +0000 Subject: Re: [PATCH v3 2/3] perf/smmuv3: Add a MODULE_SOFTDEP() to indicate dependency on SMMU To: Robin Murphy , Zhen Lei , Will Deacon , Mark Rutland , Joerg Roedel , linux-arm-kernel , iommu , linux-kernel References: <20210127113258.1421-1-thunder.leizhen@huawei.com> <20210127113258.1421-3-thunder.leizhen@huawei.com> <67e0859b-2633-3516-527f-57557e210fa1@arm.com> From: John Garry Message-ID: <4b116f38-84da-9ef9-350c-8900944b0433@huawei.com> Date: Fri, 29 Jan 2021 15:34:33 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.1.2 MIME-Version: 1.0 In-Reply-To: <67e0859b-2633-3516-527f-57557e210fa1@arm.com> Content-Language: en-US X-Originating-IP: [10.210.172.213] X-ClientProxiedBy: lhreml753-chm.china.huawei.com (10.201.108.203) To lhreml724-chm.china.huawei.com (10.201.108.75) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210129_103613_378307_BCC0803F X-CRM114-Status: GOOD ( 11.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jean-Philippe Brucker Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 29/01/2021 15:12, Robin Murphy wrote: > On 2021-01-27 11:32, Zhen Lei wrote: >> The MODULE_SOFTDEP() gives user space a hint of the loading sequence. And >> when command "modprobe arm_smmuv3_pmu" is executed, the arm_smmu_v3.ko is >> automatically loaded in advance. > > Why do we need this? If probe order doesn't matter when both drivers are > built-in, why should module load order? > > TBH I'm not sure why we even have a Kconfig dependency on ARM_SMMU_V3, > given that the drivers operate completely independently :/ Can that Kconfig dependency just be removed? I think that it was added under the idea that there is no point in having the SMMUv3 PMU driver without the SMMUv3 driver. However even on that basis it seems broken, as we cannot have ARM_SMMU_V3=m + ARM_SMMU_V3_PMU=y. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel