From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0988DC3DA64 for ; Thu, 1 Aug 2024 16:38:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=FCJYAv+dJVMHTeGACwSCEhnVsUtjj600R6s2G+DqcC0=; b=l++sQDo7PPXRJLY/zNUcZ9byMn m3oLagAgZRG1oV8A60aayzc9gb8Fsi9I1r3b/2I3/x4EJ1D+OLc628GFFOTHclWsQDvXyiOUfs0h5 RnNcLBfYVSMYXqR85GQi1Fl6kuFrG1rhqNiQqpeaLV1PRZbi4GnzNgPewFg43YmzEG7jiJHaD2cnT boiyMlWWJdMN/T59cohkc+fPM1YW0wcMhwve6awRnQHvOe/s+mm25DVvIpmFLSxgUMrgvLf3GeBSV lk9myzRQr6AnMn+EMTPgDMKsrhjp4Gj+RSRG954liVC016tPDQBOVyfEhAS6f/VMkHilOfWpcs21j E7OALuCg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sZYoy-000000066QU-0gT8; Thu, 01 Aug 2024 16:38:32 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sZYnx-000000065w3-0yWD for linux-arm-kernel@bombadil.infradead.org; Thu, 01 Aug 2024 16:37:29 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID: Sender:Reply-To:Content-ID:Content-Description; bh=FCJYAv+dJVMHTeGACwSCEhnVsUtjj600R6s2G+DqcC0=; b=j7le6tUWodzqQ5QVxaVE1AD8Bi cFSEfju7SPQOg5r5pSW/qESjOVfedaK63WU86EYK1cdKxlF/2Gh/ZBIwYJgJVibBa0L/AU38A5RV6 SBktCCuyDp8nM8qTXreshiJPeNFvZr7JGzAWXapoSROPorfEKPsI3nhYx0mDmvEWRric5Rqm8OR7S jrFP4AuEOB7MfYRIHnXf7Fg2L8K33KBe53CgXU0sXFTamSc+YaqAQwvW6PzuB+x79NKhxWpPjwhg0 vH9TzcI+ojdhH3APWa7d+UFknapbJwkjWhZZiPL0bH//rOETxli7E88ZIFBtptL3ORyYePNqxJSRh 5qtY/JeA==; Received: from mail-pg1-x52c.google.com ([2607:f8b0:4864:20::52c]) by desiato.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sZYnm-00000005W6S-0jB2 for linux-arm-kernel@lists.infradead.org; Thu, 01 Aug 2024 16:37:24 +0000 Received: by mail-pg1-x52c.google.com with SMTP id 41be03b00d2f7-79b530ba612so4692510a12.2 for ; Thu, 01 Aug 2024 09:37:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1722530235; x=1723135035; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:subject:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=FCJYAv+dJVMHTeGACwSCEhnVsUtjj600R6s2G+DqcC0=; b=FyumINU3Gi+2yM8dd5LY0dl/0oxmof4AYvjkmsV8PSCTPCgzmnsY4p10yHo+Lj8ZYJ ejdgCic3y+8tawGgRk63XNegc04PiKhU6FJjRj8asDza+IXUdzk13X69qHhgE67xTybR zY5XecWnpd7VW6iazcfLvPBi2NTVXKM5uzuDg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722530235; x=1723135035; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FCJYAv+dJVMHTeGACwSCEhnVsUtjj600R6s2G+DqcC0=; b=tYeLf4QZ3depAg73ZsGaKyW6g/3jn7PHKZoSWdZPrgUWSV32P7j96oub5CL8kcD/4m tJcA73iyRXjvhCJYX0HgQ6zycLpetkkqbOe/ZhTD9REaTGwut6kd4OR/9fPQKS+Xqkvd hqWzbUDfEdKmOA3FaiksL7FupReOVfRtseCT/M4XpoQSiBT5FqtdexWvW2ypCYT0yUrx pm4f7mjOo+l3BJM8KbqXANnj/L5U3+/xo3cNcpdv2wQI+82D6hCY+BwoTRIksrPOi+gz tWr+S5xXbeSsU2VCVCBP9cVCnB/K2NPdoU7KQESgpIk94Os9+sFUYQr+gsBNtnTEbu2N yaTw== X-Forwarded-Encrypted: i=1; AJvYcCXkLC2JvRiEvJtq7jHgra3rzsl1p8bDIek4g6QjbfsG00ePBW25QWvyI+vTqWwO4JQnlt4MC7/yi5chorQ6yfFOUC8o0dDyyOudPd1Pv7VyvIRhoVE= X-Gm-Message-State: AOJu0YycvSi4FPeggPI0CferTk8tuQTiqQ5Hx8jZBU4gmdQAVdk0oujw WYKSkPFjFw+m4vc7oSwr5JGFHKo2Xiu37WrsdcXWcczLrzSn6Qnd0hoK7x6tDA== X-Google-Smtp-Source: AGHT+IFi4XqpkJhuTWsmRfkmQJZplbZMkM9PNRQR0XHWty8mb0jI59IR96PLY0jkU+0GTx7LPnLO3Q== X-Received: by 2002:a05:6a20:914e:b0:1c6:91e1:f0fc with SMTP id adf61e73a8af0-1c699615856mr1171192637.48.1722530234981; Thu, 01 Aug 2024 09:37:14 -0700 (PDT) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1ff58f5a4f3sm809905ad.93.2024.08.01.09.37.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 01 Aug 2024 09:37:14 -0700 (PDT) Message-ID: <4b26c2be-4755-486e-b7e4-e8460faf22c6@broadcom.com> Date: Thu, 1 Aug 2024 09:37:09 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 03/12] PCI: brcmstb: Use common error handling code in brcm_pcie_probe() To: Jim Quinlan , linux-pci@vger.kernel.org, Nicolas Saenz Julienne , Bjorn Helgaas , Lorenzo Pieralisi , Cyril Brulebois , Stanimir Varbanov , Manivannan Sadhasivam , Krzysztof Kozlowski , bcm-kernel-feedback-list@broadcom.com, jim2101024@gmail.com Cc: Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Rob Herring , Philipp Zabel , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , open list References: <20240731222831.14895-1-james.quinlan@broadcom.com> <20240731222831.14895-4-james.quinlan@broadcom.com> From: Florian Fainelli Autocrypt: addr=florian.fainelli@broadcom.com; keydata= xsBNBFPAG8ABCAC3EO02urEwipgbUNJ1r6oI2Vr/+uE389lSEShN2PmL3MVnzhViSAtrYxeT M0Txqn1tOWoIc4QUl6Ggqf5KP6FoRkCrgMMTnUAINsINYXK+3OLe7HjP10h2jDRX4Ajs4Ghs JrZOBru6rH0YrgAhr6O5gG7NE1jhly+EsOa2MpwOiXO4DE/YKZGuVe6Bh87WqmILs9KvnNrQ PcycQnYKTVpqE95d4M824M5cuRB6D1GrYovCsjA9uxo22kPdOoQRAu5gBBn3AdtALFyQj9DQ KQuc39/i/Kt6XLZ/RsBc6qLs+p+JnEuPJngTSfWvzGjpx0nkwCMi4yBb+xk7Hki4kEslABEB AAHNMEZsb3JpYW4gRmFpbmVsbGkgPGZsb3JpYW4uZmFpbmVsbGlAYnJvYWRjb20uY29tPsLB IQQQAQgAywUCZWl41AUJI+Jo+hcKAAG/SMv+fS3xUQWa0NryPuoRGjsA3SAUAAAAAAAWAAFr ZXktdXNhZ2UtbWFza0BwZ3AuY29tjDAUgAAAAAAgAAdwcmVmZXJyZWQtZW1haWwtZW5jb2Rp bmdAcGdwLmNvbXBncG1pbWUICwkIBwMCAQoFF4AAAAAZGGxkYXA6Ly9rZXlzLmJyb2FkY29t Lm5ldAUbAwAAAAMWAgEFHgEAAAAEFQgJChYhBNXZKpfnkVze1+R8aIExtcQpvGagAAoJEIEx tcQpvGagWPEH/2l0DNr9QkTwJUxOoP9wgHfmVhqc0ZlDsBFv91I3BbhGKI5UATbipKNqG13Z TsBrJHcrnCqnTRS+8n9/myOF0ng2A4YT0EJnayzHugXm+hrkO5O9UEPJ8a+0553VqyoFhHqA zjxj8fUu1px5cbb4R9G4UAySqyeLLeqnYLCKb4+GklGSBGsLMYvLmIDNYlkhMdnnzsSUAS61 WJYW6jjnzMwuKJ0ZHv7xZvSHyhIsFRiYiEs44kiYjbUUMcXor/uLEuTIazGrE3MahuGdjpT2 IOjoMiTsbMc0yfhHp6G/2E769oDXMVxCCbMVpA+LUtVIQEA+8Zr6mX0Yk4nDS7OiBlvOwE0E U8AbwQEIAKxr71oqe+0+MYCc7WafWEcpQHFUwvYLcdBoOnmJPxDwDRpvU5LhqSPvk/yJdh9k 4xUDQu3rm1qIW2I9Puk5n/Jz/lZsqGw8T13DKyu8eMcvaA/irm9lX9El27DPHy/0qsxmxVmU pu9y9S+BmaMb2CM9IuyxMWEl9ruWFS2jAWh/R8CrdnL6+zLk60R7XGzmSJqF09vYNlJ6Bdbs MWDXkYWWP5Ub1ZJGNJQ4qT7g8IN0qXxzLQsmz6tbgLMEHYBGx80bBF8AkdThd6SLhreCN7Uh IR/5NXGqotAZao2xlDpJLuOMQtoH9WVNuuxQQZHVd8if+yp6yRJ5DAmIUt5CCPcAEQEAAcLB gQQYAQIBKwUCU8AbwgUbDAAAAMBdIAQZAQgABgUCU8AbwQAKCRCTYAaomC8PVQ0VCACWk3n+ obFABEp5Rg6Qvspi9kWXcwCcfZV41OIYWhXMoc57ssjCand5noZi8bKg0bxw4qsg+9cNgZ3P N/DFWcNKcAT3Z2/4fTnJqdJS//YcEhlr8uGs+ZWFcqAPbteFCM4dGDRruo69IrHfyyQGx16s CcFlrN8vD066RKevFepb/ml7eYEdN5SRALyEdQMKeCSf3mectdoECEqdF/MWpfWIYQ1hEfdm C2Kztm+h3Nkt9ZQLqc3wsPJZmbD9T0c9Rphfypgw/SfTf2/CHoYVkKqwUIzI59itl5Lze+R5 wDByhWHx2Ud2R7SudmT9XK1e0x7W7a5z11Q6vrzuED5nQvkhAAoJEIExtcQpvGagugcIAJd5 EYe6KM6Y6RvI6TvHp+QgbU5dxvjqSiSvam0Ms3QrLidCtantcGT2Wz/2PlbZqkoJxMQc40rb fXa4xQSvJYj0GWpadrDJUvUu3LEsunDCxdWrmbmwGRKqZraV2oG7YEddmDqOe0Xm/NxeSobc MIlnaE6V0U8f5zNHB7Y46yJjjYT/Ds1TJo3pvwevDWPvv6rdBeV07D9s43frUS6xYd1uFxHC 7dZYWJjZmyUf5evr1W1gCgwLXG0PEi9n3qmz1lelQ8lSocmvxBKtMbX/OKhAfuP/iIwnTsww 95A2SaPiQZA51NywV8OFgsN0ITl2PlZ4Tp9hHERDe6nQCsNI/Us= In-Reply-To: <20240731222831.14895-4-james.quinlan@broadcom.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240801_173718_936425_5FAE22C3 X-CRM114-Status: GOOD ( 10.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 7/31/24 15:28, Jim Quinlan wrote: > o Move the clk_prepare_enable() below the resource allocations. > o Move the clk_prepare_enable() out of __brcm_pcie_remove() but > add it to the end of brcm_pcie_remove(). > o Add a jump target (clk_disable_unprepare) so that a bit of exception > handling can be better reused at the end of this function implementation. > o Use dev_err_probe() where it makes sense. > > Signed-off-by: Jim Quinlan Reviewed-by: Florian Fainelli -- Florian