From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1EBD3C433F5 for ; Sat, 6 Nov 2021 07:51:53 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CECBC60ED7 for ; Sat, 6 Nov 2021 07:51:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CECBC60ED7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=perches.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:Cc:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9peakBktANBWu/zLhSFMkwK7YUW5p80ssuq0dkwi7fA=; b=KZakFHR6BPsroB YOXe0LQcBd5b8ePeaZqNl2ash9j+aEL3XZYMIJQ1P3wDZy1Gozkjk1UOZLwyMLgBBqi/asgR5CZak uwGJbRmM9pCQOcKSZAQmbT5nXoxcDZrAevcBz4rRtjwlxJd9Q5EtmgOl+5h1JOPh3KUxovKpXQARV mfDmuIaTEVd4jsQ1XhpizN8L9ccte7EzXeoUl9um1eU9ThLy4mSyRUxUY0swmzXI2UrWE/l1eUKaT JXO/Dag3kd4jzFCPtlooVVSaZHpCl5UPHn7UANamnvMUXGEdy5CQzEnLsOenFY19pCYcltqs0WQW+ vMH5WKe/58pd+jKNfo/w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mjGTG-00ClPt-JJ; Sat, 06 Nov 2021 07:50:38 +0000 Received: from smtprelay0152.hostedemail.com ([216.40.44.152] helo=smtprelay.hostedemail.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mjGTC-00ClOj-Kj; Sat, 06 Nov 2021 07:50:36 +0000 Received: from omf12.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay06.hostedemail.com (Postfix) with ESMTP id B860018223268; Sat, 6 Nov 2021 07:50:28 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: joe@perches.com) by omf12.hostedemail.com (Postfix) with ESMTPA id EA9E7240237; Sat, 6 Nov 2021 07:50:24 +0000 (UTC) Message-ID: <4b3f1ee1179dd6d4b010cb110b38d26e7d91c19f.camel@perches.com> Subject: Re: [PATCH v1 14/19] pinctrl: st: Use temporary variable for struct device From: Joe Perches To: Andy Shevchenko , Bartosz Golaszewski , Jianqun Xu , Linus Walleij , Sai Krishna Potthuri , Andrew Morton , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org Cc: Bamvor Jian Zhang , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Heiko Stuebner , Patrice Chotard , Michal Simek , Andy Shevchenko Date: Sat, 06 Nov 2021 00:50:23 -0700 In-Reply-To: <20211105124242.27288-14-andriy.shevchenko@linux.intel.com> References: <20211105124242.27288-1-andriy.shevchenko@linux.intel.com> <20211105124242.27288-14-andriy.shevchenko@linux.intel.com> User-Agent: Evolution 3.40.4-1 MIME-Version: 1.0 X-Stat-Signature: jap6txt4towx51bf66y6cdqwxohz91c7 X-Rspamd-Server: rspamout02 X-Rspamd-Queue-Id: EA9E7240237 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Session-ID: U2FsdGVkX1+6DUZa/TtJProF7+rBll2LVmF0I4FX6+w= X-HE-Tag: 1636185024-57322 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211106_005034_770369_6184B750 X-CRM114-Status: UNSURE ( 9.88 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 2021-11-05 at 14:42 +0200, Andy Shevchenko wrote: > Use temporary variable for struct device to make code neater. [] > diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c [] > @@ -814,26 +814,25 @@ static int st_pctl_dt_node_to_map(struct pinctrl_dev *pctldev, > { > struct st_pinctrl *info = pinctrl_dev_get_drvdata(pctldev); > const struct st_pctl_group *grp; > + struct device *dev = info->dev; [] > - new_map = devm_kcalloc(pctldev->dev, > - map_num, sizeof(*new_map), GFP_KERNEL); > + new_map = devm_kcalloc(dev, map_num, sizeof(*new_map), GFP_KERNEL); Are pctldev->dev and dev the same pointer? It seems they are not. Why reassign the ownership? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel