From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Haoxiang Li <haoxiang_li2024@163.com>,
robin.clark@oss.qualcomm.com, will@kernel.org,
robin.murphy@arm.com, joro@8bytes.org, jroedel@suse.de
Cc: iommu@lists.linux.dev, linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iommu/qcom: Remove sysfs device on probe failure path
Date: Tue, 23 Jun 2026 11:40:39 +0200 [thread overview]
Message-ID: <4b60bb58-bc08-4bbf-be6f-d447050af479@oss.qualcomm.com> (raw)
In-Reply-To: <20260623071245.1985938-1-haoxiang_li2024@163.com>
On 6/23/26 9:12 AM, Haoxiang Li wrote:
> In qcom_iommu_device_probe(), if iommu_device_register()
> fails, the sysfs device created by iommu_device_sysfs_add()
> is not released. Add a goto label to do the cleanup.
>
> Fixes: 0ae349a0f33f ("iommu/qcom: Add qcom_iommu")
> Signed-off-by: Haoxiang Li <haoxiang_li2024@163.com>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
prev parent reply other threads:[~2026-06-23 9:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-23 7:12 [PATCH] iommu/qcom: Remove sysfs device on probe failure path Haoxiang Li
2026-06-23 8:51 ` Mukesh Ojha
2026-06-23 9:40 ` Konrad Dybcio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b60bb58-bc08-4bbf-be6f-d447050af479@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=haoxiang_li2024@163.com \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=jroedel@suse.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robin.clark@oss.qualcomm.com \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox