From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 697DFC433EF for ; Tue, 1 Mar 2022 15:17:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=t+VeWWb4ZFdNMg0qkk/OcRRRlnljoSAUOyifO59pRrU=; b=mKGPYurUmJUxy/ dQW/TndF9Kw55qxN3c7QiqW7l5kjacubRMbiiz3wW1gT667O/r2FlnD9JGvIIjvv34QOZ+2XoZSHM X4Cmfi8qhFaStQ/2ccLdxifs8ZJP3BpnSrBnzyoFROEW5nFrYNlGfaZpEVtwTJ7H0PxPESYeDnrWU 4PveZwQ+rfretTCA0fK9bdRO9qdmPEeJnqrad49qZbISLLxq1rdXVO9nuPYnLaRo8up0ImytcIVpY 5CKL2M4FOYPm7Sm1Ozc4YpReXi25aKnjvM2pGGoMrEA1SDOTbTggDRt0KEGxOIeKKFNbfoATHzuKs V94ZKKTkDicFKQlUoc7g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nP4Es-00HEgj-Db; Tue, 01 Mar 2022 15:16:34 +0000 Received: from eu-smtp-delivery-151.mimecast.com ([185.58.85.151]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nP4En-00HEeh-VV for linux-arm-kernel@lists.infradead.org; Tue, 01 Mar 2022 15:16:31 +0000 Received: from AcuMS.aculab.com (156.67.243.121 [156.67.243.121]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id uk-mta-318-Vr7v5iKRMIKftw0gpJuxvQ-1; Tue, 01 Mar 2022 15:16:24 +0000 X-MC-Unique: Vr7v5iKRMIKftw0gpJuxvQ-1 Received: from AcuMS.Aculab.com (fd9f:af1c:a25b:0:994c:f5c2:35d6:9b65) by AcuMS.aculab.com (fd9f:af1c:a25b:0:994c:f5c2:35d6:9b65) with Microsoft SMTP Server (TLS) id 15.0.1497.28; Tue, 1 Mar 2022 15:16:22 +0000 Received: from AcuMS.Aculab.com ([fe80::994c:f5c2:35d6:9b65]) by AcuMS.aculab.com ([fe80::994c:f5c2:35d6:9b65%12]) with mapi id 15.00.1497.028; Tue, 1 Mar 2022 15:16:22 +0000 From: David Laight To: 'Miguel Ojeda' , Nick Desaulniers CC: Dan Li , Catalin Marinas , Will Deacon , Nathan Chancellor , Kees Cook , Masahiro Yamada , Thomas Gleixner , Andrew Morton , Mark Rutland , "Sami Tolvanen" , Nicholas Piggin , Guenter Roeck , Masami Hiramatsu , Miguel Ojeda , Luc Van Oostenryck , Marco Elver , linux-kernel , Linux ARM , "llvm@lists.linux.dev" , "linux-hardening@vger.kernel.org" Subject: RE: [PATCH] [PATCH v2] AARCH64: Add gcc Shadow Call Stack support Thread-Topic: [PATCH] [PATCH v2] AARCH64: Add gcc Shadow Call Stack support Thread-Index: AQHYLU7BTsy+Ydg2gUOh1XD7Md8Cb6yqo40Q Date: Tue, 1 Mar 2022 15:16:22 +0000 Message-ID: <4b7a3af66c54458681f00a55a84752ab@AcuMS.aculab.com> References: <20220225032410.25622-1-ashimida@linux.alibaba.com> <26a0a816-bc3e-2ac0-d773-0819d9f225af@linux.alibaba.com> In-Reply-To: Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.107] MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=C51A453 smtp.mailfrom=david.laight@aculab.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: aculab.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220301_071630_322856_70E9B64A X-CRM114-Status: GOOD ( 17.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Miguel Ojeda > Sent: 01 March 2022 09:29 > > On Mon, Feb 28, 2022 at 11:35 PM Nick Desaulniers > wrote: > > > > Or simply add a #define for __noscs to include/linux/compiler-gcc.h > > with appropriate guard and leave the existing #ifndef in > > include/linux/compiler_types.h as is. I'd prefer that when the > > compilers differ in terms of feature detection since it's as explicit > > as possible. > > The idea is to avoid differing here to begin with, i.e. to use the > same code for both compilers (only whenever that is possible, of > course), thus having a single `#define` in a single file. > > Do you think we will have to change in the future for some reason, > thus needing to split it again? What happens if an out of tree module is compiled with the other compiler? Surely this is part of the ABI and should be defined for the architecture? David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel