From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16333C433DF for ; Tue, 25 Aug 2020 07:23:50 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C9A4D20706 for ; Tue, 25 Aug 2020 07:23:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="A63BhcVp"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=tq-group.com header.i=@tq-group.com header.b="S9mqBrBK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C9A4D20706 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ew.tq-group.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Mime-Version:References:In-Reply-To:Date:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ZpTWp4idG/RCPqL16DnCKpvVS5DYO0RFmBY0uwZQuqk=; b=A63BhcVpGhf97i4MhZKwSJnt8 q1MtFaWxOcOLCEc9zMJdoUwmrGXP7/0LBV6QdZOrFIYJ435XbalkNJmksfrZmoSXFqow11IKyJjxO 3Uh/0K2HMTYXi8FMQ2gN4Rv9IpI8Np66VYVzagQRfMUUeBJaJfe6IX7MrAuvOG4NijSOd3TYkDU/p 6wFHFMdRs/16fpeZjZE+hLboObUDZ5CZmsvxSjGp/lqmniAbBpqcJ+x7bsbLuA9RPFyBpD1ndlOj5 bBR3G4n6Em1sOYV4FaMwZymVgc2gx3Ex2yKjirZkfA5wHWhjmmHjI3u7yI45Re3GN0KRMiW7UL+Va qnXXbW8Gg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kATHp-0005UZ-O0; Tue, 25 Aug 2020 07:22:29 +0000 Received: from mx1.tq-group.com ([62.157.118.193]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kATHn-0005Tx-CP for linux-arm-kernel@lists.infradead.org; Tue, 25 Aug 2020 07:22:28 +0000 IronPort-SDR: eNmFQX5PpPmcEviaQ2tfOjEkWWdWkKRzvrImmUXl5mVRrlUFPtqZ1wE+lK5yUYBsvhcmqsJCih WZDOx5VMYDnh/viACzRfE1Tkh+vbv8SOTGngblCPqnNJLtiYDqHBsS5aA5nttEjVzxD8QJC3I7 ex0xbFCkwsEMSF4s6ua0kKt75D+5gMj+RgDujclKkAP8wBUQcuoyiwyYCv9HyUg4fj5mw8T5nS YdSyBiigWoxxCAXJ4Z56l3KNpG2OmZkMQYvXTzJvIQI35XhVFRjkMSh1p9SzyhUAXp+PfZ4NFG UCs= X-IronPort-AV: E=Sophos;i="5.76,351,1592863200"; d="scan'208";a="13583860" Received: from unknown (HELO tq-pgp-pr1.tq-net.de) ([192.168.6.15]) by mx1-pgp.tq-group.com with ESMTP; 25 Aug 2020 09:22:25 +0200 Received: from mx1.tq-group.com ([192.168.6.7]) by tq-pgp-pr1.tq-net.de (PGP Universal service); Tue, 25 Aug 2020 09:22:25 +0200 X-PGP-Universal: processed; by tq-pgp-pr1.tq-net.de on Tue, 25 Aug 2020 09:22:25 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1598340145; x=1629876145; h=message-id:subject:from:to:cc:date:in-reply-to: references:mime-version:content-transfer-encoding; bh=4N6dkL/kwNBk8VB5tEU1JJE9/9Y0/PoteI2pocptzkY=; b=S9mqBrBKlNgb+0T+IF2kdpiiEGgikcqmK+2fhaPMQJBD4DIq/WyVeZUY hk8Uc7pGbgtT8T0BxzUrOWgSdvR3pbcNFDU/uHEqRutJi94N0uOETQEe3 TZOW8vs4lTYu+W0Vs9DTPtJgkis5DHAzYDcHO4XNtIqflxmKkfxpqw86G 4HVkmztL4Vayzhc17aZ/7uLrlikyPvTs04c+TcCWzM1ZxBFP6HxJka2oC 4N/Fb24BOEWifJHAHJUFk9wPPpD1fePf3eNrUr6kcFi4DDfLnm7qSZd94 6KWM+/iLV9kkdgWoUbtmvWeXFh+8DBSNy2OwowGeZwTC6lEnHHNCTGCRu A==; IronPort-SDR: Mo8sm6JNKdJHPOvnPGZCJUM1pHbd62JlnrYNHSQgJoCMunDMl/YvYKBGo/yinevAYV9fXAP/dm /N+Bn7rRGKn+6l2bl09VCsiCxkYyPE2Y/rmrtBKTia197y7YgLR10w/PNaGf9dGkJUOGd/1rFn 8qBVKRuQKPewSYPNAY1bruwsF8E7N67Z/3slrcCdP1CmsG2HAdsoMrjAhx63ZU6m5BDP5Eg+zg Z/TbokoBRUguSjMRQNg/JF5yOx52odm/yjXG0ZnZI5tB3Bia0cYgNTus5WzDoZWHYBc6fbdP0X YMg= X-IronPort-AV: E=Sophos;i="5.76,351,1592863200"; d="scan'208";a="13583859" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 25 Aug 2020 09:22:25 +0200 Received: from schifferm-ubuntu4.tq-net.de (schifferm-ubuntu4.tq-net.de [10.117.49.26]) by vtuxmail01.tq-net.de (Postfix) with ESMTPA id 87F0B280065; Tue, 25 Aug 2020 09:22:25 +0200 (CEST) Message-ID: <4b7d57738ce8e2130c4740a0f3f973fbaf60a7cf.camel@ew.tq-group.com> Subject: Re: (EXT) Re: [PATCH 2/2] ARM: dts: imx6qdl: tqma6: minor fixes From: Matthias Schiffer To: Fabio Estevam Date: Tue, 25 Aug 2020 09:22:23 +0200 In-Reply-To: References: <20200824091013.20640-1-matthias.schiffer@ew.tq-group.com> <20200824091013.20640-2-matthias.schiffer@ew.tq-group.com> X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 Mime-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200825_032227_748347_1C85120B X-CRM114-Status: GOOD ( 17.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sascha Hauer , linux-kernel , NXP Linux Team , Pengutronix Kernel Team , Shawn Guo , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 2020-08-24 at 18:36 -0300, Fabio Estevam wrote: > Hi Matthias, > > On Mon, Aug 24, 2020 at 6:10 AM Matthias Schiffer > wrote: > > > diff --git a/arch/arm/boot/dts/imx6qdl-tqma6.dtsi > > b/arch/arm/boot/dts/imx6qdl-tqma6.dtsi > > index 9513020ddd1a..7aaae83c1fae 100644 > > --- a/arch/arm/boot/dts/imx6qdl-tqma6.dtsi > > +++ b/arch/arm/boot/dts/imx6qdl-tqma6.dtsi > > @@ -20,7 +20,7 @@ > > &ecspi1 { > > pinctrl-names = "default"; > > pinctrl-0 = <&pinctrl_ecspi1>; > > - fsl,spi-num-chipselects = <1>; > > + num-cs = <1>; > > You could simply remove fsl,spi-num-chipselects without passing num- > cs. > > The spi core is able to count the number of chipselects passed via > cs-gpios in the device tree. Hmm, unless I'm overlooking something, this is not going to work: - spi_get_gpio_descs() sets num_chipselect to the maximum of the num_chipselect set in the driver and the number of cs-gpios - spi_imx_probe() sets num_chipselect to 3 if not specified in the device tree So I think we would end up with 3 instead of 1 chipselect. Kind regards, Matthias _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel