From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DC0B9C433F5 for ; Fri, 7 Oct 2022 07:07:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wCqxACSCcY6PSvnk05AjYsVpXZ7ch5W/G9oQmkfG5X8=; b=yPAXRFilO1cAbP 2WWBjKwbwuFONnUxIvGdvf43KlAXxOTyH7SQkSD0BPbLvaEzJ6+Ws5jdqA6MoEaX8ENbl4DgFXH/L HfQaz3Hna/wPz24y9dfkU68fsy4r+uZjWUTjgCzPCYxwb7slTDvtHMANL+26QwCD+dchU/YRFWprS AYeeft9vxQJ5Cy8Hru5OauPlbvs0u6Z0+k/rm/z2ORlW7XWdpblI6BSNAkq32TeaqWJ3W9rtLFVvm NW6Y/hvm5ri2ds0ZDJa6raUmhxGtCflPspPVNDDABiLN1lvnWfKIly3wP5EEKLouxWSA5CQa9R6OO f8BifJji+8fwtnzVPSUw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oghRW-007oPK-9T; Fri, 07 Oct 2022 07:06:46 +0000 Received: from mail-lj1-x229.google.com ([2a00:1450:4864:20::229]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oghRT-007oLW-1x for linux-arm-kernel@lists.infradead.org; Fri, 07 Oct 2022 07:06:44 +0000 Received: by mail-lj1-x229.google.com with SMTP id a10so4741044ljq.0 for ; Fri, 07 Oct 2022 00:06:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=FSmGNYPsHl9Ro1MJ7SK0qxA2b0opEEGQTUXyGcDbh9o=; b=foHGxaipVhE4g1J2J3AKimMGWlMyYJ94BYSHus4iZXvHzycxZHOaxVIcx75vQhOkhM RUVn3+LF8DvwQqMfdRMsxSMAJQngOWfZ6Svfr2JJ+G/4EvJx4bwVbjnmBY4t8CWfPni/ aOR68VVLHTz7M7lPiPwoxWld9aXAT2/zkWVus3Zvn8q61bqVvRZ33+lRHBUNJTqjTFbs 7XOGhE0fGA7qyBmXMZYY+mSQ5mFW34rU2W0UDjJGmxSIG+Y43UQsQLQ/lMx7EWFebWB4 /P3j0y4pT6ICbE7mbZW5+cWBwZvsuC95D1CrY8tVaGHo0rW8nIQJiv1qvS6CfpB+hnHJ 9lwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=FSmGNYPsHl9Ro1MJ7SK0qxA2b0opEEGQTUXyGcDbh9o=; b=7HlMSAEe+bPRoDxcva2T3wOsTeJVWaH3lVVq2Vy5cWMLOTdOAT8NTvj1nx17wPz2DA bSPQaoBUvhnb1WwLoTC+j8CejHU+Dc7VhC8LDSNobsNX9ALOjz3PBIrdJZAfqTGB4rnw Rj/oBks36TBWKvHBrYqnYPT+BP0PcWfWBpO3F+W1OZcA/s+T59vjnQ/8kqsp53Qftg8D JRXz4DrrCewKCb1+4PExnYxVd5vOus/7yfJSbx+OWd/kG6ZFo8LJ7eCyzW7yiqEkvSSn Xm85s1zCantr7sbuNPfoK9O/RzyI2wMw+PR6cGtgeNcOeTSCvgbWeD0CnJbJrElKC9j2 bbrw== X-Gm-Message-State: ACrzQf19UAeoPq6qmOKFJPrR8ezh3LKy0/ULCFnl0ccZRNPjrbXL/Cxd 2jRh56M1EFiQfsBEz01swL8Quw== X-Google-Smtp-Source: AMsMyM7eIvv5GKIgDiCZIjDDnCooaDnHvZD7wBLGQTTRpllEwxZlb9pUXT4af4QcZRMvuZKVS512JA== X-Received: by 2002:a2e:92c8:0:b0:25d:6ddf:e71d with SMTP id k8-20020a2e92c8000000b0025d6ddfe71dmr1129408ljh.170.1665126398407; Fri, 07 Oct 2022 00:06:38 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id a17-20020a056512201100b004a27bb1ad62sm173557lfb.205.2022.10.07.00.06.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 07 Oct 2022 00:06:38 -0700 (PDT) Message-ID: <4b861177-df32-ab9c-c746-f32f0ee6438d@linaro.org> Date: Fri, 7 Oct 2022 09:06:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH v3] greatlakes: dts: Add Facebook greatlakes (AST2600) BMC Content-Language: en-US To: Delphine CC Chiu , krzysztof.kozlowski@linaro.or Cc: patrick@stwcx.xyz, garnermic@fb.com, Bonnie Lo , Arnd Bergmann , Olof Johansson , soc@kernel.org, Rob Herring , Krzysztof Kozlowski , Joel Stanley , Andrew Jeffery , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-aspeed@lists.ozlabs.org References: <20221007055346.3484180-1-Delphine_CC_Chiu@Wiwynn.com> From: Krzysztof Kozlowski In-Reply-To: <20221007055346.3484180-1-Delphine_CC_Chiu@Wiwynn.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221007_000643_123057_C7AA94AC X-CRM114-Status: GOOD ( 14.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 07/10/2022 07:53, Delphine CC Chiu wrote: > Add linux device tree entry related to > greatlakes specific devices connected to BMC SoC. > > --- > --- v3 - Add documentation of board compatible (bindings) > --- - Add board compatible > --- - Remove the bootargs > --- - Revise the DTS node name > --- > --- v2 - Add binding document > --- > --- v1 - Initial draft This is a friendly reminder during the review process. It seems my previous comments were not fully addressed. Maybe my feedback got lost between the quotes, maybe you just forgot to apply it. Please go back to the previous discussion and either implement all requested changes or keep discussing them. Thank you. > --- > > Signed-off-by: Bonnie Lo > --- > arch/arm/boot/dts/Makefile | 1 + > .../dts/aspeed-bmc-facebook-greatlakes.dts | 241 ++++++++++++++++++ You need to document the binding. I think you already did, but then submitted without it. Read the process: https://elixir.bootlin.com/linux/v5.18-rc4/source/Documentation/process/submitting-patches.rst Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel