From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3F400C4332F for ; Tue, 20 Dec 2022 09:19:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=fGdIqvgMln2PvOxBfIMknhO7a6CMamNhd5Gp/zI+5Tw=; b=m9FJ86lH1lWocz 6P2FYFlJvljTwYSpM9jgY/RjW/KuuREdnh2jniyo5B379tc1s3i2Om/WyDdPFlZDvR0bQ9U/6ufvF sbpMenHY0FbNVfP4dsUVHvWLD+q/mWnHPmBewCv32wM6fwAsBzfCWsdA6qPJYMHSoxohj99NjWT2r LsfHx2HMt/UGPpYJRAR/SzghoBj68+eNC+1Ix94IKrj1xylFrph8wT7HT5zawRPDq37uDWje66ruj I1gkelyqq8jr0uZ6mm+GNeW42Io55fxEiSk4AsutkkOBfZriOMmiQD8joHT4oS1SVVbN2iyof3i5b xzmSd0IaJXAxNgEH2BQA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p7Yld-00ClxC-7m; Tue, 20 Dec 2022 09:18:33 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p7Yka-00Cl3Y-WC for linux-arm-kernel@lists.infradead.org; Tue, 20 Dec 2022 09:17:30 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1671527847; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=E8TwpXV0XnYsgvagPag9L7MpjXeefLJTkMJCGh9V7pg=; b=HUKxeEe/NQ/7x/sMkaAuGBSclBSx+N8Sk2siij16PkayDl/RrfDxowt0mcgQGXTuDGkaQL j3EIJzcO4QTMVomAbTALtfCIQBikU38/e90T25U043YmAwozoraOLHUofUAKjEko+GbWA+ UvTSIplJwSrGoIExdDb+Co7xWCQFeW8= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-674-cmHX8eEbNVyP4mkeCqHJxg-1; Tue, 20 Dec 2022 04:17:26 -0500 X-MC-Unique: cmHX8eEbNVyP4mkeCqHJxg-1 Received: by mail-wm1-f69.google.com with SMTP id v188-20020a1cacc5000000b003cf76c4ae66so7772677wme.7 for ; Tue, 20 Dec 2022 01:17:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=E8TwpXV0XnYsgvagPag9L7MpjXeefLJTkMJCGh9V7pg=; b=WL1ewV5f3A527AyMjI2Lu8r5xBrFysjFJO/+32GQqJqYjMf5k8gkJtkHGWGXV8q0IZ 47kDFEX3vrMNROqxGpsNU5U6idS/kdGjOpjo3MXtCxW/2Dp90WcSuVRGfi87hAYtdj9V GJDDLsXYeZH/r3ehEvXIwhPD8cj76EjnwU1qAVoswI2Xiu1F0zejhCu0Nzi4SKHP2qd2 pe4yiqd1Mo0YqwlNpKvw0qrn1ap/L4yr/oJ79NH5VvgA6flogAMu6j8gKk0ji9r7uXfz 42yrvra0wARJZcdeiFgKykoZdXh5s+zvKVC9q8KjdoMONKMMzbtcDqCqehkddJcTQI6b V6FA== X-Gm-Message-State: AFqh2kp6eHhlQGF2CE6pLep+vOMzZ4NJFsumVaS9GrrmciFIWJubjNLp txC0tiORK30EFeutfvRxRARFrMrksGavIZ4cLd98aIuVUGpPrqUQQYuRfx/cSu8hwTZW6jVehAE d4oZukOsgLaY6/PsW67UaB1k81VPcgT6zzRA= X-Received: by 2002:a05:600c:220c:b0:3d2:3831:e5c4 with SMTP id z12-20020a05600c220c00b003d23831e5c4mr995465wml.40.1671527845214; Tue, 20 Dec 2022 01:17:25 -0800 (PST) X-Google-Smtp-Source: AMrXdXuuo6HgeH5yLW955AXoTEHdpszfHBedFCr5hOSv462STXosZPN5E6XN8VtP9mnawtIRXA48sQ== X-Received: by 2002:a05:600c:220c:b0:3d2:3831:e5c4 with SMTP id z12-20020a05600c220c00b003d23831e5c4mr995452wml.40.1671527845031; Tue, 20 Dec 2022 01:17:25 -0800 (PST) Received: from [192.168.1.130] (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id h15-20020a05600c350f00b003c71358a42dsm30460043wmq.18.2022.12.20.01.17.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Dec 2022 01:17:24 -0800 (PST) Message-ID: <4bb928f8-ee2c-7b3c-9390-7efb53c23b80@redhat.com> Date: Tue, 20 Dec 2022 10:17:23 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH 02/18] Revert "fbcon: don't lose the console font across generic->chip driver switch" To: Thomas Zimmermann , daniel@ffwll.ch, airlied@gmail.com, deller@gmx.de Cc: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, intel-gfx@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-hyperv@vger.kernel.org References: <20221219160516.23436-1-tzimmermann@suse.de> <20221219160516.23436-3-tzimmermann@suse.de> From: Javier Martinez Canillas In-Reply-To: <20221219160516.23436-3-tzimmermann@suse.de> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221220_011729_177504_231C5027 X-CRM114-Status: GOOD ( 16.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 12/19/22 17:05, Thomas Zimmermann wrote: > This reverts commit ae1287865f5361fa138d4d3b1b6277908b54eac9. > > Always free the console font when deinitializing the framebuffer > console. Subsequent framebuffer consoles will then use the default > font. Rely on userspace to load any user-configured font for these > consoles. > > Commit ae1287865f53 ("fbcon: don't lose the console font across > generic->chip driver switch") was introduced to work around losing > the font during graphics-device handover. [1][2] It kept a dangling > pointer with the font data between loading the two consoles, which is > fairly adventurous hack. It also never covered cases when the other > consoles, such as VGA text mode, where involved. > > The problem has meanwhile been solved in userspace. Systemd comes > with a udev rule that re-installs the configured font when a console > comes up. [3] So the kernel workaround can be removed. > > This also removes one of the two special cases triggered by setting > FBINFO_MISC_FIRMWARE in an fbdev driver. > > Tested during device handover from efifb and simpledrm to radeon. Udev > reloads the configured console font for the new driver's terminal. > > Signed-off-by: Thomas Zimmermann > Link: https://bugzilla.redhat.com/show_bug.cgi?id=892340 # 1 > Link: https://bugzilla.redhat.com/show_bug.cgi?id=1074624 # 2 > Link: https://cgit.freedesktop.org/systemd/systemd/tree/src/vconsole/90-vconsole.rules.in?h=v222 # 3 > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel