From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6363DC28E83 for ; Fri, 4 Sep 2020 06:48:28 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1C50A206B8 for ; Fri, 4 Sep 2020 06:48:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="OgDiScXd"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b="UUtp1rvA" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1C50A206B8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=samsung.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:References:In-Reply-To:MIME-Version:Date:Message-ID: From:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=hvk8R6JxHlBkyk9W1CsrGB3oeXakCHxEIo2POfTVYGU=; b=OgDiScXdGB4n5QyGff7ujMXdV wCbunn/3W+F3etvV3KqCObVYQ1Fn0lNPvHnnDnV9/06WHRdU9wYxEPNSAZ3UMip5nYhaGBE6ktq6R AlUmter+79hw0AW+gMEhBLrXmxO0gaIj2UQd0SQinrQenBz3u+pRWZ5uifyg0545dqH/HAVhVb6ob 72vW/Aazq/Lo7ZUA1EVgWUe5BN15AczDhZVpIN12UIrRmAvZk5ubo9AMLaZaQsAfWNjQ9jtKAdKwp Blmob6Y8q+hWFU+ugviC2UYbsB8RAKzzkRlYtlUyyezIiqzgrl6v5Lys/FnBI/PuZpOCxvxSM3Fcv IyfHPNROA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kE5VA-0003dz-RN; Fri, 04 Sep 2020 06:47:12 +0000 Received: from mailout2.w1.samsung.com ([210.118.77.12]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kE5V7-0003cp-L2 for linux-arm-kernel@lists.infradead.org; Fri, 04 Sep 2020 06:47:11 +0000 Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200904064707euoutp02b8141d9db4b483378cee7a897803ec87~xgcV0m5PR1835718357euoutp02G for ; Fri, 4 Sep 2020 06:47:07 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200904064707euoutp02b8141d9db4b483378cee7a897803ec87~xgcV0m5PR1835718357euoutp02G DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1599202027; bh=67a+pt9I2jtHRBIG4Hc52tlennfGIpB6ZIhmKV+jdAc=; h=Subject:To:Cc:From:Date:In-Reply-To:References:From; b=UUtp1rvAsv+k+nCyMMcUzpAmjdcKyAQAJp2x1hJLvIFIhsbBOhsynwiAho/6+clNy WzogXpUFcZNO6B4+qbxgG+N3+ZflYT9+gms58N9MJMd6jJhwPvM00VkODYo7IZwKk2 7tLE0irq/RNK0Bj2HypDrvfkN5SLnD4j2C8oHO4w= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200904064707eucas1p1a492751e701126307c7afa8459d84bc1~xgcVnRxUy0374403744eucas1p1j; Fri, 4 Sep 2020 06:47:07 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id 91.C2.06456.BE2E15F5; Fri, 4 Sep 2020 07:47:07 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200904064707eucas1p24ca97f26742aed3fd092b37012861fca~xgcVM5k_51330813308eucas1p2K; Fri, 4 Sep 2020 06:47:07 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20200904064706eusmtrp218e6fe4f52d1b160b2ea5e82d9a981a9~xgcVHNqm21768817688eusmtrp2M; Fri, 4 Sep 2020 06:47:06 +0000 (GMT) X-AuditID: cbfec7f2-7efff70000001938-fa-5f51e2eb12a8 Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 12.62.06314.AE2E15F5; Fri, 4 Sep 2020 07:47:06 +0100 (BST) Received: from [106.210.88.143] (unknown [106.210.88.143]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20200904064706eusmtip276985d5c504de0a45479dcbe3d764a5f~xgcUpDwwd2982729827eusmtip2W; Fri, 4 Sep 2020 06:47:06 +0000 (GMT) Subject: Re: [PATCH v2 1/3] ARM: dts: exynos: Add assigned clock parent to CMU in Exynos3250 To: Krzysztof Kozlowski , Rob Herring , Kukjin Kim , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org From: Marek Szyprowski Message-ID: <4bc2ea2e-65a2-6c0b-9557-5777e359241a@samsung.com> Date: Fri, 4 Sep 2020 08:47:10 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20200903181425.5015-1-krzk@kernel.org> Content-Language: en-US X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrGKsWRmVeSWpSXmKPExsWy7djP87qvHwXGG3y9KWkx/8g5Vov+x6+Z Lc6f38BusenxNVaLy7vmsFnMOL+PyaJ17xF2i/anL5kdODw2repk89i8pN7j8ya5AOYoLpuU 1JzMstQifbsEroyll38zF+zirVj27j1zA2MzdxcjJ4eEgInEz1NrmLsYuTiEBFYwSuzc3sYG 4XxhlFi2+hErhPOZUeL58pdMMC0bbuyBqlrOKNH58BsLhPMeqOr3FUaQKmGBOImDjd/ZQRIi IO2XJ19jBkkwC+hKTH/3BsxmEzCU6HrbxQZi8wrYSTS+ugvUzMHBIqAiceKuFEhYFGjOsVOP WCBKBCVOznwCZnMCXXH/4TYmiJHyEtvfzoEaLy5x68l8JpC9EgLL2CUeT3nEDHG2i8T5mTvZ IGxhiVfHt7BD2DIS/3fCNDQzSjw8t5YdwukBurppBiNElbXEnXO/2ECuYxbQlFi/Sx8i7Cix eMFRdpCwhACfxI23ghBH8ElM2jadGSLMK9HRJgRRrSYx6/g6uLUHL1xinsCoNAvJa7OQvDML yTuzEPYuYGRZxSieWlqcm55abJiXWq5XnJhbXJqXrpecn7uJEZh6Tv87/mkH49dLSYcYBTgY lXh4b7wPiBdiTSwrrsw9xCjBwawkwut09nScEG9KYmVValF+fFFpTmrxIUZpDhYlcV7jRS9j hQTSE0tSs1NTC1KLYLJMHJxSDYydXvfufSzbY+p/TvcCS8fqTXt+LNfXuHR/t88G9mV/zZor AxIKb+TyhGxT/DzznsO5pH9HM224k5i7I9yya7kneTNPbv3+z8R8gfyUzbxt0VICm5LfmS/L 39Exq1fU22NHcLB/pMuN44EHOjcuW54g7qtU8fqRjKHhjWmZt4L3mOz0uHypaq8SS3FGoqEW c1FxIgCeWsMhOQMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrOIsWRmVeSWpSXmKPExsVy+t/xe7qvHgXGG5x9bWkx/8g5Vov+x6+Z Lc6f38BusenxNVaLy7vmsFnMOL+PyaJ17xF2i/anL5kdODw2repk89i8pN7j8ya5AOYoPZui /NKSVIWM/OISW6VoQwsjPUNLCz0jE0s9Q2PzWCsjUyV9O5uU1JzMstQifbsEvYyll38zF+zi rVj27j1zA2MzdxcjJ4eEgInEhht72EBsIYGljBK7t2lBxGUkTk5rYIWwhSX+XOsCquECqnnL KDH57z8WkISwQJzEmhMrWUASIgKfGSWeNW5iBkkwC+hKTH/3hhmiox2o4/ctRpAEm4ChRNfb LrB1vAJ2Eo2v7gLFOThYBFQkTtyVAgmLAg090/MCqkRQ4uTMJ2DLOIEuvf9wGxPEfDOJeZsf Qu2Sl9j+dg6ULS5x68l8pgmMQrOQtM9C0jILScssJC0LGFlWMYqklhbnpucWG+oVJ+YWl+al 6yXn525iBEbatmM/N+9gvLQx+BCjAAejEg/vjfcB8UKsiWXFlbmHGCU4mJVEeJ3Ono4T4k1J rKxKLcqPLyrNSS0+xGgK9NtEZinR5HxgEsgriTc0NTS3sDQ0NzY3NrNQEuftEDgYIySQnliS mp2aWpBaBNPHxMEp1cAYsEAppqrH9LWo8Y3IukPblnB8yGXKOfub6+1SWaY53Re219Qm7jCe fXm73epAl3VhCheMlRd0RJ05yMMqG/H7neOnue1KsnHT3GM3/pXUv8EY1Gq6cub/9yGGq06+ Vpz64trMNweeTo4Q4FWYxtJ+ffm/Ne9dO4192HdukHu7b1aEvnxbfsdFJZbijERDLeai4kQA 46qE7MoCAAA= X-CMS-MailID: 20200904064707eucas1p24ca97f26742aed3fd092b37012861fca X-Msg-Generator: CA X-RootMTR: 20200903181437eucas1p16b97d1c425672700bac7ece19084584c X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200903181437eucas1p16b97d1c425672700bac7ece19084584c References: <20200903181425.5015-1-krzk@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200904_024710_010660_DF1F6106 X-CRM114-Status: GOOD ( 23.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sylwester Nawrocki Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Krzysztof, On 03.09.2020 20:14, Krzysztof Kozlowski wrote: > Commit 52005dece527 ("ARM: dts: Add assigned clock parents to CMU node > for exynos3250") added assigned clocks under Clock Management Unit to > fix hangs when accessing ISP registers. > > However the dtschema expects "clocks" property if "assigned-clocks" are > used. Add reference to input clock, the parent used in > "assigned-clock-parents" to silence the dtschema warnings: > > arch/arm/boot/dts/exynos3250-artik5-eval.dt.yaml: clock-controller@10030000: 'clocks' is a dependency of 'assigned-clocks' > > Signed-off-by: Krzysztof Kozlowski > > --- > > Changes since v1: > 1. Add clocks property. > > This is a v2 for: > https://lore.kernel.org/linux-samsung-soc/20200901101534.GE23793@kozik-lap/T/#me85ac382b847dadbc3f6ebf30e94e70b5df1ebb6 > --- > arch/arm/boot/dts/exynos3250.dtsi | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi > index a1e93fb7f694..89b160280469 100644 > --- a/arch/arm/boot/dts/exynos3250.dtsi > +++ b/arch/arm/boot/dts/exynos3250.dtsi > @@ -214,6 +214,7 @@ > compatible = "samsung,exynos3250-cmu"; > reg = <0x10030000 0x20000>; > #clock-cells = <1>; > + clocks = <&cmu CLK_FIN_PLL>; This is not a correct input clock for this CMU. Please assign it to xusbxti, xxti or xtcxo in the respective board dts, as this is a board property. > assigned-clocks = <&cmu CLK_MOUT_ACLK_400_MCUISP_SUB>, > <&cmu CLK_MOUT_ACLK_266_SUB>; > assigned-clock-parents = <&cmu CLK_FIN_PLL>, Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel