From: Marek Vasut <marex@denx.de>
To: Boris Brezillon <boris.brezillon@collabora.com>,
Max Krummenacher <max.oss.09@gmail.com>
Cc: Christoph Niedermaier <cniedermaier@dh-electronics.com>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"Marek MV. Vasut\"" <marex@denx.de>,
David Airlie <airlied@linux.ie>,
Sascha Hauer <s.hauer@pengutronix.de>,
NXP Linux Team <linux-imx@nxp.com>,
Shawn Guo <shawnguo@kernel.org>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
"linux-arm-kernel@lists.infradead.org\""
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH V2] drm/imx: parallel-display: Remove bus flags check in imx_pd_bridge_atomic_check()
Date: Mon, 28 Feb 2022 02:04:35 +0100 [thread overview]
Message-ID: <4be01be7-decb-881c-ec3d-fb583feaed35@denx.de> (raw)
In-Reply-To: <20220221133141.06171584@collabora.com>
On 2/21/22 13:31, Boris Brezillon wrote:
> On Mon, 21 Feb 2022 12:56:43 +0100
> Max Krummenacher <max.oss.09@gmail.com> wrote:
>
>> Am Montag, den 21.02.2022, 09:29 +0100 schrieb Boris Brezillon:
>>> Hello Christoph,
>>>
>>> On Sat, 19 Feb 2022 09:28:44 +0000
>>> Christoph Niedermaier <cniedermaier@dh-electronics.com> wrote:
>>>
>>>> From: Max Krummenacher [mailto:max.oss.09@gmail.com]
>>>> Sent: Wednesday, February 9, 2022 10:38 AM
>>>>>> If display timings were read from the devicetree using
>>>>>> of_get_display_timing() and pixelclk-active is defined
>>>>>> there, the flag DISPLAY_FLAGS_SYNC_POSEDGE/NEGEDGE is
>>>>>> automatically generated. Through the function
>>>>>> drm_bus_flags_from_videomode() e.g. called in the
>>>>>> panel-simple driver this flag got into the bus flags,
>>>>>> but then in imx_pd_bridge_atomic_check() the bus flag
>>>>>> check failed and will not initialize the display. The
>>>>>> original commit fe141cedc433 does not explain why this
Can you please update the commit message to fix the following warning:
Please use git commit description style 'commit <12+ chars of sha1>
("<title line>")' - ie: 'commit fe141cedc433 ("drm/imx: pd: Use bus
format/flags provided by the bridge when available")'
Also, collect the AB from Boris and TB from Max.
I can also fix it up for you while applying if that's OK with you.
[...]
> Acked-by: Boris Brezillon <boris.brezillon@collabora.com>
[...]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-02-28 1:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-01 11:36 [PATCH V2] drm/imx: parallel-display: Remove bus flags check in imx_pd_bridge_atomic_check() Christoph Niedermaier
2022-02-09 9:38 ` Max Krummenacher
2022-02-19 9:28 ` Christoph Niedermaier
2022-02-21 8:29 ` Boris Brezillon
2022-02-21 11:56 ` Max Krummenacher
[not found] ` <20220221133141.06171584@collabora.com>
2022-02-28 1:04 ` Marek Vasut [this message]
2022-02-28 1:10 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4be01be7-decb-881c-ec3d-fb583feaed35@denx.de \
--to=marex@denx.de \
--cc=airlied@linux.ie \
--cc=boris.brezillon@collabora.com \
--cc=cniedermaier@dh-electronics.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=max.oss.09@gmail.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).