From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EE414C433EF for ; Thu, 17 Feb 2022 11:45:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NxHZ/9Ii8tJZVkZoGC8MREetTitSDoogpUjl+jybIsE=; b=sBDuQCaOa92DTF aAYqUOQFyICuq8CGg3woIo4NH6Hi9alK2M0JrZPX3MfFqyHAklkDt80tyOT18mobXOGX6EBlDrd+I nxnNSHXQbTQUtD4bGdsCvvCDwCWQeIJ7hCxh1cz5ZS0XhC9+lR9PAJOpUVdLQcF/CQiDwbQGr8F6R c3HQogo0HGJ6g09x2QniyiIZIx7ge5py5Nwrns3r4aWUW8jBBf5pHmRlfwM/SMr0//9ORfC05oBO+ ySDUl1MAh27Rc4+YOCub7gdDxtZwzrX8vY1s2MqEDuPYafbLvjhGgmZyGNT32o7UmDwcd8Qy5eKQ0 z/2N0PldsK1ZjKiHvPFA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nKfCO-00A9eE-0C; Thu, 17 Feb 2022 11:43:48 +0000 Received: from smtp-relay-internal-1.canonical.com ([185.125.188.123]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nKfCJ-00A9bJ-JK for linux-arm-kernel@lists.infradead.org; Thu, 17 Feb 2022 11:43:45 +0000 Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 9FC2A3F4BA for ; Thu, 17 Feb 2022 11:43:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1645098214; bh=3aXOIs5DNsSKgW4lPlRH0E+Ngbbzp4EOvtZ59naGoig=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=cjQ6fzIwRzlwVd91PhJZeRn+6TBH9gUF1RtPgvZbSshGgFVuAJZRp85V+zIGK7Oz0 aVXnbrFLUe6ng6E9yKX4MBZ8EC5a6ZpxBW1zAbmWN4gL5rXdv4U5tLGOTE4YaNluqe Kp6/c604HBSQ8uL1FgfXADdGN5ov6HyoOcHCQt6tl9QjX3N7P+yrgxH/k2V3amDoHl 76kWQGgf+rFNprIK14+X5e5njxkiS/SloRbbH9OoMl9IkCf0nJMOLJQDC0U3bpOfXV +QVoo2atdlAKPO+1wq/wwc4WhWjMXFxyV3nsq2g7MB6EZKUw5AkgfwK1Uq8TBHyirT NaMkgbrn5Yv2g== Received: by mail-ed1-f71.google.com with SMTP id j10-20020a05640211ca00b004090fd8a936so3333146edw.23 for ; Thu, 17 Feb 2022 03:43:34 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=3aXOIs5DNsSKgW4lPlRH0E+Ngbbzp4EOvtZ59naGoig=; b=y4RBxYEC7vU3Y2/8ZOSq6k7DGE8lF+UCI1PeqFSTg5HKxA0v5D/uwMxgMZlQEvbGMZ TMKwPbWjeQ22lHYigzijFe/vWUs7qoK/3LtwfQoXpV+zJfG5KX+ZWdez47WeTEnelTC9 lNFeqb5+LHUH6Zu9EQ3eHbLmc4CTiuWBH3BVN9JaYZ9nCV/oltrm68/jPqEtBU8vPGHb GIYGaiL1Ac/0yGYjGV7duJwkgDH12RA+ftO+O0W2vTTuSTlidnBRme/1Tzdd2u+dG4jG nkYnffDNN0oF25L5llHSILOSPK2fNwWmfnnSB3Y3qX2oWJ3bBdETe/5rmsQ+h1SUlb1i yevA== X-Gm-Message-State: AOAM531KGCt2TlCI1jBtzFlM97WvwGWLbBlyvzCWGrtQG4WyGBglE2h2 SGnM08R4IVwrIF3nV/cwrIo7ik1nIF//Q8GOjbYnkjd8BbDZw5NCZQ+dQTBgW2M9b7EypU6ATey 2CMlONskkelzf1IVkty+9ghLoB0x7d7y60tDTPjdNPUeaAVP3T3Yp X-Received: by 2002:a17:906:6158:b0:6ce:61d6:f243 with SMTP id p24-20020a170906615800b006ce61d6f243mr1988825ejl.268.1645098214313; Thu, 17 Feb 2022 03:43:34 -0800 (PST) X-Google-Smtp-Source: ABdhPJxnueVtVPrDA18T6no1BS6n/l07Q8n/Fr3Su2uWY+sD+U260MD/MJML+fbL+MqaXEB6RoP9ig== X-Received: by 2002:a17:906:6158:b0:6ce:61d6:f243 with SMTP id p24-20020a170906615800b006ce61d6f243mr1988803ejl.268.1645098214033; Thu, 17 Feb 2022 03:43:34 -0800 (PST) Received: from [192.168.0.111] (xdsl-188-155-168-84.adslplus.ch. [188.155.168.84]) by smtp.gmail.com with ESMTPSA id e27sm1130144ejm.18.2022.02.17.03.43.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Feb 2022 03:43:33 -0800 (PST) Message-ID: <4c1c1a36-2e6f-a061-5c2b-f2aac31b2d0e@canonical.com> Date: Thu, 17 Feb 2022 12:43:32 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [RFC PATCH 1/6] dt-bindings: display: imx: Add EPDC Content-Language: en-US To: Andreas Kemnade Cc: p.zabel@pengutronix.de, airlied@linux.ie, daniel@ffwll.ch, robh+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, alistair@alistair23.me, samuel@sholland.org, josua.mayer@jm0.eu, letux-kernel@openphoenux.org References: <20220206080016.796556-1-andreas@kemnade.info> <20220206080016.796556-2-andreas@kemnade.info> <36445c86-036e-0942-a9a4-919595886c67@canonical.com> <20220217123112.3ba70000@aktux> From: Krzysztof Kozlowski In-Reply-To: <20220217123112.3ba70000@aktux> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220217_034343_819622_17C0A501 X-CRM114-Status: GOOD ( 22.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 17/02/2022 12:31, Andreas Kemnade wrote: > On Thu, 17 Feb 2022 10:21:15 +0100 > Krzysztof Kozlowski wrote: > >> On 06/02/2022 09:00, Andreas Kemnade wrote: >>> Add a binding for the Electrophoretic Display Controller found at least >>> in the i.MX6. >>> The timing subnode is directly here to avoid having display parameters >>> spread all over the plate. >>> >>> Supplies are organized the same way as in the fbdev driver in the >>> NXP/Freescale kernel forks. The regulators used for that purpose, >>> like the TPS65185, the SY7636A and MAX17135 have typically a single bit to >>> start a bunch of regulators of higher or negative voltage with a >>> well-defined timing. VCOM can be handled separately, but can also be >>> incorporated into that single bit. >>> >>> Signed-off-by: Andreas Kemnade >>> --- >>> .../bindings/display/imx/fsl,mxc-epdc.yaml | 159 ++++++++++++++++++ >>> 1 file changed, 159 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/display/imx/fsl,mxc-epdc.yaml >>> > [..] > >>> + >>> + DISPLAY-supply: >>> + description: >>> + A couple of +/- voltages automatically powered on in a defintive order >> >> Typo, definitive? >> > yes, of course. > >>> + >>> + VCOM-supply: >>> + description: compensation voltage >>> + >>> + V3P3-supply: >> >> All of supplies names - lowercase. >> >>> + description: V3P3 supply >>> + >>> + epd-thermal-zone: >>> + description: >>> + Zone to get temperature of the EPD from, practically ambient temperature. >> >> Is it a phandle? >> > a string used in > of_property_read_string(priv->drm.dev->of_node, > "epd-thermal-zone", &thermal); > if (thermal) { > priv->thermal = thermal_zone_get_zone_by_name(thermal); > if (IS_ERR(priv->thermal)) > return dev_err_probe(priv->drm.dev, PTR_ERR(priv->thermal), > "unable to get thermal"); > } OK, then: $ref: /schemas/types.yaml#/definitions/string > > [...] >>> +examples: >>> + - | >>> + #include >>> + #include >>> + >>> + epdc: epdc@20f4000 { >> >> Generic node name, e.g. display-controller >> > hmm, does IHMO not make too much sense here. E.g. in the imx6sll.dtsi > we have lcd-controller next to it. So having epd-controller? But that > is exactly what epdc stands for. Still we have "lcd-controller", not "lcdc". Since this is only for epd, then "epd-controller" seems reasonable. The same as we use "interrupt-controller" (not "ic"), "dma-controller" (not "dmac" or "dc") and so on. See also list of recommended generic names from DT specification. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel