Re: [PATCH 1/3] dt-bindings: rtc: Add Raspberry Pi 5 RTC binding

[Krzysztof Kozlowski <krzk@kernel.org>]

On 09/09/2026 16:12, Sander Speetjens wrote:
> Add device tree bindings for the Raspberry Pi 5 RTC.
> Located in a custom DA9091 PMIC and accesed trough the firmware mailbox.
> 
> Signed-off-by: Sander Speetjens <sander.speetjens@gmail.com>
> Assisted-by: Grok

Your tag is the last one.

> ---
>  .../bindings/rtc/raspberrypi,rtc-rpi.yaml     | 48 +++++++++++++++++++
>  1 file changed, 48 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/rtc/raspberrypi,rtc-rpi.yaml
> 
> diff --git a/Documentation/devicetree/bindings/rtc/raspberrypi,rtc-rpi.yaml b/Documentation/devicetree/bindings/rtc/raspberrypi,rtc-rpi.yaml
> new file mode 100644
> index 000000000000..e9bade7f8c91
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/rtc/raspberrypi,rtc-rpi.yaml
> @@ -0,0 +1,48 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +

There is no blank line here.

Please instruct your Grok to follow existing sources, not come with
whatever it wants.

> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/rtc/raspberrypi,rtc-rpi.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Raspberry Pi firmware RTC
> +
> +maintainers:
> +  - Jonathan Bell <jonathan@raspberrypi.com>
> +
> +description: |
> +  Raspberry Pi RTC from the DA9091 accessed through the Raspberry Pi firmware
> +  property interface.
> +
> +properties:
> +  compatible:
> +    const: raspberrypi,rpi-rtc
> +
> +  firmware:

There is no such generic property. You need vendor prefix. Wasn't this
already discussed for Rpi? I feel like every time contributors send
downstream DTS ignoring what was discussed upstream.


> +    $ref: /schemas/types.yaml#/definitions/phandle
> +    description:
> +      Phandle to the Raspberry Pi firmware device.

You said nothing more than property name and type. Explain what for.

> +
> +  trickle-charge-microvolt:
> +    description:
> +      RTC backup battery trickle-charge voltage. A value of 0 disables
> +      trickle charging.
> +    anyOf:
> +      - const: 0
> +      - minimum: 1300000
> +        maximum: 4400000
> +
> +required:
> +  - compatible
> +  - firmware
> +

Missing ref to rtc.

Honestly, at this point you clearly did not take existing bindings at
your starting point.

> +additionalProperties: false
> +
> +examples:
> +  - |
> +    rtc {
> +        compatible = "raspberrypi,rpi-rtc";
> +        firmware = <&firmware>;
> +        status = "okay";

Nope. Again, take existing bindings. This looks like LLM slop.

A nit, subject: drop second/last, redundant "bindings". The
"dt-bindings" prefix is already stating that these are bindings.
See also:
https://elixir.bootlin.com/linux/v7.1-rc7/source/Documentation/devicetree/bindings/submitting-patches.rst#L23



> +        trickle-charge-microvolt = <0>;
> +    };


Best regards,
Krzysztof