From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F545C388F7 for ; Mon, 9 Nov 2020 15:56:26 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AC9812067B for ; Mon, 9 Nov 2020 15:56:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="owRS52eu"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pyXIQ+eZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AC9812067B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=CKNGo0O4+xKMH02qAzpdunpOhQ1lfbNeRl4NfJMeHac=; b=owRS52euFfiZ+VkpeKkNzqpj8 m0eRKmwIQzFkRqMbtUexy0rXjeX9x33GryKDIZovUH/lf/CIHPaG4QO/pT7DGfCAT244zjVmctRiU 9/IhHVynwnAQC/17b7vMwYTiJvjiGVfkfqg094Y9+8JstZjEqQYEnW8Sh4mHRkCHjVuQOPL+aXUvR vPcnPt5fDHhGKNa6/eqG6O3ki2mNSWCILAUb3ShARoTrdIRf4ZCoZR8e6CJwfH2m7yU0h8xb/owss /nb5wi00NqE8R3btOB1Gc/AubmYOd5ZnRrZWeQsRYGx1a6BRs7UwMGYL72kpek6kYzMb4hVW5ESSK lYpFNdUnA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kc9VL-0005UG-9Z; Mon, 09 Nov 2020 15:54:51 +0000 Received: from mail-pg1-x535.google.com ([2607:f8b0:4864:20::535]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kc9VI-0005Su-GA for linux-arm-kernel@lists.infradead.org; Mon, 09 Nov 2020 15:54:49 +0000 Received: by mail-pg1-x535.google.com with SMTP id i26so7493030pgl.5 for ; Mon, 09 Nov 2020 07:54:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=q9So97P5RaD1SfjadwJYSOU81IgJTVhXc7LrS5OO0kw=; b=pyXIQ+eZbNQNFBFZyhBj4nw77KGfgHaodRGeO8QBoFZz35RgljQfJ3Da+1q1ys9nD5 1pIq0sm1uXdllYrmCV5k0tqs1wEHHBPcr4uFMVNbhLxmGaScjOSLz3CAKY8JrkPfiFhB ngm2P8ku7lGChu45Of/r6zmxiK2E9knTYJBbcXDzaCRJl71GyoB0FpPJBDc35kIL5Ib1 xmO3IY1S3M+FsSLXWdI/zdvqXIS5y0ThmpMIRsDXSKp5FLuT2BbZjgbnt6yIYinqjegj kA5keV96Q2JznjihtPXLpvCHngHw+gTd9lY4toimmlIAd9d2sP8Iocug90Fs/Be+Lelu jgdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=q9So97P5RaD1SfjadwJYSOU81IgJTVhXc7LrS5OO0kw=; b=RB74oTRQfXuYI8Y2YsqKU7nIOzCzGaqGQ2AskDPUjblNxe+sSj+clF3gela64MPWKt LVtUUWSbHc9jTM6nsIWIkg8RokMkHapDKQRtTGEJBze6GfHbuEIWgMPJGCRE4qJDwj8l z4hsEC0yrq9h5CXB7Dcj4RP+TwAxcNMq459UF7kW612ad5zIgob6U8Xr/9wftk6R6kuj LMfBnb9X19eRMeXE2qy/IYRnGOuIF+1QSLb3AyYW0Oj+aJtEvz9KFkGdjIsAvGqYq0hx rI90qhjD0AHUivGxHakCVm9lvWlfppjJal/QL2bBfwZcH5KMb2AZCnrHR9GzNQ/axcbh YeUQ== X-Gm-Message-State: AOAM532S+RFQWh2IE+aESKnMuytC4aZZjh2FjYOS0OX6f4v5sOY692Dg Hoi6Hy4FTWBBj8plLdhrWMM= X-Google-Smtp-Source: ABdhPJzowlUUELs3070Lm7KfkkA0Qpe86xHqwKtTJjqhYoHQcSl+P/DeraukBAiBa6ZJtqNGyqHZHQ== X-Received: by 2002:a63:2b4f:: with SMTP id r76mr12846174pgr.194.1604937284019; Mon, 09 Nov 2020 07:54:44 -0800 (PST) Received: from [192.168.1.3] (ip68-111-84-250.oc.oc.cox.net. [68.111.84.250]) by smtp.gmail.com with ESMTPSA id l62sm11174922pga.63.2020.11.09.07.54.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Nov 2020 07:54:42 -0800 (PST) Subject: Re: [PATCH v2 2/2] ARM: dts: BCM5301X: Linksys EA9500 make use of pinctrl To: Vivek Unune References: <6687de05226dd055ee362933d4841a12b038792d.1601655904.git.npcomplete13@gmail.com> <20201104202952.783724-1-npcomplete13@gmail.com> <20201104202952.783724-3-npcomplete13@gmail.com> <20201104205836.GA783888@ubuntu> From: Florian Fainelli Message-ID: <4c264a8e-5644-f5c9-f5db-2e7b9994022e@gmail.com> Date: Mon, 9 Nov 2020 07:54:42 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.4.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201109_105448_586887_D318E57A X-CRM114-Status: GOOD ( 18.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Hauke Mehrtens , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , Linux Kernel Mailing List , Rob Herring , bcm-kernel-feedback-list , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 11/9/2020 5:24 AM, Vivek Unune wrote: > On Wed, Nov 4, 2020 at 3:58 PM Vivek Unune wrote: >> >> On Wed, Nov 04, 2020 at 12:37:45PM -0800, Florian Fainelli wrote: >>> >>> >>> On 11/4/2020 12:29 PM, Vivek Unune wrote: >>>> Now that we have a pin controller, use that instead of manuplating the >>>> mdio/mdc pins directly. i.e. we no longer require the mdio-mii-mux >>> >>> I am a bit confused here as I thought the mux was intended to >>> dynamically switch the pins in order to support both internal and >>> external MDIO devices but given the register ranges that were used, >>> these were actually the pinmux configuration for the MDC and MDIO pins. >>> >>> This does not break USB and/or PCIe PHY communication does it? >> >> Hi Florian, >> >> The external and internal MDIO logic is controlled by mdio-bus-mux. >> Which controls the BIT(9) of the mdio register. This stays. >> >> The removal of mdio-mii-mux and it's replacement with usage of >> pinctrl doesn't affect USB3 or PCIe. See below USB3 detection. >> >> [ 4295.450118] usb 1-1: new high-speed USB device number 2 using ehci-platform >> [ 4295.690183] usb 4-1: new SuperSpeed Gen 1 USB device number 2 using xhci-hcd >> [ 4295.721888] usb-storage 4-1:1.0: USB Mass Storage device detected >> [ 4295.728349] scsi host0: usb-storage 4-1:1.0 >> [ 4296.811047] scsi 0:0:0:0: Direct-Access SanDisk Ultra Fit 1.00 PQ: 0 ANSI: 6 >> [ 4296.821159] sd 0:0:0:0: [sda] 60063744 512-byte logical blocks: (30.8 GB/28.6 GiB) >> [ 4296.829667] sd 0:0:0:0: [sda] Write Protect is off >> [ 4296.834502] sd 0:0:0:0: [sda] Mode Sense: 43 00 00 00 >> [ 4296.834864] sd 0:0:0:0: [sda] Write cache: disabled, read cache: enabled, doesn't support DPO or FUA >> [ 4296.852604] GPT:Primary header thinks Alt. header is not at the end of the disk. >> [ 4296.860079] GPT:1540387 != 60063743 >> [ 4296.863586] GPT:Alternate GPT header not at the end of the disk. >> [ 4296.869600] GPT:1540387 != 60063743 >> [ 4296.873090] GPT: Use GNU Parted to correct GPT errors. >> [ 4296.878266] sda: sda1 sda2 >> [ 4296.884416] sd 0:0:0:0: [sda] Attached SCSI removable disk >> > > Hi Florian, > > Does this clarify your confusion? It does, thank you for bearing with me, I will apply this later today. -- Florian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel