From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 94C75C433EF for ; Fri, 17 Dec 2021 18:12:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Kf6gLvdZn/fz6+2jfHmTuFU9FrtXLbXFtBVhAllsP88=; b=sVswleasZzLqei iFrFvpGJ0lttkIERZyihuV/07QYiYtIgdllbPbU/PUzOc1sN+kUjiYi9GR3dYq4aCay1I9Z2kI1P0 4QwR/WpgFSRIxs08Jfkdv4KyFxMITecQpGb8nj1N1/r6NaajPNplLqbTva7XDTZO4W+S364nx9v+t RW0Rq5ld3WZURSDEQNBeJJrJ2HnEdKBdIzFTUwqOoadBj53FB/FyBKs2q9uZodfleKmCDsn3RHk9w ckDjCALp5BslYlyhMOwGKzN+mwr7KKn1wxA4/Cy+xRilGOk+/sdP1Y33tK9xYfqS1uJyPLCVH8G3Y UPSDZPJ/Chq/zsbaSrHA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1myHgc-00BhCZ-Go; Fri, 17 Dec 2021 18:10:31 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1myGcs-00BL5f-WC for linux-arm-kernel@lists.infradead.org; Fri, 17 Dec 2021 17:02:36 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1639760553; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=58xC6/7sDobq7k3UfPIWPW94AtvXxt+V86z+2iDC+2w=; b=cZ8W/lHzRw0kNJIC7M9OepbeUf4dNnZCCM/6ZkgBAgJpXjw3425Y5+VB9KZcAbBYGSqEHe vO7c8jW+YEv13++WGWoynPmQdFduE8+XVDIdqzb4ElG3tefOBuqRVEpTFvDNy3QqsZzBVd xtmxh5iKgMXYXqll5JLLqS0IbYqCEZw= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-621-ruR-3A_iOlimFAq7sNd53Q-1; Fri, 17 Dec 2021 12:02:32 -0500 X-MC-Unique: ruR-3A_iOlimFAq7sNd53Q-1 Received: by mail-wm1-f71.google.com with SMTP id a203-20020a1c7fd4000000b0034574187420so2291477wmd.5 for ; Fri, 17 Dec 2021 09:02:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=58xC6/7sDobq7k3UfPIWPW94AtvXxt+V86z+2iDC+2w=; b=o3ERHS/RzDFOc/cOtzDHXussMHjIawAMyiOCPk9QxqyKo9bH4VXfQLaZd+5JZRerAU me6BOPvInQ/WgA230/V9FqK/m/VtFD/Ucae0usN5Jekoi4H+BuUDWCI8Ja5liA/q1s1H jlwKud94YdwouOhJBCRyDv0BdNCv1sWsZ0rcIqJeFWNYvtkZ8vp+Uo6v+mqAir5YsiAz TEn2793bAmVO1PFiFIbLhthr7X3dcSK6+J51EQcBEgwbPDaa82ZYzkFzMvYi0UH8VSAq OhysB72CWxizeacsiP5gV6jyJHP5CgOV+qxS0899q7/btndSh81Jg0szlI3nWzVRqfNj EVJw== X-Gm-Message-State: AOAM5309A4Rd1qwiR7eBOUmKlbyEkkXgHpNluKyeKZwupuLdML3Pc9h2 urAw1P9NNiCSO4bS7VQtC9kVfePAUD5PCe1NsqHndDB8lMf0DyQe3i4WbXCvmddxO2W4yFNS8Pt 1JAB7ALrQeNCWdMEERQOkx9Ddm4EJVZrX5+s= X-Received: by 2002:a5d:50c2:: with SMTP id f2mr1630550wrt.459.1639760551531; Fri, 17 Dec 2021 09:02:31 -0800 (PST) X-Google-Smtp-Source: ABdhPJxt1I8ke5xrxCT2VayX74T7SOcgRXF4/LpFPypHzz/NgKLPu11J2MlPuURQrtM4+KYAlz3k6Q== X-Received: by 2002:a5d:50c2:: with SMTP id f2mr1630536wrt.459.1639760551326; Fri, 17 Dec 2021 09:02:31 -0800 (PST) Received: from ?IPV6:2001:b07:6468:f312::ac3? ([2001:b07:6468:f312::ac3]) by smtp.googlemail.com with ESMTPSA id u14sm8273562wrf.39.2021.12.17.09.02.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Dec 2021 09:02:30 -0800 (PST) Message-ID: <4c369ca2-2ad0-4a02-90e9-2d82df6c289d@redhat.com> Date: Fri, 17 Dec 2021 18:02:23 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: Possible nohz-full/RCU issue in arm64 KVM To: paulmck@kernel.org Cc: Mark Rutland , Nicolas Saenz Julienne , maz , frederic , linux-kernel , rcu , Thomas Gleixner , Will Deacon , kvmarm@lists.cs.columbia.edu, linux-arm-kernel References: <70f112072d9496d21901946ea82832d3ed3a8cb2.camel@redhat.com> <9ab8107f-ff41-6a9e-57e1-a261bea93aca@redhat.com> <20211217160749.GS641268@paulmck-ThinkPad-P17-Gen-1> <20211217164535.GU641268@paulmck-ThinkPad-P17-Gen-1> From: Paolo Bonzini In-Reply-To: <20211217164535.GU641268@paulmck-ThinkPad-P17-Gen-1> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pbonzini@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211217_090235_288915_BF847FFD X-CRM114-Status: GOOD ( 16.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 12/17/21 17:45, Paul E. McKenney wrote: > On Fri, Dec 17, 2021 at 05:34:04PM +0100, Paolo Bonzini wrote: >> On 12/17/21 17:07, Paul E. McKenney wrote: >>>> rcu_note_context_switch() is a point-in-time notification; it's not strictly >>>> necessary, but it may improve performance a bit by avoiding unnecessary IPIs >>>> from the RCU subsystem. >>>> >>>> There's no benefit from doing it when you're back from the guest, because at >>>> that point the CPU is just running normal kernel code. >>> >>> Do scheduling-clock interrupts from guest mode have the "user" parameter >>> set? If so, that would keep RCU happy. >> >> No, thread is in supervisor mode. But after every interrupt (timer tick or >> anything), one of three things can happen: >> >> * KVM will go around the execution loop and invoke rcu_note_context_switch() >> again >> >> * or KVM will go back to user space > > Here "user space" is a user process as opposed to a guest OS? Yes, that code runs from ioctl(KVM_RUN) and the ioctl will return to the calling process. Paolo >> * or the thread will be preempted >> >> and either will keep RCU happy as far as I understand. > > Regardless of the answer to my question above, yes, these will keep > RCU happy. ;-) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel