From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A0DD2C433EF for ; Tue, 25 Jan 2022 16:22:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:CC:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6GahumwZnNZCUhJnEAII6/rjc4A+9beWuAGrtQ8yxWw=; b=Ysf80KGbSV+csI HSukUxzrM3roThI08Ib90WUQYDlqnN0ebOBgPrL0BxEAk8HLb0hUS/btBJ7Ht1Nf8Tvu/FOxtiqAk L26ndHvI6cVVFM3v9FXEwmZcJclpFCDuTOrkc3iwicd9jILCzQ+ThXdp4QdiU+UzI+1R3UzM1cUqA x2UsKmjSV4w+6P9tIcT/TJkiVHklwOYkHHOkNx880ualLnjB9qvP5xRsMNpjmV1VCg/FzyRvV6+YT 6fO9eMTo2Mt+K1vlCz00hc1Q4iuUV3V/R2RWRnXMEpM7STWJ3HRE8fWKrw4n7Mcws2ybe1ZLKMF2V tod6dleF+5VLrW2H4g7A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nCOYj-008e5x-C2; Tue, 25 Jan 2022 16:20:42 +0000 Received: from mx0c-0054df01.pphosted.com ([67.231.159.91]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nCOTq-008c8B-Hy for linux-arm-kernel@lists.infradead.org; Tue, 25 Jan 2022 16:15:40 +0000 Received: from pps.filterd (m0208999.ppops.net [127.0.0.1]) by mx0c-0054df01.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 20PCEDbQ028781; Tue, 25 Jan 2022 11:15:07 -0500 Received: from can01-to1-obe.outbound.protection.outlook.com (mail-to1can01lp2054.outbound.protection.outlook.com [104.47.61.54]) by mx0c-0054df01.pphosted.com (PPS) with ESMTPS id 3dsvtr0wn6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 25 Jan 2022 11:15:07 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YuvG0sliP9JY9WFtRWeLhzHkaeO5ueKCdfmF2lddY3P3WsGStplKyIC0Ot+xj2Bq8RMBquLeRiPbX7lskQg1b0QD0pEGPyciBIZIzSxFH0Jks5Ij/zl3wbXDAV0oG3IgDlNRHwfZ7ifXd/K+zu4gx/lfljIsJJJE9SBVongJLatLtjeuetwg9TyY++Vf3mAnOJjXh9AHxPoMIj3VMmQiqv9a0adCV0xE/evDXbcheV8G6rYQBEWLAKwYtBp0aNEmEzpibjvlKayDghP/Pz1lONrbExhnslbTaVfF9ZpSEWpw+IsSWhFwfTYVPzpTXa61MvKrWzZ+owoUFc3C2htttw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=chy+u6A+BkIRiuVIKn8Zfez2DROQXpWblOLhdLhZmbw=; b=PPoHRvXrWbvzLG8CIuohNkfAir1O6RpNazlgEM3CpYvir50B4oCaLcv5U+8/Mfydn15+Ldh6POo1oJ9uRgVTC2gLtByL2p2S8QPDwVd6cbRlHjU4oBFDqB4eiURV9u1lIHsJOzQ8DZYO9D6rNgUlG87K4Tw2KdpD6OJCYPDDWEwc9yqm9/oXgQw3LXatF0UQSwT9ZG62FdTMW6qOih2MatOXVBzqUKO7aY89/sMvr8Vx4Ek10QDeJXyy9VZ+6w3Jb145Da5sq345WfT/RKKP5K0WSEsUovJClha3iTDP3e9W8mcGjhRM5tBvu0IKEwOyCowiW3/gpWsf7BM25J6BLQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=calian.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=chy+u6A+BkIRiuVIKn8Zfez2DROQXpWblOLhdLhZmbw=; b=rRehOQYbaKrECkNKQI09XmGmsXhXdbWl5Ts8Brnqx1eVqME8x6XKhMOOj2kx0IwOQmWHseuqU0w72fd57Fr57AA/hsp9joTNTcsiZr1q/OyvZxKlzGFoJdQPbekewAadq/ZCgHXSRhtHmlE+6tog4kgltihWhF4KgUsL0nNibYE= Received: from YT3PR01MB6274.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:6a::19) by YQBPR0101MB8685.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:55::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4930.15; Tue, 25 Jan 2022 16:15:06 +0000 Received: from YT3PR01MB6274.CANPRD01.PROD.OUTLOOK.COM ([fe80::6929:c39f:d893:b6c8]) by YT3PR01MB6274.CANPRD01.PROD.OUTLOOK.COM ([fe80::6929:c39f:d893:b6c8%2]) with mapi id 15.20.4888.020; Tue, 25 Jan 2022 16:15:05 +0000 From: Robert Hancock To: "m.tretter@pengutronix.de" CC: "lars@metafoo.de" , "robh+dt@kernel.org" , "jic23@kernel.org" , "devicetree@vger.kernel.org" , "michal.simek@xilinx.com" , "linux-iio@vger.kernel.org" , "manish.narani@xilinx.com" , "linux-arm-kernel@lists.infradead.org" , "kernel@pengutronix.de" , "anand.ashok.dumbre@xilinx.com" Subject: Re: [PATCH 3/4] iio: adc: xilinx-ams: Fixed wrong sequencer register settings Thread-Topic: [PATCH 3/4] iio: adc: xilinx-ams: Fixed wrong sequencer register settings Thread-Index: AQHYDZl65EvCNJi2CES6Gp15w7AZTaxzbc4AgACEbIA= Date: Tue, 25 Jan 2022 16:15:05 +0000 Message-ID: <4c5fb3899a8aafa34106a668bcb2807b6f073036.camel@calian.com> References: <20220120010246.3794962-1-robert.hancock@calian.com> <20220120010246.3794962-4-robert.hancock@calian.com> <20220125082108.GE25856@pengutronix.de> In-Reply-To: <20220125082108.GE25856@pengutronix.de> Accept-Language: en-CA, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Evolution 3.28.5 (3.28.5-18.el8) x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 52eace8d-8464-44d3-0e6e-08d9e01dd9a3 x-ms-traffictypediagnostic: YQBPR0101MB8685:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: GZHJT5zy2FszWVn5IKBAhH7FpelFjgSVNS2BtnelBuYTXennzzGQJskslQKiT2HtEntKRwMS9bBL62ekgBzFqmJePsNyrTUeab0P7rIwE+ch9Nim6vaUy9Z/3RmAEGWWdkOm1mFOCAIULkgWl+OqCgNVVK25Ea+jvN2Y13roIGM+Mvjp+H4mr6WZ6gvUVLOCZaTP8H9wqycoFwJBpmilxmdvzpuPUQqV2wbiRCFQfosm77qE59L9YbF6KOPxEaWp9F2+kXvamVzrZkU+LasTdXXX6HjyyMoGJetT0h+4F6tYBRA1C3W908rMyLqNFPZF1Kj7KUE0YTGctLGKlq41kHib2THIpajDeZ01IgvD/uJdsySGcU6rFCpEUPRYtPLla5S9de93URv3qwi2KhUxdI9FRfdO2HYUHRUh1umc7ZIqTMyoXEHcOhj4zj400uywu9DECvBN7wGz2XvMgMS5d//5n5G0EAT7DRA2Tf1oSovxUDCjXVPaIZWiKZJjstI+LPu5q/KF7wx/+MQVzLTG4cHCovLyyqb4q95ocjNTJ+Lcrtq8brH9IJZ3o+QhPOViUhhPy2hRr0alcueFWhkQrxsHqotkesJRMffcEsu91BBYevOaz2G1F4j560ud+mLfUBuZTws7zkqHQxuI4sVfnFB+/Jj8heeIzkMmhOXrH2IESnkWJyJCMS5O7HHT2rFyX2vZx8KDxzQKErywuyaZbPzrykIp6P4n+5uQsnQFU4lR122eahMxIi3dI8+n+0ZGNTEsYbNa3NA8MyZycyfJcCxRi7tBO4aElD90mYjehy/OIgBriYUYB07vQeTJpl4sFqhQ1tBXQzBXsvqcCJaF9YtSq37bF32yfypirZN1nSg= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:YT3PR01MB6274.CANPRD01.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(6506007)(122000001)(7416002)(6512007)(44832011)(4326008)(8676002)(5660300002)(38070700005)(86362001)(2906002)(38100700002)(8936002)(83380400001)(54906003)(91956017)(508600001)(2616005)(64756008)(76116006)(66946007)(6916009)(66556008)(66476007)(66446008)(26005)(6486002)(36756003)(71200400001)(186003)(316002)(15974865002)(966005)(99106002)(18886075002)(20210929001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?VUhXM1l2R1BGS2hFQk0zdHBlU1NUbmQ4emNpQ3ArMVlzcW5iZGJ6d0V2c3pw?= =?utf-8?B?TlNmNFVvd3NRbFlOc2MxSllaWjFINTk0ZlNIcXpHU052aVk0ZGpNVDRzU0pH?= =?utf-8?B?L0tYblZIMUY1b2ZTYzlwRWZMeEtZa0Y0RG5yY1Uwb0JyR1BYMTVwSG5scWho?= =?utf-8?B?elpKQlRVTEE3b0h4VUxRS3FSVDJlMEtaRU9lNUFNN0lRRVZCK0N4ZGlPWDFX?= =?utf-8?B?QmdnZnY3OTJGZHZMTjZVOFQvUW5xUkFHVWRRU2xJMnEwd1o1ejg5enM2MlpS?= =?utf-8?B?QVplcDU1blBsYVZUSGkwODFLQVkxS1E3eXRZd25STGk3MmZOZ3lvUVQreWI0?= =?utf-8?B?ZUE0ZDBlRWg4Y3hhSUZRa29GeFBRdTVSQU9CSUdTQ1hZY1k0aTNmR3I1bTQ3?= =?utf-8?B?Z3BXek5YVEk4dDB5aWZDSzJvZ3QzY0xKcnhVTS8xd3lmL1psdG5CaG8zZFZU?= =?utf-8?B?a2diSlNmT0ZzcDJ5a0pwNGNzb3VrSmpwY2tGZGRvZFZzOW1POG8zZDVkaW9M?= =?utf-8?B?eVF1WlA3UDhPZ3BtY2pyRW90ZXFWUkhxL3lpWWh3TTVYUHJGTkJxYW5vVjN6?= =?utf-8?B?OWQyNVluSkJMd2VHaUlCb3RNMWk2SlFBOUtvbHI3dHZCbnBSdVdkb1BkQTBu?= =?utf-8?B?MitGME5JUHZ2MjUraXY2em9DWG1tTmZHV2E0cVJ6TVNrUXRWdzM3eUdmcSts?= =?utf-8?B?cHVYQUZvVHBMTnJFWVFYRlhIRko1RklKSzZscnRCOUo1c2tHRzFRcUFnaWxT?= =?utf-8?B?Y1hHMzJiUDREQ1RpOHpUMUJxYi9OSVVmNUJvdytqYVh1djJCWEg2WlIxbS9S?= =?utf-8?B?MVJqcXVzc1VGZEhSSUh1LzA1dHNaL1F4VUcxNzdrRUZrT2t3Ymp4Z0hENXZl?= =?utf-8?B?NlhaSXQzQzF4RVZKUUNiNWdRUmRLSERZVy9XRUt1Z2M2SUJMSlA2VGhMSmhq?= =?utf-8?B?b1RQTXJiMDUybk1kNXRRWng4dVpvN0x2RGt3YlhBZWR5SWFnK1lKaWdpaFhi?= =?utf-8?B?L2Y4ak1NNEkvNTZOb0ZuMENZMnhCWlZPK0J1Z08vendUWHB0d3pZa1lmbGZV?= =?utf-8?B?bUxTWUYwUWxTQkNvTkhZOFMxZXlvTk4zakFEMUszNFVhVStZRTJ1NU9zZmFL?= =?utf-8?B?N25aamN6MlB5UWJ6Rzhvd1VSZUg4d3VwSHBFb2hMZ1N5SmlkUnhOeThnSFZE?= =?utf-8?B?QWN4TFdJU0lnQkVSTzNweC81c1NOTE5MZDZxbUVDckc1Tkd6RmFDOWlOUnBN?= =?utf-8?B?ZUJCVWtsd1hiSFZwYmR2bFRmbmlmdjRNVGQ0bGcrbDNtZXZnREJKT0hhQXl2?= =?utf-8?B?WFJ3ZVp4bmc2MlhDTDlGQnBVOGlLT2xsc3p2MzJKTWwzS1ZDNnNheWhIMThB?= =?utf-8?B?eDJZMXBFUGZrVEFINGV2d3lFNGxYdFk5Y0dnWVlhYkZuZXFnRmpBY0RzdnJq?= =?utf-8?B?UXhxNXZSd05DOS9CbHJ5b2RhZ3Q5TVo3cUZhY2pxOU1wTmdkaS9HRHFOUEFI?= =?utf-8?B?RFJabTBCY3U5VTU0WXNqeDc1K1oyeUp0TnQyaTNrL2FIWmpxczVDYTZRalE1?= =?utf-8?B?bEV6bDBBUWFPd3hhZFAybGd4ZWVhTXlrTVYxcldFK2RWY2QxU1lOdFQrejh0?= =?utf-8?B?SDY4YVpoV2hQU21NZy9Oc0d6NUV1RWVERjZjZE5NcWNDNjR5TXlRczZmZitm?= =?utf-8?B?cmZ6bHMvci9SbnUrbzFBdlpHRXNCUk04blNJNDYyTW1INEhwR1RRdjlZZ2tu?= =?utf-8?B?bU1Hc1lkTGlpTFVQVCtpZzM1c0todlJTR2s4RFphZ1dKb2pFMWQ3YVRadzhv?= =?utf-8?B?czZXSWtjOTZnWDRTNHZJZkpSZ3Y4RG0ySFA1WnBKTjN6SDE3NTZ0MERhUkhl?= =?utf-8?B?Uk1ROVp5NnVvajVhT1JZVmI4Sml0bWVtTS9WMlJFSkRKZHlwNnNHSkJPTHB2?= =?utf-8?B?TkpaK3J2ckM1ZXJtMTNHTVg1VkJ4WHdWZEdIUjQ0QmJ2ci9PUkI2SHQ3Njhn?= =?utf-8?B?Ynd0VVpwVWorUlFTTkhIQ3l6TUp0T2hCekkrcWZ1NlVQYWxKVXZXWnE0aGhP?= =?utf-8?B?dFVJNkp2eXFOb2VHN3JIS0xwTHlST0cxeHZydlNBRDg2NlUvM05YKzFPcWFt?= =?utf-8?B?UjNpVjlRV3VyNjZIdndTM2w0V1l1MVB1WGhiVUV2Q1lPWldnQzJKSGlCVTA0?= =?utf-8?B?KzVQMktQbmVLeHhjVzN1SXN5OG45NUtwZDR1d2RIUHEzSU5sbVpINVA1WVlx?= =?utf-8?Q?SON41BAZS0JOQFJrvO+/QpCwjXQS4M/ikoOglB18Og=3D?= Content-ID: <2C65E2A0E8AC3841BEA0CED96897D70D@CANPRD01.PROD.OUTLOOK.COM> MIME-Version: 1.0 X-OriginatorOrg: calian.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: YT3PR01MB6274.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: 52eace8d-8464-44d3-0e6e-08d9e01dd9a3 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Jan 2022 16:15:05.9338 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 23b57807-562f-49ad-92c4-3bb0f07a1fdf X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: sJAutMjmrDgiYPkxRUkL8ckUuIRNZZ4iCv20z8EQDnj8rdNthMxDWM1/KI2Pyk7nrY5QgSOAKKzIrS2Xzu3M3ADcZnc640VyODCGCTU+hfo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: YQBPR0101MB8685 X-Proofpoint-ORIG-GUID: mxhzIarMpZxpyBcT1uU4SrZGBTphX2bg X-Proofpoint-GUID: mxhzIarMpZxpyBcT1uU4SrZGBTphX2bg X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513 definitions=2022-01-25_03,2022-01-25_02,2021-12-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 bulkscore=0 clxscore=1011 spamscore=0 adultscore=0 malwarescore=0 mlxlogscore=999 suspectscore=0 phishscore=0 impostorscore=0 priorityscore=1501 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000 definitions=main-2201250104 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220125_081538_880962_C1C9B511 X-CRM114-Status: GOOD ( 21.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 2022-01-25 at 09:21 +0100, Michael Tretter wrote: > On Wed, 19 Jan 2022 19:02:45 -0600, Robert Hancock wrote: > > Register settings used for the sequencer configuration register > > were incorrect, causing some inputs to not be read properly. > > > > Fixes: d5c70627a794 ("iio: adc: Add Xilinx AMS driver") > > Signed-off-by: Robert Hancock > > --- > > drivers/iio/adc/xilinx-ams.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/iio/adc/xilinx-ams.c b/drivers/iio/adc/xilinx-ams.c > > index b93864362dac..199027c93cdc 100644 > > --- a/drivers/iio/adc/xilinx-ams.c > > +++ b/drivers/iio/adc/xilinx-ams.c > > @@ -91,8 +91,8 @@ > > > > #define AMS_CONF1_SEQ_MASK GENMASK(15, 12) > > #define AMS_CONF1_SEQ_DEFAULT FIELD_PREP(AMS_CONF1_SEQ_MASK, > > 0) > > -#define AMS_CONF1_SEQ_CONTINUOUS FIELD_PREP(AMS_CONF1_SEQ_MASK, 1) > > -#define AMS_CONF1_SEQ_SINGLE_CHANNEL FIELD_PREP(AMS_CONF1_SEQ_MASK, > > 2) > > +#define AMS_CONF1_SEQ_CONTINUOUS FIELD_PREP(AMS_CONF1_SEQ_MASK, 2) > > +#define AMS_CONF1_SEQ_SINGLE_CHANNEL FIELD_PREP(AMS_CONF1_SEQ_MASK, > > 3) > > The TRM states that Continuous Loop Mode is 2, but Single Pass Sequence Mode > is 1, not 3. Is there a reason, why you need to set both bits? Single pass sequence mode (1) just runs the same sequence only once. To read these values it needs to switch to single channel mode (3). The register bits are defined in Table 3-8 of https://www.xilinx.com/support/documentation/user_guides/ug580-ultrascale-sysmon.pdf . > > Michael > > > > > #define AMS_REG_SEQ0_MASK GENMASK(15, 0) > > #define AMS_REG_SEQ2_MASK GENMASK(21, 16) > > -- > > 2.31.1 > > > > > > _______________________________________________ > > linux-arm-kernel mailing list > > linux-arm-kernel@lists.infradead.org > > https://urldefense.com/v3/__http://lists.infradead.org/mailman/listinfo/linux-arm-kernel__;!!IOGos0k!yGFEjSC1BL20lwurby914len0HCLXyzarwxKJP9Jx30qv_qrERSkRJUiVo_2MdusMVA$ > > -- Robert Hancock Senior Hardware Designer, Calian Advanced Technologies www.calian.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel