From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Kshitiz Varshney <kshitiz.varshney@nxp.com>,
David Gstir <david@sigma-star.at>,
Mimi Zohar <zohar@linux.ibm.com>,
James Bottomley <jejb@linux.ibm.com>,
Jarkko Sakkinen <jarkko@kernel.org>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>
Cc: "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
Gaurav Jain <gaurav.jain@nxp.com>,
Catalin Marinas <catalin.marinas@arm.com>,
David Howells <dhowells@redhat.com>,
"keyrings@vger.kernel.org" <keyrings@vger.kernel.org>,
Fabio Estevam <festevam@gmail.com>,
Paul Moore <paul@paul-moore.com>,
Jonathan Corbet <corbet@lwn.net>,
Richard Weinberger <richard@nod.at>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
James Morris <jmorris@namei.org>,
dl-linux-imx <linux-imx@nxp.com>,
"Serge E. Hallyn" <serge@hallyn.com>,
"Paul E. McKenney" <paulmck@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pankaj Gupta <pankaj.gupta@nxp.com>,
sigma star Kernel Team <upstream+dcp@sigma-star.at>,
"Steven Rostedt (Google)" <rostedt@goodmis.org>,
David Oberhollenzer <david.oberhollenzer@sigma-star.at>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
Randy Dunlap <rdunlap@infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Li Yang <leoyang.li@nxp.com>,
"linux-security-module@vger.kernel.org"
<linux-security-module@vger.kernel.org>,
"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Tejun Heo <tj@kernel.org>,
"linux-integrity@vger.kernel.org"
<linux-integrity@vger.kernel.org>,
Shawn Guo <shawnguo@kernel.org>, Varun Sethi <V.Sethi@nxp.com>
Subject: Re: [EXT] [PATCH v8 3/6] KEYS: trusted: Introduce NXP DCP-backed trusted keys
Date: Tue, 9 Apr 2024 19:27:44 +0200 [thread overview]
Message-ID: <4c6164e5-bcfd-4172-a76e-db989f729a8a@pengutronix.de> (raw)
In-Reply-To: <DB6PR04MB31904A8EB8B481A530C90CBB8F072@DB6PR04MB3190.eurprd04.prod.outlook.com>
Hello Kshitiz,
On 09.04.24 12:54, Kshitiz Varshney wrote:
> Hi David,
>> + b->fmt_version = DCP_BLOB_VERSION;
>> + get_random_bytes(b->nonce, AES_KEYSIZE_128);
>> + get_random_bytes(b->blob_key, AES_KEYSIZE_128);
>
> We can use HWRNG instead of using kernel RNG. Please refer drivers/char/hw_random/imx-rngc.c
imx-rngc can be enabled and used to seed the kernel entropy pool. Adding
direct calls into imx-rngc here only introduces duplicated code at no extra
benefit.
Cheers,
Ahmad
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-04-09 17:28 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-03 7:21 [PATCH v8 0/6] DCP as trusted keys backend David Gstir
2024-04-03 7:21 ` [PATCH v8 1/6] crypto: mxs-dcp: Add support for hardware-bound keys David Gstir
2024-04-03 7:21 ` [PATCH v8 2/6] KEYS: trusted: improve scalability of trust source config David Gstir
2024-04-03 7:21 ` [PATCH v8 3/6] KEYS: trusted: Introduce NXP DCP-backed trusted keys David Gstir
2024-04-09 10:54 ` [EXT] " Kshitiz Varshney
2024-04-09 17:27 ` Ahmad Fatoum [this message]
2024-04-10 7:13 ` Kshitiz Varshney
2024-04-03 7:21 ` [PATCH v8 4/6] MAINTAINERS: add entry for DCP-based " David Gstir
2024-04-03 7:21 ` [PATCH v8 5/6] docs: document DCP-backed trusted keys kernel params David Gstir
2024-04-03 7:21 ` [PATCH v8 6/6] docs: trusted-encrypted: add DCP as new trust source David Gstir
2024-04-03 13:24 ` Bagas Sanjaya
2024-04-03 15:47 ` Jarkko Sakkinen
2024-04-09 9:48 ` [EXT] " Kshitiz Varshney
[not found] ` < <DB6PR04MB3190F6B78FF3760EBCC14E758F072@DB6PR04MB3190.eurprd04.prod.outlook.com>
2024-04-13 21:24 ` Jarkko Sakkinen
2024-04-29 11:35 ` [EXT] " David Gstir
2024-04-30 11:48 ` Kshitiz Varshney
2024-04-30 12:03 ` David Gstir
2024-05-03 23:45 ` Jarkko Sakkinen
2024-04-12 6:26 ` Herbert Xu
2024-04-13 21:44 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4c6164e5-bcfd-4172-a76e-db989f729a8a@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=V.Sethi@nxp.com \
--cc=catalin.marinas@arm.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=david.oberhollenzer@sigma-star.at \
--cc=david@sigma-star.at \
--cc=dhowells@redhat.com \
--cc=festevam@gmail.com \
--cc=gaurav.jain@nxp.com \
--cc=herbert@gondor.apana.org.au \
--cc=jarkko@kernel.org \
--cc=jejb@linux.ibm.com \
--cc=jmorris@namei.org \
--cc=kernel@pengutronix.de \
--cc=keyrings@vger.kernel.org \
--cc=kshitiz.varshney@nxp.com \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=pankaj.gupta@nxp.com \
--cc=paul@paul-moore.com \
--cc=paulmck@kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=rdunlap@infradead.org \
--cc=richard@nod.at \
--cc=rostedt@goodmis.org \
--cc=s.hauer@pengutronix.de \
--cc=serge@hallyn.com \
--cc=shawnguo@kernel.org \
--cc=tj@kernel.org \
--cc=upstream+dcp@sigma-star.at \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).