From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCA6DC5DF61 for ; Thu, 7 Nov 2019 09:54:45 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A88EB2084D for ; Thu, 7 Nov 2019 09:54:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="QoH7kkGe" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A88EB2084D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=perches.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Hh49UnuRxZ5vteYflk5zbLXgnw2VxdHEanQUkh1DqV0=; b=QoH7kkGepewIUJ dNptpduQBfERMKuSr/nnzKiOtHoD38dfj6xRLMMLWnmD1otkq/0XQibj1+xBySR8bWKQ0BOpF1fQV pDrFAP/4SxynCLtnroS1dxHiusDCMMgktp9k/pTXfeyXTGXHliJjhq45j8f3GrZ6w9eUtcAAoCZ+R r9ZDTdbNsjfK/92grtrbzg8Q+5d+p6Uad05Wpk55cPLBUF/Lpol4ohvv9dmoSts/xqXJlvy1iRyAH xv1j3kae48/2Eq+rEEqy5WdQNyU6RrWkifDCEZHkWQg+rEbFfi3ooE5r5qk0fmwUs4g02VDIdc1id ZKgR1W/331iHjV51heXA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iSeV3-0002w0-0m; Thu, 07 Nov 2019 09:54:45 +0000 Received: from smtprelay0119.hostedemail.com ([216.40.44.119] helo=smtprelay.hostedemail.com) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iSeUz-0002sH-U9; Thu, 07 Nov 2019 09:54:43 +0000 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay08.hostedemail.com (Postfix) with ESMTP id F0F76182CED34; Thu, 7 Nov 2019 09:54:36 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: ring31_45311ab5a8d41 X-Filterd-Recvd-Size: 1775 Received: from XPS-9350.home (unknown [47.151.135.224]) (Authenticated sender: joe@perches.com) by omf20.hostedemail.com (Postfix) with ESMTPA; Thu, 7 Nov 2019 09:54:35 +0000 (UTC) Message-ID: <4c74db2614cefe23f888d0643c2d7c356086745a.camel@perches.com> Subject: Re: [PATCH] drm/rockchip: use DRM_DEV_ERROR for log output From: Joe Perches To: Wambui Karuga , hjc@rock-chips.com, heiko@sntech.de, airlied@linux.ie, daniel@ffwll.ch, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Date: Thu, 07 Nov 2019 01:54:22 -0800 In-Reply-To: <20191107092945.15513-1-wambui.karugax@gmail.com> References: <20191107092945.15513-1-wambui.karugax@gmail.com> User-Agent: Evolution 3.34.1-2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191107_015442_038894_FCDED43C X-CRM114-Status: UNSURE ( 8.07 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 2019-11-07 at 12:29 +0300, Wambui Karuga wrote: > Replace the use of the dev_err macro with the DRM_DEV_ERROR > DRM helper macro. The commit message should show the reason _why_ you are doing this instead of just stating that you are doing this. It's not that dev_err is uncommon in drivers/gpu/drm. $ git grep -w dev_err drivers/gpu/drm | wc -l 1950 $ git grep -w DRM_DEV_ERROR drivers/gpu/drm | wc -l 756 > diff --git a/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c b/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c [] > @@ -916,7 +916,7 @@ static int dw_mipi_dsi_rockchip_probe(struct platform_device *pdev) > } > > if (!dsi->cdata) { > - dev_err(dev, "no dsi-config for %s node\n", np->name); > + DRM_DEV_ERROR(dev, "no dsi-config for %s node\n", np->name); > return -EINVAL; > } _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel