From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Robin Murphy <robin.murphy@arm.com>, will@kernel.org
Cc: mark.rutland@arm.com, linux-arm-kernel@lists.infradead.org,
devicetree@vger.kernel.org, suzuki.poulose@arm.com,
ilkka@os.amperecomputing.com, bwicaksono@nvidia.com,
YWan@nvidia.com, rwiley@nvidia.com,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>
Subject: Re: [PATCH v2 4/5] dt-bindings/perf: Add Arm CoreSight PMU
Date: Mon, 18 Dec 2023 08:03:52 +0100 [thread overview]
Message-ID: <4c78e6f2-d6fb-4da7-9c54-ca6a686f2b58@linaro.org> (raw)
In-Reply-To: <2b8414e5-61d5-4c3e-9613-6d9487ae84a8@arm.com>
On 15/12/2023 19:39, Robin Murphy wrote:
>>> +required:
>>> + - compatible
>>> + - reg
>>> +
>>> +additionalProperties: false
>>
>> Why no example to validate the binding?
>
> IMO for such a trivial binding built out of common properties, an
> equally trivial example isn't going to add any value, since it won't do
> anything more than re-state the individual property definitions above.
> In bindings where we have conditional relationships between properties,
> or complex encodings where a practical example can help explain a
> definition (e.g. a map/mask pair for a set of input values), then
> absolutely, an example can add something more to help the author and/or
> users. But otherwise, the thing I've really grown to like about schema
> is how thoroughly self-describing the definitions themselves can now be.
The example is used to validate the schema.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-12-18 7:04 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-14 16:31 [PATCH v2 0/5] perf/arm_cspmu: Add devicetree support Robin Murphy
2023-12-14 16:31 ` [PATCH v2 1/5] perf/arm_cspmu: Simplify initialisation Robin Murphy
2023-12-14 16:31 ` [PATCH v2 2/5] perf/arm_cspmu: Simplify attribute groups Robin Murphy
2023-12-14 16:31 ` [PATCH v2 3/5] perf/arm_cspmu: Simplify counter reset Robin Murphy
2023-12-14 16:31 ` [PATCH v2 4/5] dt-bindings/perf: Add Arm CoreSight PMU Robin Murphy
2023-12-14 17:55 ` Rob Herring
2023-12-14 22:22 ` Rob Herring
2023-12-15 9:44 ` Krzysztof Kozlowski
2023-12-15 18:39 ` Robin Murphy
2023-12-18 7:03 ` Krzysztof Kozlowski [this message]
2023-12-19 14:24 ` Robin Murphy
2023-12-20 7:30 ` Krzysztof Kozlowski
2023-12-20 19:23 ` Robin Murphy
2023-12-14 16:31 ` [PATCH v2 5/5] perf/arm_cspmu: Add devicetree support Robin Murphy
2023-12-14 21:22 ` Ilkka Koskinen
2024-01-20 8:10 ` Besar Wicaksono
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4c78e6f2-d6fb-4da7-9c54-ca6a686f2b58@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=YWan@nvidia.com \
--cc=bwicaksono@nvidia.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=ilkka@os.amperecomputing.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
--cc=rwiley@nvidia.com \
--cc=suzuki.poulose@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).