From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1F9C0D2E038 for ; Fri, 5 Dec 2025 08:23:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=5+etH6MxrEQ1H+k0BHm5WX2iFlT5Ox+684szY15+6p8=; b=18PMm1GI6USoB9qUh8YcieGC4H 2FSH6XtP3mIlfoQYPiSatUvUFEqTzqmUd8jNt+uBeUDmgDwqFONCk+/22EC7prtGSPh4bABw1u02D CTCHhLtpyhntVGqgBToIEHJ4CETAxMLapxZexQqwbzZZVlQK+hYsa3pmRezkxrxncPvn0fhReK+DX 74IgpDFNSK02lXLH6syJlVHb1sD1lbtQS3mP9B7DX957R+a+UdjPH7lbi9KQqwI9jbkgoRxdhZmje diWMolFlusv4M0xa0mqC1HgodhBXEEcy21qc/qNQ80jhPsMPIyWGN26vHgT6/HL55lkfTOQQwJuK0 H9DFhqgA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vRR6D-00000009DpI-3FMn; Fri, 05 Dec 2025 08:23:33 +0000 Received: from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vRR6B-00000009Dom-2Vr8 for linux-arm-kernel@lists.infradead.org; Fri, 05 Dec 2025 08:23:31 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id ABB936000A; Fri, 5 Dec 2025 08:23:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 248D6C4CEF1; Fri, 5 Dec 2025 08:23:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1764923010; bh=2RuxdcJ34ThoIzXMtGNMOSyw5lKrWrJDIcySDhaERK8=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=t/QsIlBhlyDcClYsjuIwHlMAT2Nx5yKzUiSBeSs6hsBj9mFDbDsWIt0+L+4Ql/XMV 0h6eEWiN2tPgZB+e5hH68LwU6U00wQEOvQk4/Y20fW1UW/OK0jVX2Mfhx6223ohxCN R2fxCiSpStTuXlp9VfQSfresNW/GGzvIfLzpYvSltztfhI07IB08k7wJw6omyCXEHP fO9IaDCWVmBDI31MNvzb+l0YYeNhzpOF2cF8UY1UZ28f/+PP5v7bB9QoBYu7hK76LB QV0XaYY2o6rSEYd3W1BHPgQu6gzFIvZ+TA31RevoLMvIGbQ1jlpM6OYjbLf/ao40hO aiwgsbCvXypGA== Message-ID: <4ce9756d-fd5a-4678-811d-be19eea1f626@kernel.org> Date: Fri, 5 Dec 2025 09:23:25 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] arm64: dts: freescale: add NXP FRDM-IMX91S board support To: "Yanan.Yang" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, qijian.guo@nxp.com, justin.jiang@nxp.com, Lei Xu , Xiaofeng Wei References: <20251205-imx91s-frdm-v1-0-afd6cd01c299@nxp.com> <20251205-imx91s-frdm-v1-2-afd6cd01c299@nxp.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: <20251205-imx91s-frdm-v1-2-afd6cd01c299@nxp.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 05/12/2025 09:03, Yanan.Yang wrote: > Add DeviceTree support for the NXP FRDM-IMX91S development board based > on the i.MX91 SoC. FRDM-IMX91S is a cost-optimized variant of FRDM-IMX91 > and differs in memory, storage, Ethernet, and PMIC configuration: > > - 512MB LPDDR4 (FRDM-IMX91 uses 1GB) > - 256MB FlexSPI-NAND (FRDM-IMX91 uses 8GB eMMC) > - Single GbE port (FRDM-IMX91 has dual GbE) > - PMIC PF9453 (FRDM-IMX91 uses PCA9451A) > > This DT enables: > - ADC1 > - UART1 and UART5 > - I2C bus and children nodes > - USB and related nodes > - uSDHC1 and uSDHC2 > - FlexSPI NAND flash > - Watchdog3 > - Ethernet (eqos) > - FlexCAN > - MQS > > Link: https://www.nxp.com/design/design-center/development-boards-and-designs/FRDM-IMX91S > (FRDM-IMX91S board page) > Link: https://www.nxp.com/design/design-center/development-boards-and-designs/FRDM-IMX91 > (FRDM-IMX91 board page) > > Co-developed-by: Lei Xu > Signed-off-by: Lei Xu > Co-developed-by: Xiaofeng Wei > Signed-off-by: Xiaofeng Wei > Signed-off-by: Yanan.Yang > --- > arch/arm64/boot/dts/freescale/Makefile | 1 + > .../boot/dts/freescale/imx91-11x11-frdm-s.dts | 692 +++++++++++++++++++++ > 2 files changed, 693 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile > index f30d3fd724d0..927bf76a05f3 100644 > --- a/arch/arm64/boot/dts/freescale/Makefile > +++ b/arch/arm64/boot/dts/freescale/Makefile > @@ -368,6 +368,7 @@ dtb-$(CONFIG_ARCH_MXC) += imx8qxp-tqma8xqps-mb-smarc-2.dtb > dtb-$(CONFIG_ARCH_MXC) += imx8ulp-9x9-evk.dtb > dtb-$(CONFIG_ARCH_MXC) += imx8ulp-evk.dtb > dtb-$(CONFIG_ARCH_MXC) += imx91-11x11-evk.dtb > +dtb-$(CONFIG_ARCH_MXC) += imx91-11x11-frdm-s.dtb > dtb-$(CONFIG_ARCH_MXC) += imx91-phyboard-segin.dtb > dtb-$(CONFIG_ARCH_MXC) += imx91-tqma9131-mba91xxca.dtb > dtb-$(CONFIG_ARCH_MXC) += imx93-9x9-qsb.dtb > diff --git a/arch/arm64/boot/dts/freescale/imx91-11x11-frdm-s.dts b/arch/arm64/boot/dts/freescale/imx91-11x11-frdm-s.dts > new file mode 100644 > index 000000000000..0952a685c3f5 > --- /dev/null > +++ b/arch/arm64/boot/dts/freescale/imx91-11x11-frdm-s.dts > @@ -0,0 +1,692 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * Copyright 2025 NXP > + */ > + > +/dts-v1/; > + > +#include > +#include "imx91.dtsi" > + > +/ { > + compatible = "fsl,imx91-11x11-frdm-s", "fsl,imx91"; > + model = "NXP FRDM-IMX91S board"; > + > + aliases { > + ethernet0 = &fec; > + ethernet1 = &eqos; > + gpio0 = &gpio1; > + gpio1 = &gpio2; > + gpio2 = &gpio3; > + gpio3 = &gpio4; > + i2c0 = &lpi2c1; > + i2c1 = &lpi2c2; > + i2c2 = &lpi2c3; > + i2c3 = &lpi2c4; > + i2c4 = &lpi2c5; > + i2c5 = &lpi2c6; > + i2c6 = &lpi2c7; > + i2c7 = &lpi2c8; > + mmc0 = &usdhc1; > + mmc1 = &usdhc2; > + mmc2 = &usdhc3; > + rtc0 = &bbnsm_rtc; > + serial0 = &lpuart1; > + serial1 = &lpuart2; > + serial2 = &lpuart3; > + serial3 = &lpuart4; > + serial4 = &lpuart5; > + serial5 = &lpuart6; > + serial6 = &lpuart7; > + serial7 = &lpuart8; > + }; > + > + chosen { > + stdout-path = &lpuart1; > + }; > + > + gpio-keys { > + compatible = "gpio-keys"; > + pinctrl-0 = <&pinctrl_gpio_key>; > + pinctrl-names = "default"; > + > + button { > + interrupt-parent = <&gpio3>; > + interrupts = <26 IRQ_TYPE_EDGE_FALLING>; > + gpios = <&gpio3 26 GPIO_PULL_UP>; > + label = "User Button"; > + linux,code = ; > + }; > + }; > + > + gpio-leds { > + compatible = "gpio-leds"; > + > + status { It does not look like you tested the DTS against bindings. Please run `make dtbs_check W=1` (see Documentation/devicetree/bindings/writing-schema.rst or https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/ for instructions). Maybe you need to update your dtschema and yamllint. Don't rely on distro packages for dtschema and be sure you are using the latest released dtschema. > + default-state = "on"; > + gpios = <&pcal6524 7 GPIO_ACTIVE_LOW>; > + label = "green:status"; > + }; > + }; > + > + reg_vref_1v8: regulator-adc-vref { > + compatible = "regulator-fixed"; > + regulator-max-microvolt = <1800000>; > + regulator-min-microvolt = <1800000>; > + regulator-name = "vref_1v8"; > + }; > + > + reg_can_stby: regulator-can-stby { > + compatible = "regulator-fixed"; > + regulator-max-microvolt = <3300000>; > + regulator-min-microvolt = <3300000>; > + regulator-name = "can-stby"; > + gpio = <&gpio1 10 GPIO_ACTIVE_LOW>; > + }; > + > + reg_usdhc1_vmmc: regulator-usdhc1 { > + compatible = "regulator-fixed"; > + regulator-max-microvolt = <3300000>; > + regulator-min-microvolt = <3300000>; > + regulator-name = "WLAN_EN"; > + startup-delay-us = <20000>; > + gpio = <&pcal6524 3 GPIO_ACTIVE_HIGH>; > + enable-active-high; > + }; > + > + reg_usdhc2_vmmc: regulator-usdhc2 { > + compatible = "regulator-fixed"; > + off-on-delay-us = <12000>; > + pinctrl-0 = <&pinctrl_reg_usdhc2_vmmc>; > + pinctrl-names = "default"; > + regulator-max-microvolt = <3300000>; > + regulator-min-microvolt = <3300000>; > + regulator-name = "VSD_3V3"; > + gpio = <&gpio3 7 GPIO_ACTIVE_HIGH>; > + enable-active-high; > + }; > + > + reg_usb_vbus: regulator-vbus { > + compatible = "regulator-fixed"; > + regulator-max-microvolt = <5000000>; > + regulator-min-microvolt = <5000000>; > + regulator-name = "USB_VBUS"; > + gpio = <&pcal6524 15 GPIO_ACTIVE_HIGH>; > + enable-active-high; > + }; > + > + reserved-memory { > + ranges; > + #address-cells = <2>; > + #size-cells = <2>; > + > + linux,cma { > + compatible = "shared-dma-pool"; > + alloc-ranges = <0 0x80000000 0 0x20000000>; > + reusable; > + size = <0 0x2000000>; > + linux,cma-default; > + }; > + }; > + > + sound-mqs { > + compatible = "fsl,imx6sx-sdb-mqs", "fsl,imx-audio-mqs"; > + audio-codec = <&mqs1>; > + audio-cpu = <&sai1>; > + model = "mqs-audio"; > + }; > + > + usdhc1_pwrseq: usdhc1_pwrseq { No, NAK. Don't send us downstream code ever. I am not reviewing the rest. Please start working with mainline code, not downstream. Take MAINLINE DTS as your starting point, not downstream. Best regards, Krzysztof