From: Ben Dooks <ben.dooks@codethink.co.uk>
To: Russell King - ARM Linux admin <linux@armlinux.org.uk>
Cc: linux-kernel@lists.codethink.co.uk, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] do not export show_fiq_list
Date: Fri, 18 Oct 2019 12:20:05 +0100 [thread overview]
Message-ID: <4cf40a46-e3b0-978e-5ff9-15e5410ac6a0@codethink.co.uk> (raw)
In-Reply-To: <20191018111757.GH25745@shell.armlinux.org.uk>
On 18/10/2019 12:17, Russell King - ARM Linux admin wrote:
> On Fri, Oct 18, 2019 at 11:35:13AM +0100, Ben Dooks (Codethink) wrote:
>> The show_fiq_list() is not used outside the file it is
>> defined in, so make it static and remove the header
>> file declaration (which it did not include) to remove
>> the following sparse warning:
>>
>> arch/arm/kernel/fiq.c:85:5: warning: symbol 'show_fiq_list' was not declared. Should it be static?
>
> NAK. This is called from arch/arm/kernel/irq.c; making it static will
> create a link failure.
>
> Please don't take sparse "suggestions" as the correct solution, always
> research the warning thoroughly before coming up with a solution. In
> this case:
>
> $ grep -r show_fiq_list arch/arm
>
> would have shown why this change is wrong.
yes, failed to see irq.c was != to fiq.c
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius
https://www.codethink.co.uk/privacy.html
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-10-18 11:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-18 10:35 [PATCH] do not export show_fiq_list Ben Dooks (Codethink)
2019-10-18 10:44 ` Ben Dooks
2019-10-18 11:17 ` Russell King - ARM Linux admin
2019-10-18 11:20 ` Ben Dooks [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4cf40a46-e3b0-978e-5ff9-15e5410ac6a0@codethink.co.uk \
--to=ben.dooks@codethink.co.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@lists.codethink.co.uk \
--cc=linux@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).