From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 826ADC433EF for ; Mon, 8 Nov 2021 06:39:06 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 429A76128B for ; Mon, 8 Nov 2021 06:39:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 429A76128B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=wanadoo.fr Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=7v1yTc1UfJ58yagLiJEtoi8/8A6kop8ao5NCGOwyZrE=; b=v1CY3jFSk67jsZ1+fVK/h2bM+o cJfdMllTz1ye2zhXOp80miyJTRbXfkOyxvE2z7IEA9tQuNAK5E05S/pfihqqm+gK9jra7e43tE4Df qVZnSyGwdBB8y0h0BLl/VipmQ3gH4Y4sw/vWpSKov7dlHfV2kDTLqLq0spbVTCozXMydBxWijAm8C uo8Mbh1HB/4OZxHdcQ8E81ERWvFlziaz+XTAYWJJixjA3w/KrDsxOECPnYKQm1Ar8/tt5zOhsjWgx xbNSZn9lwkrPaFK3X2dDSMEI/BPhlqSUctFmAuv2hI3JBQlMJwV2/8CM+sEdrV9Cn0kaiEpgtjeWY UiMXaeug==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mjyHo-00FVOR-2C; Mon, 08 Nov 2021 06:37:44 +0000 Received: from smtp05.smtpout.orange.fr ([80.12.242.127] helo=smtp.smtpout.orange.fr) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mjyHj-00FVNE-P5 for linux-arm-kernel@lists.infradead.org; Mon, 08 Nov 2021 06:37:41 +0000 Received: from [192.168.1.18] ([86.243.171.122]) by smtp.orange.fr with ESMTPA id jyHZmF8HponYgjyHZmBySq; Mon, 08 Nov 2021 07:37:32 +0100 X-ME-Helo: [192.168.1.18] X-ME-Auth: YWZlNiIxYWMyZDliZWIzOTcwYTEyYzlhMmU3ZiQ1M2U2MzfzZDfyZTMxZTBkMTYyNDBjNDJlZmQ3ZQ== X-ME-Date: Mon, 08 Nov 2021 07:37:32 +0100 X-ME-IP: 86.243.171.122 Subject: Re: [PATCH] PCI: xilinx-nwl: Simplify code and fix a memory leak To: =?UTF-8?Q?Krzysztof_Wilczy=c5=84ski?= Cc: lorenzo.pieralisi@arm.com, robh@kernel.org, bhelgaas@google.com, michal.simek@xilinx.com, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org References: <5483f10a44b06aad55728576d489adfa16c3be91.1636279388.git.christophe.jaillet@wanadoo.fr> From: Christophe JAILLET Message-ID: <4d0576fb-0232-b165-bdef-e8a4310c6d29@wanadoo.fr> Date: Mon, 8 Nov 2021 07:37:29 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211107_223740_004289_BD56104D X-CRM114-Status: GOOD ( 19.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org TGUgMDgvMTEvMjAyMSDDoCAwMTozMSwgS3J6eXN6dG9mIFdpbGN6ecWEc2tpIGEgw6ljcml0wqA6 Cj4gSGkgQ2hyaXN0b3BoZSwKPiAKPj4gQWxsb2NhdGUgc3BhY2UgZm9yICdiaXRtYXAnIGluICdz dHJ1Y3QgbndsX21zaScgYXQgYnVpbGQgdGltZSBpbnN0ZWFkIG9mCj4+IGR5bmFtaWNhbGx5IGFs bG9jYXRpbmcgdGhlIG1lbW9yeSBhdCBydW50aW1lLgo+Pgo+PiBUaGlzIHNpbXBsaWZpZXMgY29k ZSAoZXNwZWNpYWxseSBlcnJvciBoYW5kbGluZyBwYXRocykgYW5kIGF2b2lkIHNvbWUKPj4gb3Bl bi1jb2RlZCBhcml0aG1ldGljIGluIGFsbG9jYXRvciBhcmd1bWVudHMKPj4KPj4gVGhpcyBhbHNv IGZpeGVzIGEgcG90ZW50aWFsIG1lbW9yeSBsZWFrLiBUaGUgYml0bWFwIHdhcyBuZXZlciBmcmVl ZC4gSXQgaXMKPj4gbm93IHBhcnQgb2YgYSBtYW5hZ2VkIHJlc291cmNlLgo+IAo+IEp1c3QgdG8g Y29uZmlybSAtIHlvdSBtZWFuIHBvdGVudGlhbGx5IGxlYWtpbmcgd2hlbiB0aGUgZHJpdmVyIHdv dWxkIGJlCj4gdW5sb2FkZWQ/ICBOb3QgdGhlIGVycm9yIGhhbmRsaW5nIHBhdGgsIGNvcnJlY3Q/ CgpDb3JyZWN0LCB0aGUgbGVhayB3b3VsZCBoYXBwZW4gb24gZHJpdmVyIHVubG9hZCBvbmx5LgoK Q0oKCj4gCj4+IC0tLSBhL2RyaXZlcnMvcGNpL2NvbnRyb2xsZXIvcGNpZS14aWxpbngtbndsLmMK Pj4gKysrIGIvZHJpdmVycy9wY2kvY29udHJvbGxlci9wY2llLXhpbGlueC1ud2wuYwo+PiBAQCAt MTQ2LDcgKzE0Niw3IEBACj4+ICAgCj4+ICAgc3RydWN0IG53bF9tc2kgewkJCS8qIE1TSSBpbmZv cm1hdGlvbiAqLwo+PiAgIAlzdHJ1Y3QgaXJxX2RvbWFpbiAqbXNpX2RvbWFpbjsKPj4gLQl1bnNp Z25lZCBsb25nICpiaXRtYXA7Cj4+ICsJREVDTEFSRV9CSVRNQVAoYml0bWFwLCBJTlRfUENJX01T SV9OUik7Cj4+ICAgCXN0cnVjdCBpcnFfZG9tYWluICpkZXZfZG9tYWluOwo+PiAgIAlzdHJ1Y3Qg bXV0ZXggbG9jazsJCS8qIHByb3RlY3QgYml0bWFwIHZhcmlhYmxlICovCj4+ICAgCWludCBpcnFf bXNpMDsKPj4gQEAgLTMzNSwxMiArMzM1LDEwIEBAIHN0YXRpYyB2b2lkIG53bF9wY2llX2xlZ19o YW5kbGVyKHN0cnVjdCBpcnFfZGVzYyAqZGVzYykKPj4gICAKPj4gICBzdGF0aWMgdm9pZCBud2xf cGNpZV9oYW5kbGVfbXNpX2lycShzdHJ1Y3QgbndsX3BjaWUgKnBjaWUsIHUzMiBzdGF0dXNfcmVn KQo+PiAgIHsKPj4gLQlzdHJ1Y3QgbndsX21zaSAqbXNpOwo+PiArCXN0cnVjdCBud2xfbXNpICpt c2kgPSAmcGNpZS0+bXNpOwo+PiAgIAl1bnNpZ25lZCBsb25nIHN0YXR1czsKPj4gICAJdTMyIGJp dDsKPj4gICAKPj4gLQltc2kgPSAmcGNpZS0+bXNpOwo+PiAtCj4+ICAgCXdoaWxlICgoc3RhdHVz ID0gbndsX2JyaWRnZV9yZWFkbChwY2llLCBzdGF0dXNfcmVnKSkgIT0gMCkgewo+PiAgIAkJZm9y X2VhY2hfc2V0X2JpdChiaXQsICZzdGF0dXMsIDMyKSB7Cj4+ICAgCQkJbndsX2JyaWRnZV93cml0 ZWwocGNpZSwgMSA8PCBiaXQsIHN0YXR1c19yZWcpOwo+PiBAQCAtNTYwLDMwICs1NTgsMjEgQEAg c3RhdGljIGludCBud2xfcGNpZV9lbmFibGVfbXNpKHN0cnVjdCBud2xfcGNpZSAqcGNpZSkKPj4g ICAJc3RydWN0IG53bF9tc2kgKm1zaSA9ICZwY2llLT5tc2k7Cj4+ICAgCXVuc2lnbmVkIGxvbmcg YmFzZTsKPj4gICAJaW50IHJldDsKPj4gLQlpbnQgc2l6ZSA9IEJJVFNfVE9fTE9OR1MoSU5UX1BD SV9NU0lfTlIpICogc2l6ZW9mKGxvbmcpOwo+PiAgIAo+PiAgIAltdXRleF9pbml0KCZtc2ktPmxv Y2spOwo+PiAgIAo+PiAtCW1zaS0+Yml0bWFwID0ga3phbGxvYyhzaXplLCBHRlBfS0VSTkVMKTsK Pj4gLQlpZiAoIW1zaS0+Yml0bWFwKQo+PiAtCQlyZXR1cm4gLUVOT01FTTsKPj4gLQo+PiAgIAkv KiBHZXQgbXNpXzEgSVJRIG51bWJlciAqLwo+PiAgIAltc2ktPmlycV9tc2kxID0gcGxhdGZvcm1f Z2V0X2lycV9ieW5hbWUocGRldiwgIm1zaTEiKTsKPj4gLQlpZiAobXNpLT5pcnFfbXNpMSA8IDAp IHsKPj4gLQkJcmV0ID0gLUVJTlZBTDsKPj4gLQkJZ290byBlcnI7Cj4+IC0JfQo+PiArCWlmICht c2ktPmlycV9tc2kxIDwgMCkKPj4gKwkJcmV0dXJuIC1FSU5WQUw7Cj4+ICAgCj4+ICAgCWlycV9z ZXRfY2hhaW5lZF9oYW5kbGVyX2FuZF9kYXRhKG1zaS0+aXJxX21zaTEsCj4+ICAgCQkJCQkgbnds X3BjaWVfbXNpX2hhbmRsZXJfaGlnaCwgcGNpZSk7Cj4+ICAgCj4+ICAgCS8qIEdldCBtc2lfMCBJ UlEgbnVtYmVyICovCj4+ICAgCW1zaS0+aXJxX21zaTAgPSBwbGF0Zm9ybV9nZXRfaXJxX2J5bmFt ZShwZGV2LCAibXNpMCIpOwo+PiAtCWlmIChtc2ktPmlycV9tc2kwIDwgMCkgewo+PiAtCQlyZXQg PSAtRUlOVkFMOwo+PiAtCQlnb3RvIGVycjsKPj4gLQl9Cj4+ICsJaWYgKG1zaS0+aXJxX21zaTAg PCAwKQo+PiArCQlyZXR1cm4gLUVJTlZBTDsKPj4gICAKPj4gICAJaXJxX3NldF9jaGFpbmVkX2hh bmRsZXJfYW5kX2RhdGEobXNpLT5pcnFfbXNpMCwKPj4gICAJCQkJCSBud2xfcGNpZV9tc2lfaGFu ZGxlcl9sb3csIHBjaWUpOwo+PiBAQCAtNTkyLDggKzU4MSw3IEBAIHN0YXRpYyBpbnQgbndsX3Bj aWVfZW5hYmxlX21zaShzdHJ1Y3QgbndsX3BjaWUgKnBjaWUpCj4+ICAgCXJldCA9IG53bF9icmlk Z2VfcmVhZGwocGNpZSwgSV9NU0lJX0NBUEFCSUxJVElFUykgJiBNU0lJX1BSRVNFTlQ7Cj4+ICAg CWlmICghcmV0KSB7Cj4+ICAgCQlkZXZfZXJyKGRldiwgIk1TSSBub3QgcHJlc2VudFxuIik7Cj4+ IC0JCXJldCA9IC1FSU87Cj4+IC0JCWdvdG8gZXJyOwo+PiArCQlyZXR1cm4gLUVJTzsKPj4gICAJ fQo+PiAgIAo+PiAgIAkvKiBFbmFibGUgTVNJSSAqLwo+PiBAQCAtNjMyLDEwICs2MjAsNiBAQCBz dGF0aWMgaW50IG53bF9wY2llX2VuYWJsZV9tc2koc3RydWN0IG53bF9wY2llICpwY2llKQo+PiAg IAlud2xfYnJpZGdlX3dyaXRlbChwY2llLCBNU0dGX01TSV9TUl9MT19NQVNLLCBNU0dGX01TSV9N QVNLX0xPKTsKPj4gICAKPj4gICAJcmV0dXJuIDA7Cj4+IC1lcnI6Cj4+IC0Ja2ZyZWUobXNpLT5i aXRtYXApOwo+PiAtCW1zaS0+Yml0bWFwID0gTlVMTDsKPj4gLQlyZXR1cm4gcmV0Owo+IAo+IFRo YW5rIHlvdSEKPiAKPiBSZXZpZXdlZC1ieTogS3J6eXN6dG9mIFdpbGN6ecWEc2tpIDxrd0BsaW51 eC5jb20+Cj4gCj4gCUtyenlzenRvZgo+IAoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFy bS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK