From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11841C4338F for ; Fri, 23 Jul 2021 04:33:51 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C0A7460E8E for ; Fri, 23 Jul 2021 04:33:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C0A7460E8E Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=microchip.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:CC:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wj7gguHluKS8HYeo8ES50OBx0kX/0KHUrBq92nHUuvE=; b=4ZM4FOg4hXHOtF /JNDqI+OLp3QndnPB77OYTEFizk4Sq4UF1KF54p5kWxMkvEh8gYtN4smKAT5s7xptTcxp5tB4y+MN KtrBKZYeT8o2cbHQICq4gBkkKg6FfM90UMzBORUVSyBLyXPf6+YVjMXXP6RKeWMbtukTmfeZ/QSh9 3It93QDTDZ71hQT3/jCHpjFx/gfCR/oL4xN4nUtC5j5/+ER9bXyBU1hc7YEDk9shvazWseMJPW/qy +a38OLva6Geg02OMygiZyowHoBw56vSJat3RGE6nM8UkZtW/0/pU/tXkLU4rodvveSS3uVcn9+Xo2 WwVCigcAFoU047OvFzzA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m6mr1-003OMv-KX; Fri, 23 Jul 2021 04:32:08 +0000 Received: from esa.microchip.iphmx.com ([68.232.153.233]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m6mqv-003OMA-SW for linux-arm-kernel@lists.infradead.org; Fri, 23 Jul 2021 04:32:04 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1627014721; x=1658550721; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=pns/gHSR9DUQmNHnEPDfq90OSQvj/a1tN3VbCi+EUa0=; b=GmFNribpJYO5If9WFH0cK54AUQvSYDsoOA4wEr7m3B43gIxgWgZ4PJtf 1ztPTPa5Mq86sPDDxFA3C1u6gHe5d72RU0Hrpw/OR6HCLKGCUaWdkO9CP XQDC+L0TrC0S4GtqiG3Hznqf1NV0ftm5l6ZxAZeMQ3o0ipw0H+fXsmvIm o54gWu4N8AVNIK1636UPm2ryToe6JJqQXGEJGH+ihjzLiIxQ1QWyse1xd IXKJXy8RPVR7tjogHV8cwK+zmbeV6WveiOgLqzUSB2TR4Vmmw0QUkaVAI R/0EJwt7w4F0cwWBulZvedbTgf1D1nTSAp96cJA5k3X6bTXDVMMA7U6tC A==; IronPort-SDR: dhrC9uuKqN7cal+EESYLLexlDr361NQ6cxwqFDHLXtzQ2l4VL574bh+OOWIMGnrraKYSnsAni9 tX9h0O6M4u64xFjOSajqZh8Vgft0+6HkV/v28Cruv2u5hQeIQJgWk4x8fIGP8DsMg+mW2Uiwv9 j7XOAvLkr5PYMq77uQDzqjS1alA8fXwsh2WmqyTugzLf7mFR+jYD9q7B2uFuwVofDiXYokyhxb MDmri2nmVmb1cUdAHoreIftPs7m+Ppr8GYTHh6vaNHO2ENr21EMl8kZiaQ9iFqocV8XVDxsBUm /rd4XX7M/5MMW7QumD0q4K8b X-IronPort-AV: E=Sophos;i="5.84,263,1620716400"; d="scan'208";a="137205781" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa1.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 22 Jul 2021 21:32:00 -0700 Received: from chn-vm-ex03.mchp-main.com (10.10.85.151) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Thu, 22 Jul 2021 21:32:00 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (10.10.215.89) by email.microchip.com (10.10.87.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2 via Frontend Transport; Thu, 22 Jul 2021 21:32:00 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oPCD+7yHEY9Ym2yyXmCObzVXU2FYK3TiaE3TZwbyj1cBcicMupUeLRpSPravWcGcouzk51ph1Q5th8EUYjKBTGroeOH1NUYnuiXf/hZHP5vlDQ4gxIUnUTmqWDI+f0s/l1xfHuyCaKQm5sjcjSFn4gZBk+otAloB4tPfVTQBQ1TpvtzmaqQ12DC+m08zfA0sJOvLZjjBrnWkAx+JVfgIg5WiaJFpPGythl4U4QBGAQvFtOuvM5Y3xqo8PIwpCE+RVsxQQYploJhN/5kujXIdmLR2H2DdWjihd8izgk2IpHbIcEywkB+hg/gLUCsiejCRKhENxYL/QQfYopYVneSItw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pns/gHSR9DUQmNHnEPDfq90OSQvj/a1tN3VbCi+EUa0=; b=AFEy9B8DxxKXlICjypNIwZTVc78wCAb6Jjhm7MHAdHNMed5xcKtq7az/GiYkYKdviZ5H8f9oal1D84iMKVs/77z2kYivfjWxF6U8Za/FNS06jd9rRxnTP1VG/qGPAfx0OhYITX/3sHwsM/YEBOyodifv1sTZfi4CTS8Z+g+khytp4rr+Gc1baVKlhPlmqSB8kxvHvB0A23WKVgq+0GhaKvvdqyp2VkvztzU/1ClQ5BVrE4a2iuWS0g7dmjQtazcEBmruKF2e3e4E0UOS91QJJfqeC0mjOIQbVWcbhf5xWfF+YIGDDphaSoAvHXFuNXkD5ltPcMFqui4+VqnXkytbEw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microchip.com; dmarc=pass action=none header.from=microchip.com; dkim=pass header.d=microchip.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microchiptechnology.onmicrosoft.com; s=selector2-microchiptechnology-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pns/gHSR9DUQmNHnEPDfq90OSQvj/a1tN3VbCi+EUa0=; b=e2053QgtzKSmk5HPenKJ1Tq5sqlOC0bn1PtVnBe9JbY2J4a6iAMseDmqKOTVmkvZUsYx4pYI27fn0Rt9liDAif/DkWrFFhSXmHYlHH2beYOvm7tNS0GczXanZYokjr/BmCXcZAnuzCk8mgwjm1Nwxyt6gziXu7eDXNk84thJ/ck= Received: from CO1PR11MB4865.namprd11.prod.outlook.com (2603:10b6:303:9c::9) by MWHPR11MB2015.namprd11.prod.outlook.com (2603:10b6:300:28::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4352.25; Fri, 23 Jul 2021 04:31:59 +0000 Received: from CO1PR11MB4865.namprd11.prod.outlook.com ([fe80::58e9:43d8:74e1:f266]) by CO1PR11MB4865.namprd11.prod.outlook.com ([fe80::58e9:43d8:74e1:f266%7]) with mapi id 15.20.4352.026; Fri, 23 Jul 2021 04:31:59 +0000 From: To: , , , , , , CC: , , Subject: Re: [RESEND] crypto: atmel-aes: use swap() Thread-Topic: [RESEND] crypto: atmel-aes: use swap() Thread-Index: AQHXf3usVAlERiynyEmqNOW7p1HJmg== Date: Fri, 23 Jul 2021 04:31:59 +0000 Message-ID: <4d219f5a-f22c-aa6d-a229-fe43d3ee822b@microchip.com> References: <20210722170827.GA4362@pc> In-Reply-To: <20210722170827.GA4362@pc> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 authentication-results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=microchip.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f5efdafe-6529-47f5-f36d-08d94d92cfad x-ms-traffictypediagnostic: MWHPR11MB2015: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: CmdY8AiqyYIXDSTrqumQnxgthvugsB8Asrtj6b6/wWkj1pjvq1THfMbs8R5aVzE9CTS7aW32rGlyo/JGHpILUOq4sKDK6LxbDkqNoLGaXDkGXd5mb/umnvnyA+enAsMT+R+LwYlFmRwG8pgKcQKQJNzwvC7f9Gp8iUonqUfIi2d7H8DrUc+RiZdx9SxL7+R4S7OlFv3HkAeiMIVpNdcBC94o6fk67bDsje5YVbCrKsqzbtGLj9lHYykE5ZCoabt/EGWfxlPQcy4iMX21icQwjMWp0SlyKqUx0QquNO0iR7h0cttAsf0CNREcVxVzB6BA/3WmXtffTbWcbKl+38Dnu2zcmzP+gOzJBLZ57RDzL9h7+/TCAw9jwJJaKY4cQwhv2SuWEt07SVEbfn0KdkIHOUOG8EUXnkxMfC9juAn9tAchfr9igxruQLvXeb3nxZtbKTQfauZNiYb4mDV4jbfIxFNjrFl03p+QkkJgQnEoyuZEv+7LghKf5uw0r/hj+b3dhTMn7Tb7/UJMb+QNdN5i38hfqpJrlK/vPFvVryubJrUe6X02zSq9d2zbSuAE5pxFP9+QTvpo3B6qqAjdZN/O268gOvNUNMXtKq6crge3dHhaINjLvYkI8vfTpdYVgwy/SbDYdP40c8Q0i+uCVuVCXo4A0kh1WcYoqkCUHQGHYu9kQLnIWkjYz8RAnfoBI+LX3BQxlTJeUE9SZ1w5rFgdzjX7McTlqL6AOrRghU0QhJ+Qzh3I5JJGVWLdYhahhDx3eOgDF/FQ8TS77ERtYbtBFQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO1PR11MB4865.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(346002)(396003)(376002)(136003)(39860400002)(366004)(6486002)(122000001)(38100700002)(31696002)(4326008)(6506007)(83380400001)(71200400001)(6512007)(86362001)(53546011)(8676002)(64756008)(76116006)(478600001)(54906003)(110136005)(316002)(66476007)(66446008)(66556008)(26005)(91956017)(186003)(8936002)(31686004)(5660300002)(66946007)(2906002)(2616005)(36756003)(45980500001)(43740500002)(38070700004); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?My9iK05YaDdRaC9DbUp6TVlKcnNwd0tmNHNMNGRWdDVKazF3R2VxSmVrVFJZ?= =?utf-8?B?dFRzOWdGQ3lTZEpVMUl4OWU4QWdFNlFwRmZDczhHVmErdjJrZnRXV3Y0bHVK?= =?utf-8?B?bVpVN3YreDF4ZWpjck43Z3FSZytRTnBiNzVqZHpSYW1JcUxhK2JSdUpuUlJn?= =?utf-8?B?WWQydkdYajdvekgwekliVVBqeGpPM2RLTE5NbGlLZnFBdnhWRkhqYk9VMzA0?= =?utf-8?B?dnJPQk9NUG1RaWh0bEdaVU5UdEdidDBzZWlhd0RwOE5RSGNqc0pHWUtTcXRU?= =?utf-8?B?U2FUOCtiaVo1SUNDRFVVVHhodnJ3R21Oa3lxZEV1K01lV1I2VlVSd2NQUzNT?= =?utf-8?B?NEhCZGxaL1ViQ0poczBHQ1Y4TlJZR05LQXJMU0NwV0dxM3dwUXgzOU1UQ3RS?= =?utf-8?B?YkU3T1BCc3BGZG5seS9xWUJwbDdsdTZhc3VoUkUzZWp6MFJpMXRMV0t1cXN2?= =?utf-8?B?SW5JTE94REdxcWpEOWpVanRwV3FZRTRpdGwrODEraFpuaDZsOWxRSWRFNVF6?= =?utf-8?B?T3Q0OTVlWUhZQ1RaYm9hdWtCT3haVVY5UWJnalJRMEFTdmNVeTNRWWFhSmhq?= =?utf-8?B?OE1OQW9iN2hOK0o2NFZ5UVZTWFNRR1hnU2Zqc0ZLY3lBUFBiSld6aEkyRDZH?= =?utf-8?B?dW9QSjdOU1FLVWVGUEtBSWZrcHRPWHRIYVROdHBJQ1lYVkxvRXhKd3pMaDU2?= =?utf-8?B?RnNTRFpjdG03bEFYYVhIU296Q0JUeVU4WWZLcllMSG94cDg3S0hZa0lOL3Mv?= =?utf-8?B?MnJxazRoQW55eXdRRnB5M3NKMXo0UG9pUDFqTm1CaWljaDN1TUdaWTdoZ09K?= =?utf-8?B?MzRNTFhTcjN4Nk1Mc0RtVHVzZFVHZ2dGMU5UQldOVFo1UDBIS3phaFVIYXNz?= =?utf-8?B?UzZGTTFpSEdCRFpCYTYzVEg5UWNZNGUzUFNQdXp5WVFCRlpXc3BWMVBoNjcw?= =?utf-8?B?d2htUXZyaTlHdVVscUtrOGo5MXZEYWtKeWxPUmFUZmhTTGRDdmVMNHo5L0tz?= =?utf-8?B?TjRtazJjNno1KzJHMXNxRTQ0MUZ2eUlZNForYnVZQ3YyNW5qbmt4WlJtNDl2?= =?utf-8?B?U29rbVhmd0dzYzVPOHJRZEJ4aE9KNWZrNGRRQnB5R1Z5Ui9PVUpuWENoQ3ll?= =?utf-8?B?TElwVlBxaWdlWDRIc0o0Vzl2cXBmeE9GOFovWG1wYVNUcll5SG15NUtLVGlD?= =?utf-8?B?Z2xEV2VVNjBSM0xUdW92Yzl2V0RSYm0xa1ZOclp2bmZienNWZWFEM3RWTkVL?= =?utf-8?B?a3ZmZU5oT2ZHU0xjd241d09HVnJBcm5SYmVqVzdlTGFDaDZaNHd3VkFHUUd2?= =?utf-8?B?R1lnRFNPQ3UxV2hTWEp1TUlBWXdzc1F0a2gyVGlBMFMxOWdkUGNOZS81Zkp3?= =?utf-8?B?aGx2dnZQbTlNVkdnbjlCQUVFWk52KytzRFdFWmNWeGtaeDFaUXI4aDUzY0p4?= =?utf-8?B?UFk3QW5NNVpRMzI4R0dNcmg4NkNBYjdKaHV0M3Vla01ZS2ppT1ZaTm1UVzcx?= =?utf-8?B?aXhvcXUxLzAzVW1rSERIQ0lqOFg1dThTaE9VMkdLTUZBREVBQ1B2QVAydW1L?= =?utf-8?B?VFZOMzhGSnhYNW1FTGo1ZEMrNWtQQTVpOUNkK0ZnY2liM1pnMlV0elU5c3N2?= =?utf-8?B?RTZvN2xYdFd2dDA1eFB3REtReFZxMThicmxPWlgrTzlMNXFWcjNsU05hWElM?= =?utf-8?B?WjlRTVVFclNWckNzUFdySjV5aFo0b2ZUaHA1UW1kM3Raa3ZTVldLaFNudU4r?= =?utf-8?Q?xooruw5A4f2QkYe+nQ=3D?= Content-ID: MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4865.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f5efdafe-6529-47f5-f36d-08d94d92cfad X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jul 2021 04:31:59.3288 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ayB+GVc5NyyQBVTqllhvtV1Frfv4usH5Wo8v+XPu2XSkxEjaS88MxIgIzrnI/KVixXSsqt2WWSCl0HGXQ++hTDiq9C5gxmaQ4Q01QhwxSMs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB2015 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210722_213202_013821_3FF536D4 X-CRM114-Status: GOOD ( 20.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 7/22/21 8:08 PM, Salah Triki wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > Use swap() instead of implementing it in order to make code more clean. > > Signed-off-by: Salah Triki > --- > drivers/crypto/atmel-aes.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/drivers/crypto/atmel-aes.c b/drivers/crypto/atmel-aes.c > index b1d286004295..60041022c4f5 100644 > --- a/drivers/crypto/atmel-aes.c > +++ b/drivers/crypto/atmel-aes.c > @@ -1819,12 +1819,8 @@ static int atmel_aes_xts_process_data(struct atmel_aes_dev *dd) > * the order of the ciphered tweak bytes need to be reversed before > * writing them into the ODATARx registers. > */ > - for (i = 0; i < AES_BLOCK_SIZE/2; ++i) { > - u8 tmp = tweak_bytes[AES_BLOCK_SIZE - 1 - i]; > - > - tweak_bytes[AES_BLOCK_SIZE - 1 - i] = tweak_bytes[i]; > - tweak_bytes[i] = tmp; > - } > + for (i = 0; i < AES_BLOCK_SIZE/2; ++i) There could have been spaces around that '/', but I see it was kept as it was before. It's fine either way. > + swap(tweak_bytes[i], tweak_bytes[AES_BLOCK_SIZE - 1 - i]); > > /* Process the data. */ > atmel_aes_write_ctrl(dd, use_dma, NULL); > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel