From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E6B26C7EE29 for ; Fri, 9 Jun 2023 11:53:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=W0r6gZ8TNsxeuAsrAlC3qPGcU8GOcopCUavwn+7ahps=; b=eDrtJA4ENyiDf0 lN00RCnDIbNT3WXWmLIoBFjHpuaHasA0B0cNgXJqmFev6l7ZnDqlcgu64ZIl1oJ1K/be858+rJx2U ERm41Vv9mzR+bkOMJlzI3BRQFfN7UiUXtlS9LWwM9ghjEx0DNHbdz1bHWN1oS63z5m0pI6GZ/40Dy jBy/ekBATskknESotgt60nT+kPfOr4aktTmOP1enh209RFRvmeDx0sy2SSc/xELGViNDpY/p4qckt KNZZW282fmmc2OEqPRIZEC/SYm4HFOC9B7oRMV5FTCYE9f5CbiQVuucShKAPCNNr240ar9nevpQBt R00q3ou9kvmu7A+d4sNw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q7agT-00Cq7T-0E; Fri, 09 Jun 2023 11:53:37 +0000 Received: from mail-ed1-x536.google.com ([2a00:1450:4864:20::536]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q7agR-00Cq5q-02 for linux-arm-kernel@lists.infradead.org; Fri, 09 Jun 2023 11:53:36 +0000 Received: by mail-ed1-x536.google.com with SMTP id 4fb4d7f45d1cf-51478f6106cso2904164a12.1 for ; Fri, 09 Jun 2023 04:53:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1686311609; x=1688903609; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=hFLyNFdjW8q+t01Kpf1PQ/GPcGV/1xyWhVkZdWigx8Q=; b=P84n5OXIDE2oJV4pFMoCu86Pu6g9l83iWP+oBjcYzqOt4w0dgvH1Vx+7XepY21LFHE Xg3oJ7wnQfgo0RirnxhJx6TW90TYkyH6AGvHvivTGiMLi/B+iyhjW4f9yJW0pYBKy0os 2idCU13J4k6Uxh4gErJwjA5KPORzBc4Jjv7RUUvMlLnkemwkDj8Y5td+AMfzJxqh5+v/ oNDrWVbO1PC8d6MNDtpCVBHf4ySqkSH9pSdXYmq6go/yBkv1mcU/ET8rcmcAJy1NXUXc RiWFe9lPbg2xCS67V62jIBnQBxkIhT3dfE83y8d3MYDc84iwzxGXjVkai9P6JJNnL1k6 CNvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686311609; x=1688903609; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hFLyNFdjW8q+t01Kpf1PQ/GPcGV/1xyWhVkZdWigx8Q=; b=CuuBuGC7OB7g642mjJ1yUiEmKgl2LoUSOjHpEuExJU5NS7yQ1AZ1qZ5AA7CzPUTFUj vWTAnqkEyh72VXlUV4Ql4ogC4On2SJCC3nc0uuP4hxrNOpgcR06AdTG7Lo+Oa1ZWaWsE Zy4fZoU9FAK7FQqIemzPWjgYJR1RzvV7KzfkbwGQla4l3ADmZt8Pp986ERGsRBa+I66X hfHWGf+oXKXV9/Zk6HHvfRYDiyI9qcuzQrg2pDlOqeAteAloNIBgQUgB3yhNv6h0AxlG LmjSya2TZyE0MHino3VGqcyArY5qLMTwowQIWfBDTy3shQN3WjFDURqswYMwkp004zDz fhdw== X-Gm-Message-State: AC+VfDypNIHXwbMg8hhZx0tbbu84W3ImacrP0GYYJlrioHfBeqlmW3Xe 9LIhVxASej+5SM3vyeZ8ygS8nQ== X-Google-Smtp-Source: ACHHUZ4NZJ1Rx44rsznhdvEIYrZ5YDVyZDaKGvwoc5f2sIGzzVpBTv1xaoE4WfaUaNDrDmxPlcB9Dw== X-Received: by 2002:a17:907:980d:b0:969:e9ec:9a0 with SMTP id ji13-20020a170907980d00b00969e9ec09a0mr1603279ejc.77.1686311608931; Fri, 09 Jun 2023 04:53:28 -0700 (PDT) Received: from [192.168.1.20] ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id u3-20020a17090617c300b009788dfde0b2sm1222514eje.12.2023.06.09.04.53.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Jun 2023 04:53:28 -0700 (PDT) Message-ID: <4d27c8ea-f5bd-704d-e8fc-823799854bb5@linaro.org> Date: Fri, 9 Jun 2023 13:53:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH 2/2] tty: serial: samsung_tty: Fix a memory leak in s3c24xx_serial_getclk() when iterating clk Content-Language: en-US To: Christophe JAILLET , Alim Akhtar , Greg Kroah-Hartman , Jiri Slaby , Thomas Abraham , Kukjin Kim Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-serial@vger.kernel.org References: <93bf8f574310256fcea50e5c5a62b5c37e20bb14.1686285892.git.christophe.jaillet@wanadoo.fr> From: Krzysztof Kozlowski In-Reply-To: <93bf8f574310256fcea50e5c5a62b5c37e20bb14.1686285892.git.christophe.jaillet@wanadoo.fr> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230609_045335_051653_EBCD1A44 X-CRM114-Status: GOOD ( 13.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 09/06/2023 06:45, Christophe JAILLET wrote: > When the best clk is searched, we iterate over all possible clk. > > If we find a better match, the previous one, if any, needs to be freed. > If a better match has already been found, we still need to free the new > one, otherwise it leaks. > > Fixes: 5f5a7a5578c5 ("serial: samsung: switch to clkdev based clock lookup") > Signed-off-by: Christophe JAILLET > --- > This patch is speculative. Review with care. > Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel