From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7830DD2444F for ; Thu, 10 Oct 2024 23:47:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version: Content-Transfer-Encoding:Content-Type:References:In-Reply-To:Date:Cc:To:From :Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ToZcgnbZ8v7eof9auRtT/Slo3MhgKvn3XM1vCWslblw=; b=hLYmmeu/bYhvEyyPeOMrZec2DU pxNpUui4ineUPvYwrnrHpxdEtHIETITVZIoiRdpc0cbGmMh2vcVufhEPba7mfu0Ys/p2nStCQ2ZBg +HSDIeMxj3ooAIc6Pzi07ty8xpBok62DPyruKCwe6mUbm2NAAcFkwHRJSB7kZyGobKdxuWBKTA7Xt dit++CA6b1g7ao1NZd89TVgUmjJ0IZ9lksQXKBX4KkKhgN0FyaYrmPOM61KwuWHzT1Ud826f17wHm HTmCsmPXHGQD/l9p929RBJl4k4pUNkKVEjwV0toO3n60F9tsqsQB1bD9l971J9QWB1C0biVNXP6Sm ZhKQPkIg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1sz2rw-0000000EhFE-0xzv; Thu, 10 Oct 2024 23:46:56 +0000 Received: from pi.codeconstruct.com.au ([203.29.241.158] helo=codeconstruct.com.au) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1sz2qZ-0000000EhAY-2ipW for linux-arm-kernel@lists.infradead.org; Thu, 10 Oct 2024 23:45:33 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codeconstruct.com.au; s=2022a; t=1728603921; bh=ToZcgnbZ8v7eof9auRtT/Slo3MhgKvn3XM1vCWslblw=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=RA5RiigdYBT2fodE39/oNGDHLsvyZWKvCLJz1582UnsnOFdxjAqDBlD2vIC3TI+Y9 /2NaRgOm750UW87yok5DYxQvdFZf33b8HFY7iN3b6eTwHsswafzhsNxgvweCqycTsn HUm1PR7+yzpdZGBkwmT64/zRP/MG//rzdIlJDb5/HbQAIUG8JRUtGzjU9AHdTGSeHG JPSUrxm5Nudq3mWnYMlBaiMKwbeofFbQnvXMmv45SbfdcNtR8wX73LUjxPxCyFcY7x 6qoj11WE3H9fCGwKMZxtrwDR5G0RWcSUKDv03vqm2N2exy7TezBoYt1nxCd1QBJZWk hvWIK40rsJEWQ== Received: from [192.168.68.112] (ppp118-210-188-189.adl-adc-lon-bras34.tpg.internode.on.net [118.210.188.189]) by mail.codeconstruct.com.au (Postfix) with ESMTPSA id 5D0BC64998; Fri, 11 Oct 2024 07:45:19 +0800 (AWST) Message-ID: <4d596ac9a2215be8510369c948e0b9680ee2fce3.camel@codeconstruct.com.au> Subject: Re: [PATCH v5 1/2] dt-bindings: arm: aspeed: add IBM SBP1 board From: Andrew Jeffery To: Naresh Solanki Cc: "Rob Herring (Arm)" , devicetree@vger.kernel.org, Krzysztof Kozlowski , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Conor Dooley , Joel Stanley , Conor Dooley , linux-aspeed@lists.ozlabs.org Date: Fri, 11 Oct 2024 10:15:17 +1030 In-Reply-To: <172857036038.1533242.5775916298170949713.robh@kernel.org> References: <20241010112337.3840703-1-naresh.solanki@9elements.com> <172857036038.1533242.5775916298170949713.robh@kernel.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4-2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241010_164532_136830_E71BCE6B X-CRM114-Status: GOOD ( 17.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Naresh, On Thu, 2024-10-10 at 09:30 -0500, Rob Herring (Arm) wrote: > On Thu, 10 Oct 2024 16:53:31 +0530, Naresh Solanki wrote: > > Document the new compatibles used on IBM SBP1. > >=20 > > Signed-off-by: Naresh Solanki > > Acked-by: Conor Dooley > > --- > > Changes in V4: > > - Retain Acked-by from v2. > > - Fix alphabetic order > > --- > > Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 + > > 1 file changed, 1 insertion(+) > >=20 >=20 >=20 > My bot found new DTB warnings on the .dts files added or changed in this > series. >=20 > Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings > are fixed by another series. Ultimately, it is up to the platform > maintainer whether these warnings are acceptable or not. No need to reply > unless the platform maintainer has comments. >=20 > If you already ran DT checks and didn't see these error(s), then > make sure dt-schema is up to date: >=20 > pip3 install dtschema --upgrade >=20 >=20 > New warnings running 'make CHECK_DTBS=3Dy aspeed/aspeed-bmc-ibm-sbp1.dtb'= for 20241010112337.3840703-1-naresh.solanki@9elements.com: >=20 ... > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: mux@77: interrupts: Fal= se schema does not allow [[44, 4]] > from schema $id: http://devicetree.org/schemas/i2c/i2c-mux-pca954x.yaml# > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: pvccinfaon-pvccfa-cpu2@= 58: 'regulators' does not match any of the regexes: 'pinctrl-[0-9]+' > from schema $id: http://devicetree.org/schemas/trivial-devices.yaml# > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: mp2973-pvccin-pvccfa-cp= u2@58: 'regulators' does not match any of the regexes: 'pinctrl-[0-9]+' > from schema $id: http://devicetree.org/schemas/trivial-devices.yaml# > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: pvccinfaon-pvccfa-cpu1@= 58: 'regulators' does not match any of the regexes: 'pinctrl-[0-9]+' > from schema $id: http://devicetree.org/schemas/trivial-devices.yaml# > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: mp2973-pvccin-pvccfa-cp= u1@58: 'regulators' does not match any of the regexes: 'pinctrl-[0-9]+' > from schema $id: http://devicetree.org/schemas/trivial-devices.yaml# > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: pvccinfaon-pvccfa-cpu3@= 58: 'regulators' does not match any of the regexes: 'pinctrl-[0-9]+' > from schema $id: http://devicetree.org/schemas/trivial-devices.yaml# > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: mp2973-pvccin-pvccfa-cp= u3@58: 'regulators' does not match any of the regexes: 'pinctrl-[0-9]+' > from schema $id: http://devicetree.org/schemas/trivial-devices.yaml# > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: regulator@5f: 'regulato= rs' does not match any of the regexes: 'pinctrl-[0-9]+' > from schema $id: http://devicetree.org/schemas/trivial-devices.yaml# > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: regulator@5f: 'regulato= rs' does not match any of the regexes: 'pinctrl-[0-9]+' > from schema $id: http://devicetree.org/schemas/trivial-devices.yaml# > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: regulator@5f: 'regulato= rs' does not match any of the regexes: 'pinctrl-[0-9]+' > from schema $id: http://devicetree.org/schemas/trivial-devices.yaml# > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: regulator@5f: 'regulato= rs' does not match any of the regexes: 'pinctrl-[0-9]+' > from schema $id: http://devicetree.org/schemas/trivial-devices.yaml# > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: pvccinfaon-pvccfa-cpu0@= 58: 'regulators' does not match any of the regexes: 'pinctrl-[0-9]+' > from schema $id: http://devicetree.org/schemas/trivial-devices.yaml# > arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-sbp1.dtb: mp2973-pvccin-pvccfa-cp= u0@58: 'regulators' does not match any of the regexes: 'pinctrl-[0-9]+' > from schema $id: http://devicetree.org/schemas/trivial-devices.yaml# These still must be addressed as mentioned on v3 (with more specific comments regarding the infineon,ir38263 on v4). Please look through the binding documents for the affected nodes and make sure the nodes in your DTS conform to their definitions. You can check your work with `make CHECK_DTBS=3Dy aspeed/aspeed-bmc-ibm-sbp1.dtb` prior to sending. It may help to base your series on top of [1] to reduce the volume of output from CHECK_DTBS=3Dy. Andrew [1]: https://github.com/amboar/linux/tree/for/bmc/aspeed/dt