From: Florian Fainelli <f.fainelli@gmail.com>
To: Zou Wei <zou_wei@huawei.com>,
gregkh@linuxfoundation.org, jslaby@suse.com,
f.fainelli@gmail.com, bcm-kernel-feedback-list@broadcom.com,
linux-serial@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] tty: serial: bcm63xx: fix missing clk_put() in bcm63xx_uart
Date: Thu, 23 Apr 2020 08:46:54 -0700 [thread overview]
Message-ID: <4d5b3f7c-e516-2a4e-3594-1f8f705c16ab@gmail.com> (raw)
In-Reply-To: <1587472306-105155-1-git-send-email-zou_wei@huawei.com>
On 4/21/2020 5:31 AM, Zou Wei wrote:
> This patch fixes below error reported by coccicheck
>
> drivers/tty/serial/bcm63xx_uart.c:848:2-8: ERROR: missing clk_put;
> clk_get on line 842 and execution via conditional on line 846
>
> Fixes: ab4382d27412 ("tty: move drivers/serial/ to drivers/tty/serial/")
The driver was doing that prior to being moved, and since this is an
error path, I am not sure the Fixes tag is really warranted.
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-04-23 15:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-21 12:31 [PATCH -next] tty: serial: bcm63xx: fix missing clk_put() in bcm63xx_uart Zou Wei
2020-04-23 15:46 ` Florian Fainelli [this message]
2020-04-27 6:19 ` Jiri Slaby
2020-04-27 17:29 ` Florian Fainelli
2020-04-28 11:18 ` Greg KH
2020-05-01 1:40 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d5b3f7c-e516-2a4e-3594-1f8f705c16ab@gmail.com \
--to=f.fainelli@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=zou_wei@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).