From: Marek Vasut <marex@denx.de>
To: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: linux-media@vger.kernel.org,
Alain Volmat <alain.volmat@foss.st.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Amelie DELAUNAY <amelie.delaunay@foss.st.com>,
Hugues FRUCHET <hugues.fruchet@foss.st.com>,
Philippe CORNU <philippe.cornu@foss.st.com>,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] media: stm32: dcmi: Switch to __v4l2_subdev_state_alloc()
Date: Mon, 20 Jun 2022 16:06:22 +0200 [thread overview]
Message-ID: <4d5b5c59-f3d5-ad5a-ae61-73277b4adefa@denx.de> (raw)
In-Reply-To: <0dc2d603-586e-be49-8f8d-1f52f1915813@ideasonboard.com>
On 6/20/22 11:44, Tomi Valkeinen wrote:
> Hi,
Hello all,
>> On Sun, Jun 19, 2022 at 12:24:42AM +0200, Marek Vasut wrote:
>>> Any local subdev state should be allocated and free'd using
>>> __v4l2_subdev_state_alloc()/__v4l2_subdev_state_free(), which
>>> takes care of calling .init_cfg() subdev op. Without this,
>>> subdev internal state might be uninitialized by the time
>>> any other subdev op is called.
>
> Does this fix a bug you have?
Yes
> Wasn't this broken even before the active
> state, as init_cfg was not called?
Yes, this was always broken. I suspect nobody tested this mode of
operation before. In my case, I have this DCMI driver connected directly
to MT9P006 sensor.
> In any case, I think we have to do something like this, as the source
> subdev might depend on a valid subdev state.
Right.
[...]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-06-20 14:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-18 22:24 [PATCH] media: stm32: dcmi: Switch to __v4l2_subdev_state_alloc() Marek Vasut
2022-06-18 23:16 ` Laurent Pinchart
2022-06-20 9:44 ` Tomi Valkeinen
2022-06-20 11:28 ` Laurent Pinchart
2022-06-20 14:06 ` Marek Vasut [this message]
2022-06-27 9:14 ` Hugues FRUCHET
2022-06-27 11:30 ` Marek Vasut
2022-06-27 12:53 ` Hugues FRUCHET
2022-06-27 13:01 ` Marek Vasut
2022-06-27 13:30 ` Tomi Valkeinen
2022-06-27 15:11 ` Hugues FRUCHET
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d5b5c59-f3d5-ad5a-ae61-73277b4adefa@denx.de \
--to=marex@denx.de \
--cc=alain.volmat@foss.st.com \
--cc=alexandre.torgue@foss.st.com \
--cc=amelie.delaunay@foss.st.com \
--cc=hugues.fruchet@foss.st.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=philippe.cornu@foss.st.com \
--cc=tomi.valkeinen@ideasonboard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).