From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D5243C61DA4 for ; Mon, 6 Mar 2023 16:59:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ulh7qQJN5a0Mo+QoF+GP+QyBKHwPUHqceDpZk++Q/ZM=; b=1phbnc7HkucOAV W5Cs4QORjifT4PvjrAVgFQehXgf+sXVJd6HZp4Th7wmpa+psSH+2z7jt7gIlFs0mDZ0r+7LJEwMbd FF/GldTuIr6swg8acpOwzURdcCl8+r4o2IP9WFBYO2k8IV6BryQIzT7kIJp1EF8E4QojyWCPfFMjm XF49yyDQYID99BUIEtb9zB7oIw2IS2p37udzBjc03aO5ilUZzzBWB3tb39gBUybm1/8gnww1WVZtl aQodS11723Ihb3DgZgWP8OSTwmvwiowgNmclqQtwTODEWSyDjueKLkOeiE+EoaprCNhNiAruWEzdK wAzoHRLmLuDlRn3b2Xkw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pZEAJ-00E1ey-Js; Mon, 06 Mar 2023 16:58:23 +0000 Received: from linux.microsoft.com ([13.77.154.182]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pZEAG-00E1e4-Nc for linux-arm-kernel@lists.infradead.org; Mon, 06 Mar 2023 16:58:22 +0000 Received: from [192.168.254.32] (unknown [47.187.203.192]) by linux.microsoft.com (Postfix) with ESMTPSA id 1E820205749D; Mon, 6 Mar 2023 08:58:19 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 1E820205749D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1678121900; bh=kWkGguzIxCy4GS4idzAr3kaaQwhr8ad9JFP9cqeJZZc=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=G2XiKL0F+8KRP/0/o0hhWc9kFtD3WkrxYBRVizWFIxE2QpwDQPyP9MAY57wd5nOHx 63GWDVPQwsuJCkInTIadPfnIs+1UUulEj2LKbWvlmEWkvNeDbMckINcMyVfdWT7Enl Spo+yTLWQPMQQIHHs0rzSuLCb2gx0B07PQMW6Z3s= Message-ID: <4d69eee8-5401-ea20-a063-79cf199fe1cc@linux.microsoft.com> Date: Mon, 6 Mar 2023 10:58:18 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [RFC PATCH v3 00/22] arm64: livepatch: Use ORC for dynamic frame pointer validation Content-Language: en-US To: Petr Mladek , "Tomohiro Misono (Fujitsu)" Cc: "jpoimboe@redhat.com" , "peterz@infradead.org" , "chenzhongjin@huawei.com" , "mark.rutland@arm.com" , "broonie@kernel.org" , "Keiya Nobuta (Fujitsu)" , "sjitindarsingh@gmail.com" , "catalin.marinas@arm.com" , "will@kernel.org" , "jamorris@linux.microsoft.com" , "linux-arm-kernel@lists.infradead.org" , "live-patching@vger.kernel.org" , "linux-kernel@vger.kernel.org" References: <0337266cf19f4c98388e3f6d09f590d9de258dc7> <20230202074036.507249-1-madvenka@linux.microsoft.com> From: "Madhavan T. Venkataraman" In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230306_085820_848849_DC14A59C X-CRM114-Status: GOOD ( 16.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 3/2/23 10:23, Petr Mladek wrote: > On Wed 2023-03-01 03:12:08, Tomohiro Misono (Fujitsu) wrote: >> >>> Testing >>> ======= >>> >>> - I have run all of the livepatch selftests successfully. I have written a >>> couple of extra selftests myself which I will be posting separately >> Hi, >> >> What test configuration/environment you are using for test? >> When I tried kselftest with fedora based config on VM, I got errors >> because livepatch transition won't finish until signal is sent >> (i.e. it takes 15s for every transition). >> >> [excerpt from test result] >> ``` >> $ sudo ./test-livepatch.sh >> TEST: basic function patching ... not ok >> >> --- expected >> +++ result >> @@ -2,11 +2,13 @@ >> livepatch: enabling patch 'test_klp_livepatch' >> livepatch: 'test_klp_livepatch': initializing patching transition >> livepatch: 'test_klp_livepatch': starting patching transition >> +livepatch: signaling remaining tasks >> livepatch: 'test_klp_livepatch': completing patching transition >> ``` > > It might be interesting to see what process is blocking the > transition. The transition state is visible in > /proc//patch_state. > > The transition is blocked when a process is in KLP_UNPATCHED state. > It is defined in include/linux/livepatch.h: > > #define KLP_UNPATCHED 0 > > Well, the timing against the transition is important. The following > might help to see the blocking processes: > > $> modprobe livepatch-sample ; \ > sleep 1; \ > for proc_path in \ > `grep "\-1" /proc/*/patch_state | cut -d '/' -f-3` ; \ > do \ > cat $proc_path/comm ; \ > cat $proc_path/stack ; \ > echo === ; \ > done > > After this the livepatch has to be manualy disabled and removed > > $> echo 0 >/sys/kernel/livepatch/livepatch_sample/enabled > $> rmmod livepatch_sample > > Best Regards, > Petr Thanks for the suggestion. I will try to reproduce the problem and look at what process(es) are holding up the livepatch. Madhavan _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel