Re: [PATCH 1/5] spi: atmel,quadspi: Document sam9x7 QSPI

Dharma.B
2025-09-08T03:54:17Z

On 02/09/25 2:52 pm, Krzysztof Kozlowski wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> On Tue, Sep 02, 2025 at 11:22:18AM +0530, Dharma Balasubiramani wrote:
>> Document the sam9x75 quad spi that supports interface to serial memories
>> operating in
>>
>> - Single-bit SPI, Dual SPI, Quad SPI and Octal SPI
>> - Single Data Rate or Double Data Rate modes
>
> And I forgot - wrong subject prefixes.
>
> Please use subject prefixes matching the subsystem. You can get them for
> example with 'git log --oneline -- DIRECTORY_OR_FILE' on the directory
> your patch is touching. For bindings, the preferred subjects are
> explained here:
> https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters

I do exactly the same

$ git log --oneline --
Documentation/devicetree/bindings/spi/atmel,quadspi.yaml

c0f7ae27539f MAINTAINERS: Update email of Tudor Ambarus
77850bda360d spi: atmel,quadspi: Define sama7g5 QSPI
001a41d2a706 spi: atmel,quadspi: Convert to json-schema

I think the maintainer that merged these commits missed reviewing
subject prefix.

and I see a mix of

spi: dt-bindings:
dt-bindings: spi:
dt-bindings:

prefixes for this dir.

I will use "dt-bindings: spi:".

Thanks.>
> Best regards,
> Krzysztof
>

--
With Best Regards,
Dharma B.