Re: [PATCH 1/5] spi: atmel,quadspi: Document sam9x7 QSPI

Dharma.B
2025-09-08T07:02:27Z

On 08/09/25 12:12 pm, Krzysztof Kozlowski wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> On 08/09/2025 05:45, Dharma.B@microchip.com wrote:
>>>> Signed-off-by: Dharma Balasubiramani <dharma.b@microchip.com>
>>>> ---
>>>> Documentation/devicetree/bindings/spi/atmel,quadspi.yaml | 1 +
>>>> 1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/spi/atmel,quadspi.yaml b/Documentation/devicetree/bindings/spi/atmel,quadspi.yaml
>>>> index b0d99bc10535..c17114123034 100644
>>>> --- a/Documentation/devicetree/bindings/spi/atmel,quadspi.yaml
>>>> +++ b/Documentation/devicetree/bindings/spi/atmel,quadspi.yaml
>>>> @@ -17,6 +17,7 @@ properties:
>>>> enum:
>>>> - atmel,sama5d2-qspi
>>>> - microchip,sam9x60-qspi
>>>> + - microchip,sam9x7-ospi
>>>
>>> ... but 9x7 here. Confusing.
>>
>> It should be 9x7 only (qspi is common for sam9x7x), I will change it.
>>
> Hm? That's wildcard then. See writing bindings.

It's mentioned
"DON’T use wildcards or device-family names in compatible strings."

https://www.kernel.org/doc/html/latest/devicetree/bindings/writing-bindings.html

Here, in sam9x7x, the first "x" is part of name itself and not a
wildcard, so can I just stick to sam9x7?

we have previously followed the same in many bindings
"$ grep -nri sam9x7 Documentation/devicetree/bindings/"

>
> Best regards,
> Krzysztof

--
With Best Regards,
Dharma B.