From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E0F35C47DD9 for ; Wed, 27 Mar 2024 23:18:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YCJ1OogpfgJMH5hG5IDRrjv2g6aIlMjjYfte4TthutA=; b=AlOZQ6gg0u7Bjc YZX7jY8RE4e5drv+ma+6o+8QnowxqB+I0PQee+f5SetTzUIK/2bks5MYkKXUaQ4iG0fRly4hMFzM2 PUxzV3tWylyBAtr+6QE0Y69Ah4bTWfx/ajKM3XYStxwIW2hD/ulDUvuy5cOdiXiIriKC42I0jN7eo lghb4HudV0aa7BVM0AcU7CI9cnFlw1+GqbjAMCaU/Ky1QtCipuLst6T0QHIBSzOq9ttS2LN78r1zO asz3UBG2MpOYfhbYHY8tBMpjSOq0XQOWVEpn6ch2NK6iuQi4tntesVnCHJmbxRkxYGNIQITFlI7T5 Ej6w9f4tDQSACpSu+RuQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rpcXN-0000000BYbM-0V1a; Wed, 27 Mar 2024 23:18:29 +0000 Received: from mail-io1-xd30.google.com ([2607:f8b0:4864:20::d30]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rpbRb-0000000BMA1-1C4G for linux-arm-kernel@lists.infradead.org; Wed, 27 Mar 2024 22:08:28 +0000 Received: by mail-io1-xd30.google.com with SMTP id ca18e2360f4ac-7cc0b35b75bso10477339f.3 for ; Wed, 27 Mar 2024 15:08:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; t=1711577306; x=1712182106; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Bmkqc/3aYewIsupa3aI44uZjMZk6uVE6sk1O51xM5oE=; b=dB3ZWhhU1tiYflMf9DS9RcAnulk1eNVZuxDOFVkW6B9N4EWgZXW5j1CUNHBNhKXTfK ovt2nTNNsLjlhDf+R2Lw40kshH5ERAa2+VfDy6M8V0K680OET9XDZ7GZHOcn9Sx9dHf8 qs1+vliGvTs9cNXEBTHwvu97qAwmpns+S79Q+6aoI47Q7IayeLW4yc8Om7gI764VedBo pzyii9mm4eXH3W2W7F3GDMSuAQ1NDMWyxLdOEypKsPWuEtRlLoUPefUuem/3Nt3HiRX0 vAg4Scv49V5KhwG5HhtE+G91of1SurBYmM8napBh9HuBNOuUW6/ntYFHvIYrzPu9Sr76 PV9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711577306; x=1712182106; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Bmkqc/3aYewIsupa3aI44uZjMZk6uVE6sk1O51xM5oE=; b=qACxIJwC8c/afN5MQ5+LqbBaKifNk4+8JL6xcrcIfDVnwrTZC/nnWmYdztkT5JYLkx p4BjOKEkC0CviYNd1TsA94pbAuoVXPfIsFsJCyo+GX/Lit2OtZvoPghkZeZZm0YMgZEN Hp7RaMAzU04wa9FeepHg7aU+q5cDnuS27yRjHmMTlWJ7W53LIGjIH7o1eVhP27YA9y7p n4+IhBn5+TxPeAP7bZHVKWr9i2YlGDwsB6cEkQDaroSdE/Mm1jPazMvWbhPUuKjFsaYE 4e83y+/qUQ6NCV3QEP9LbYLcZ3fb1X9UKlNse50RRfuKh2n9OADUvytfrvVJ0LL2XD6h Wt7g== X-Gm-Message-State: AOJu0YxE6w3W0RA7lNJdW84yNBpAKuifKreymUv0fROx5EEzf61ql3m6 v5ItMTboyjZ8h1qnkJxmHU5ElrDfwWcAzggo5SDUDQCNDORu7BLU7vgcbFj6q5AGWgdu6z8w4gw 4 X-Google-Smtp-Source: AGHT+IGUYm3Y8wBDca1kE2cHOU4Wfjx7H338gBLx60QGaDb6jbN+3GFHHCGUs0OMGF33wA7wIsUyRw== X-Received: by 2002:a6b:f919:0:b0:7cb:ffd8:1546 with SMTP id j25-20020a6bf919000000b007cbffd81546mr1424618iog.19.1711577305709; Wed, 27 Mar 2024 15:08:25 -0700 (PDT) Received: from [100.64.0.1] ([170.85.6.190]) by smtp.gmail.com with ESMTPSA id f12-20020a056638118c00b0047bea529fddsm2373jas.104.2024.03.27.15.08.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 Mar 2024 15:08:25 -0700 (PDT) Message-ID: <4d9633cd-15c4-4cc1-ac67-2592e9fc7880@sifive.com> Date: Wed, 27 Mar 2024 17:08:23 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 12/14] drm/amd/display: Use ARCH_HAS_KERNEL_FPU_SUPPORT To: Andrew Morton Cc: linux-arm-kernel@lists.infradead.org, x86@kernel.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, Christoph Hellwig , loongarch@lists.linux.dev, amd-gfx@lists.freedesktop.org, Alex Deucher References: <20240327200157.1097089-1-samuel.holland@sifive.com> <20240327200157.1097089-13-samuel.holland@sifive.com> <20240327142516.e4b1f9ba6e2ec7bc300e4d58@linux-foundation.org> Content-Language: en-US From: Samuel Holland In-Reply-To: <20240327142516.e4b1f9ba6e2ec7bc300e4d58@linux-foundation.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240327_150827_562073_7E261CEC X-CRM114-Status: GOOD ( 15.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2024-03-27 4:25 PM, Andrew Morton wrote: > On Wed, 27 Mar 2024 13:00:43 -0700 Samuel Holland wrote: > >> Now that all previously-supported architectures select >> ARCH_HAS_KERNEL_FPU_SUPPORT, this code can depend on that symbol instead >> of the existing list of architectures. It can also take advantage of the >> common kernel-mode FPU API and method of adjusting CFLAGS. >> >> ... >> >> @@ -87,16 +78,9 @@ void dc_fpu_begin(const char *function_name, const int line) >> WARN_ON_ONCE(!in_task()); >> preempt_disable(); >> depth = __this_cpu_inc_return(fpu_recursion_depth); >> - >> if (depth == 1) { >> -#if defined(CONFIG_X86) || defined(CONFIG_LOONGARCH) >> + BUG_ON(!kernel_fpu_available()); >> kernel_fpu_begin(); > > For some reason kernel_fpu_available() was undefined in my x86_64 > allmodconfig build. I just removed the statement. This is because the include guard in asm/fpu.h conflicts with the existing one in asm/fpu/types.h (which doesn't match its filename), so the definition of kernel_fpu_available() is not seen. I can fix up the include guard in asm/fpu/types.h in the next version: diff --git a/arch/x86/include/asm/fpu/types.h b/arch/x86/include/asm/fpu/types.h index ace9aa3b78a3..75a3910d867a 100644 --- a/arch/x86/include/asm/fpu/types.h +++ b/arch/x86/include/asm/fpu/types.h @@ -2,8 +2,8 @@ /* * FPU data structures: */ -#ifndef _ASM_X86_FPU_H -#define _ASM_X86_FPU_H +#ifndef _ASM_X86_FPU_TYPES_H +#define _ASM_X86_FPU_TYPES_H #include @@ -596,4 +596,4 @@ struct fpu_state_config { /* FPU state configuration information */ extern struct fpu_state_config fpu_kernel_cfg, fpu_user_cfg; -#endif /* _ASM_X86_FPU_H */ +#endif /* _ASM_X86_FPU_TY{ES_H */ Regards, Samuel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel