From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 958A3C43381 for ; Mon, 25 Mar 2019 09:50:12 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5429C20870 for ; Mon, 25 Mar 2019 09:50:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="SabuX6as" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5429C20870 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=i2se.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=2B75UwUXaf3MUKO3cxMHw2zCKyRZBMuZnNvwkP6U4Q8=; b=SabuX6asO1ncN09Flc9koC3k1N Q+1KQ/yFJgzBRJKkPJPGuAzkxEz4eGPEQQk7f4ezF/9yIEHTn0uP5wyz29qthCA7qcFaqx1kKuyn6 S6UTkQ8/2SNcAjs3c9ha/P/MecZ6j7uL7FFr2ddKUwTqot+WCr8kx4ea5y5TWdHZm7eVUm0q5dyXH 4hLZbHbT/K6ebI4gTC4NXwXUMbaGq8V1B4bWiMF243i8Ap5YHtXAbJqLZFLP1TjhRR9vVpJkNyA2m PVfq4fZBHXmSEQPvb9eqWrS80mdYtuu34XjUKtpkMhnZvcFc1SLD1a7+6qEmuZJ4w+K2ZAxcKaZvy kIvoZ/Hg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h8MF2-0005cf-Ko; Mon, 25 Mar 2019 09:50:04 +0000 Received: from mout.kundenserver.de ([212.227.126.187]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h8MEu-0005QO-JF; Mon, 25 Mar 2019 09:50:00 +0000 Received: from [192.168.178.52] ([109.104.40.77]) by mrelayeu.kundenserver.de (mreue010 [212.227.15.167]) with ESMTPSA (Nemesis) id 1N4A1h-1gzjFd2VEH-0106BK; Mon, 25 Mar 2019 10:44:20 +0100 Subject: Re: [PATCH V2 9/9] spi: bcm2835aux: make the polling duration limits configurable To: kernel@martin.sperl.org, Mark Brown , Eric Anholt , Hubert Denkmair , linux-spi@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org References: <20190324175002.28969-1-kernel@martin.sperl.org> <20190324175002.28969-10-kernel@martin.sperl.org> From: Stefan Wahren Message-ID: <4da737f4-acf2-c70d-59cd-0efdf2ec21d4@i2se.com> Date: Mon, 25 Mar 2019 10:44:19 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <20190324175002.28969-10-kernel@martin.sperl.org> Content-Language: en-US X-Provags-ID: V03:K1:S9Z+pp5WkkBj40x1bYIId5aKIX0hla4YnV8E5Ladc/uaSQW9rFg yo14YYi+51blLbIwF7sAqUeYgA/YDWzhxDnJBHzak8ZoyKEfIYJNNHWjTPKCy9aPXi31ydj mM11yZU0vC8IWd5DiYYTLy1pOYQjnEkfrJMwtzFYhtGwqT0daMzuEoAy9+nGrkzzeqhoXmc h8X4iozF1sIGRQPpaEnpQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:sqAzwIcte94=:bEzR6Bt4H+LVtjhA4DXjuj hABK4Q8WlAebaNz6ytxAYGeq8pg+gT7KNr7W4CIVO5+wv6GhwK06UjGjDqI8ytx42fXHBcJhA ifpI3Mt8xMgE9s95RUIoVCp7WC7REKJffmWb4gAOoYCGvxt/89TWJYi+xIbCEo5Rnk/BPZaGN XaEZLeDbd0z40GI1qQihgCy/ddyEQPlADhjMOyC+qGRY7NN5aaLn41ZpCJFvFUbzZWVbgsfmV m48is/4R0VMmCUoXRmjYQNeq5o9uso/8upDizKbLTsH0Ue+jjjB28iWbdpulyJJl82ikQBRke P9Mh7kW33LZTgjKfCnFkHt9NNoCs8jYUHLBBqmrbouRtioD6GDiC1CAW53Q+FB+VxTAOhM9/D HucWNkNoG953yYJF/2iWXswlbNhQve9lnyOGubRrXjT2LXlfHjR42fHm6mwv9creNtNleLrfc EgCVp/v8hvQY/rr9UwKZw1HXlabdd69pP09ETWDDPJnSKPQdi8Gc78H6aSEVF7asrxkjzLKHF GkbBY8VN99+yqcWLz+0AKQhEKePg9Sq8MdOhUieJmrlY7lr+mO8+3qHeFM9RXeI5t5kxyKWO2 rS1hLXWLbarmcycHK4OuJCx5D7CyhTlDo4O6ZDbiBHdH71jJ2qKAc3NiiygM33JnjvuUiHNTY /EWtKeA6qJh9vTkgISiipW+ZFgncHJLaIJ8OGDnbDeYlwWwPk4VS/FpIcVkhIzAFHu+dAh/nG g6EN4XwMIrecMimo7ct+Hqzz8LdQZ/xTkKhuI1ukPxEaDpgCXYdi3mLe+f8= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190325_024956_942563_91A3B855 X-CRM114-Status: GOOD ( 15.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Martin, Am 24.03.19 um 18:50 schrieb kernel@martin.sperl.org: > From: Martin Sperl > > Under some circumstances the default 30 us polling limit is not optimal > and may lead to long delays because we are waiting on an interrupt. > with this patch we have the possibility to influence this policy. > > So make this limit (in us) configurable via a module parameters > (but also modifyable via /sys/modules/...) > > Signed-off-by: Martin Sperl > > --- > Changelog: > V1 -> V2: remove the dependency on a different patchset focused on > making cs_change delay configurable > > --- > drivers/spi/spi-bcm2835aux.c | 25 ++++++++++++++----------- > 1 file changed, 14 insertions(+), 11 deletions(-) > > diff --git a/drivers/spi/spi-bcm2835aux.c b/drivers/spi/spi-bcm2835aux.c > index d2b58060b333..df065108122b 100644 > --- a/drivers/spi/spi-bcm2835aux.c > +++ b/drivers/spi/spi-bcm2835aux.c > @@ -37,6 +37,12 @@ > #include > #include > > +/* define polling limits */ > +unsigned int polling_limit_us = 30; > +module_param(polling_limit_us, uint, 0664); > +MODULE_PARM_DESC(polling_limit_us, > + "time in us to run a transfer in polling mode\n"); > + could you please document the case polling_limit_us = 0 ? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel