From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6FE2CC27C4F for ; Fri, 14 Jun 2024 02:49:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:CC:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=dQYoWVIHyzSvtaN8RxrEFq8XWyBhG+ubp8IuNUzX7pE=; b=XhlyvDDS5gMtFh8XgqQsaLazkc DCaUk0KQ4le6W4RzWhOGaoIxobyrQ6v2Ud4pGufK4dCYQFF7wbo831UrCj/mjT5ZZBfeOTJ/Ol5dR vbaHGHAZBtlTKy6J81I2x6pGHlv9mg15t1ZAZJ9CIX5IWQet8XemFj+C7g3pCBzyXGkaCxlk8Fh78 3x4FFPcKwPjhyR6JRAiHz+o+Qz8mxrSrTWbVK3HFC4t5e5BG57ZEb4HqRNzLV0wezVuTnnJ/P6cyE GDehjVEkrXObIDAxLZ3ax+0QEYvH7oCHrAcbgncidnMWk34cmAd9xR0h2fG/lVtmnW0iWNJ/JXwo6 aNH5zgvA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sHwzq-00000001Bvk-24ot; Fri, 14 Jun 2024 02:48:58 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sHwzY-00000001Bip-1zNe for linux-arm-kernel@bombadil.infradead.org; Fri, 14 Jun 2024 02:48:40 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:From:References:CC:To:Subject:MIME-Version:Date:Message-ID:Sender :Reply-To:Content-ID:Content-Description; bh=dQYoWVIHyzSvtaN8RxrEFq8XWyBhG+ubp8IuNUzX7pE=; b=GK5GQUqHi7mBaPVoS4k13ZP9UV PWo5q3DfGhpqTUnSoj9GsbdQiUt2773JVcquNijD793dJp2JW/uIIqOCN0hXk9QBN5+RnW+r94UF+ 7SN2iKXOuqj7BUjK1HTwCEa3rzNwBCnP5BjhX+tTbIRSxDmx2xFNqminDbJzOFvBVr9phl0BGHeKm 6/Sgqf4vEY9qgvMIj5iqDPGZe/txGM6cmUfwDnpmPF+tx2s2JsWse/h+zmYzPQx4GehQvUsNpwWDc wwlBRRQRdB3IySJlIUUsFqC2xr8xXtfo3xDVV/Eg1Zun3tt28ZEDtb4nE/EpKj0pzpKKaMUWws+R4 9eN4DxqQ==; Received: from szxga06-in.huawei.com ([45.249.212.32]) by casper.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sHwzU-0000000GVHk-41T7 for linux-arm-kernel@lists.infradead.org; Fri, 14 Jun 2024 02:48:39 +0000 Received: from mail.maildlp.com (unknown [172.19.162.112]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4W0kFL6ZScz3PsZk; Fri, 14 Jun 2024 10:46:46 +0800 (CST) Received: from kwepemi100008.china.huawei.com (unknown [7.221.188.57]) by mail.maildlp.com (Postfix) with ESMTPS id E7B2A1401E9; Fri, 14 Jun 2024 10:48:10 +0800 (CST) Received: from [10.67.109.254] (10.67.109.254) by kwepemi100008.china.huawei.com (7.221.188.57) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 14 Jun 2024 10:48:10 +0800 Message-ID: <4dabec63-66bf-b13a-de00-287157cf80ef@huawei.com> Date: Fri, 14 Jun 2024 10:48:08 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [PATCH] arm64: smp: Fix missing IPI statistics Content-Language: en-US To: Doug Anderson CC: , , , , , , , , , References: <20240607074716.4068975-1-ruanjinjie@huawei.com> From: Jinjie Ruan In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.109.254] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To kwepemi100008.china.huawei.com (7.221.188.57) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240614_034837_310889_B7B5CD84 X-CRM114-Status: GOOD ( 12.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2024/6/8 0:02, Doug Anderson wrote: > Hi, > > On Fri, Jun 7, 2024 at 12:45 AM Jinjie Ruan wrote: >> >> commit 83cfac95c018 ("genirq: Allow interrupts to be excluded from >> /proc/interrupts") is to avoid IPIs appear twice in /proc/interrupts. >> But the commit 331a1b3a836c ("arm64: smp: Add arch support for backtrace >> using pseudo-NMI") and commit 2f5cd0c7ffde("arm64: kgdb: Implement >> kgdb_roundup_cpus() to enable pseudo-NMI roundup") set CPU_BACKTRACE and >> KGDB_ROUNDUP IPIs "IRQ_HIDDEN" flag but not show them in >> arch_show_interrupts(), which cause the interrupt kstat_irqs accounting >> is missing in display. >> >> Fixes: 331a1b3a836c ("arm64: smp: Add arch support for backtrace using pseudo-NMI") >> Signed-off-by: Jinjie Ruan >> --- >> arch/arm64/kernel/smp.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) > > While I won't object to your patch if everyone agrees that we want it, Hello, What's everyone's opinion? > fully excluding "cpu backtrace" and "kgdb roundup" from > /proc/interrupts was more of a design decision than a bug. Those two > IPIs are really special cases and not something that I'd expect anyone > to care about knowing the count of. Keeping them out of > "/proc/interrupts" just avoids noise. I'd also note that I believe > arm32 makes the same design choice for "cpu backtrace". Yes, arm32 is same as arm64. > > In any case, if we truly think people want the count of these IPIs > then it feels like we should report them in arch_show_interrupts() > where we can give them a nice string. That's a good idea. > > -Doug