From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EEB20C3A59E for ; Wed, 4 Sep 2019 06:14:36 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BF28223402 for ; Wed, 4 Sep 2019 06:14:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="GHKuCmUc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BF28223402 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Jw0LEMHLt3WeqrGjeGT5XwHmNkdl+Cr52ZB/qNm5DUw=; b=GHKuCmUc2tlnLT +XOgWO75ahoQTDvTl6MgC8RS8q1YTy+R+biD6KJYLpeYMFwc69AyuGdhNgeRXQEOHzx9+2bbm1eQj 3XzFOwsg2cqPwpzlbs1wby/IOnspbFZ67v4Qx6sCsbiK1MQu19hwB09HfReaA7h6u/q1oNV0ysy9E UmNS5Kv49ZeG9Iv1P4jTPm4/ArcXGDwZy6WIfOecduhqyjn4OKVSRWdDCoIWY5hdGHMX9clpLa221 nfiq/20ofRXoOrWXVh7Ce9naNvT+99gy+QpXU86O1K4JQo60bJpv1Mq4AviadvLKcoXKXo0a6u9lA km8gH541VTFl6IOFyWIw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i5OYs-0007xn-Ai; Wed, 04 Sep 2019 06:14:34 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i5OYo-0007wY-7w; Wed, 04 Sep 2019 06:14:31 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 312C2344; Tue, 3 Sep 2019 23:14:29 -0700 (PDT) Received: from [10.162.41.129] (p8cg001049571a15.blr.arm.com [10.162.41.129]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 89A8D3F718; Tue, 3 Sep 2019 23:16:41 -0700 (PDT) Subject: Re: [PATCH 1/1] mm/pgtable/debug: Add test validating architecture page table helpers To: kbuild test robot References: <1567497706-8649-2-git-send-email-anshuman.khandual@arm.com> <201909031912.htvWy2Bu%lkp@intel.com> From: Anshuman Khandual Message-ID: <4dc9698f-dff4-b916-a83e-dc932c8087c0@arm.com> Date: Wed, 4 Sep 2019 11:44:25 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <201909031912.htvWy2Bu%lkp@intel.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190903_231430_367719_6C33792B X-CRM114-Status: GOOD ( 18.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org, Tetsuo Handa , James Hogan , Heiko Carstens , Michal Hocko , linux-mm@kvack.org, Paul Mackerras , sparclinux@vger.kernel.org, Dan Williams , linux-s390@vger.kernel.org, Michael Ellerman , x86@kernel.org, Russell King - ARM Linux , Matthew Wilcox , Steven Price , Jason Gunthorpe , Vlastimil Babka , linux-snps-arc@lists.infradead.org, kbuild-all@01.org, Kees Cook , Mark Brown , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, Sri Krishna chowdary , Masahiro Yamada , Greg Kroah-Hartman , Ard Biesheuvel , Dave Hansen , linux-mips@vger.kernel.org, Ralf Baechle , linux-kernel@vger.kernel.org, Peter Zijlstra , Mike Rapoport , Paul Burton , Vineet Gupta , Martin Schwidefsky , Andrew Morton , linuxppc-dev@lists.ozlabs.org, "David S. Miller" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 09/03/2019 04:43 PM, kbuild test robot wrote: > Hi Anshuman, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on linus/master] > [cannot apply to v5.3-rc7 next-20190902] > [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] > > url: https://github.com/0day-ci/linux/commits/Anshuman-Khandual/mm-debug-Add-tests-for-architecture-exported-page-table-helpers/20190903-162959 > config: m68k-allmodconfig (attached as .config) > compiler: m68k-linux-gcc (GCC) 7.4.0 > reproduce: > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # save the attached .config to linux build tree > GCC_VERSION=7.4.0 make.cross ARCH=m68k > > If you fix the issue, kindly add following tag > Reported-by: kbuild test robot > > All error/warnings (new ones prefixed by >>): > > In file included from arch/m68k/include/asm/bug.h:32:0, > from include/linux/bug.h:5, > from include/linux/thread_info.h:12, > from include/asm-generic/preempt.h:5, > from ./arch/m68k/include/generated/asm/preempt.h:1, > from include/linux/preempt.h:78, > from arch/m68k/include/asm/irqflags.h:6, > from include/linux/irqflags.h:16, > from arch/m68k/include/asm/atomic.h:6, > from include/linux/atomic.h:7, > from include/linux/mm_types_task.h:13, > from include/linux/mm_types.h:5, > from include/linux/hugetlb.h:5, > from mm/arch_pgtable_test.c:14: > mm/arch_pgtable_test.c: In function 'pmd_clear_tests': >>> arch/m68k/include/asm/page.h:31:22: error: lvalue required as unary '&' operand > #define pmd_val(x) ((&x)->pmd[0]) > ^ > include/asm-generic/bug.h:124:25: note: in definition of macro 'WARN_ON' > int __ret_warn_on = !!(condition); \ > ^~~~~~~~~ >>> arch/m68k/include/asm/motorola_pgtable.h:138:26: note: in expansion of macro 'pmd_val' > #define pmd_none(pmd) (!pmd_val(pmd)) > ^~~~~~~ >>> mm/arch_pgtable_test.c:233:11: note: in expansion of macro 'pmd_none' > WARN_ON(!pmd_none(READ_ONCE(*pmdp))); > ^~~~~~~~ > mm/arch_pgtable_test.c: In function 'pmd_populate_tests': >>> arch/m68k/include/asm/page.h:31:22: error: lvalue required as unary '&' operand > #define pmd_val(x) ((&x)->pmd[0]) Storing READ_ONCE(*pmdp) in a local pmd_t variable first solves the problem. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel