From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 61802C0015E for ; Thu, 15 Jun 2023 05:28:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:CC:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kWHGOpQGCV8Gdy4ximZ9nDGNOshA0ICTvKwX2yciqG0=; b=s1zvCWkcV4Z3jO 9ZYhhuF6M+hKnzPG+e8YBHr9ZSaA4zDFkfK9l9dxxpznP/iH9kLAE3JBZxWT8EmcyrzYzUb2dU6RZ cVeioJr7NlxJQnmR9ONDiTnGDMr/YdJDiFl68Cgn+gEhjiga6A3mOFLIX/a2QDy/vxMJZuJ5we9zI MPM4wy+2xusLxZ+kLaU1HemzQWyzyPcNYoQhaP6WxlWgjZcm9VggwPEr7+qP/EjUFMOsr1KSY1Og0 31oMzSPsotx5viufX6xSbAt4Xs1LbuqnuT4BpVLBx6a1YeqdmUYSRCkFq6rSTSs8qdpqjFqMLPyPT EKen3UFwz+w9tftqbpbA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q9fWv-00DiNW-2w; Thu, 15 Jun 2023 05:28:21 +0000 Received: from esa.microchip.iphmx.com ([68.232.153.233]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q9fWr-00DiLt-2O for linux-arm-kernel@lists.infradead.org; Thu, 15 Jun 2023 05:28:20 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1686806898; x=1718342898; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=8/0hKACaS5FCl/ib/WnESbATNEqF9mx0YDjALVqR30k=; b=mh0k3w7l33nNPPj9UctJ+EfKqO0ZiaOWhe69qhc8GcYOs2uYgmpFbmDR SbeHQeJzQcCjOPg7wmyAwy3CRDuS+7ZRWWLkEo/ZqResaETuJwq02Z8Kl DQJ9/4REFp7ebJIZFkWYPLyR1JP6bKKfBqu/vI+U7IaxNwbKEvNj475Up mo1FxGDXJAWOhqQzNN6SmPPishg+YbR8m2gb35orNTqsZ/OaZCdKL7pr/ lAuvsOMqNtpGR0H1rEf8WKKvpHKTQ3dwSySfgXcKvrnrtEZBoDHhhi8L3 O0UmvleGcju98ZrRB33e4Hin9ihaDWlH4yvYgy7KX8XMq95537Ts4NOWN A==; X-IronPort-AV: E=Sophos;i="6.00,244,1681196400"; d="scan'208";a="218589889" X-Amp-Result: SKIPPED(no attachment in message) Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa5.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 14 Jun 2023 22:28:09 -0700 Received: from chn-vm-ex04.mchp-main.com (10.10.85.152) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Wed, 14 Jun 2023 22:28:07 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (10.10.215.89) by email.microchip.com (10.10.87.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Wed, 14 Jun 2023 22:28:07 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eWby0iQyEYq/6IP58RxaIcuV/awTOUzxUf4GBeQE0u2rsKoIuM9h+b+brAnoD4lo3BjSLizXbsY8JnqRdaCPtp4z3w63tLWpVhBXxRJ4FTZPCmUUWZs7u/bpf+MFGxZv0mr4EQBB05pcoB3hl+PNMZaVKv/JScwOsiii2TpNm1bRTzQnYwlFAesNdvdhix7Ab8yNCkFLq9V2GAip+Fn5rCsZSZ9j+RWRAXY8cKjFRfOagoGR3uz8WuUVD0DcXFFBvq5tJQ/EQ/CzcdCRJ74bajowZ/c3rwrNhPPPwR5b9kyMIxf7EJJl6ls87avw542s9f/M2peIOYz2O+pBvFBBdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8/0hKACaS5FCl/ib/WnESbATNEqF9mx0YDjALVqR30k=; b=dpatM8xoNX6kJ+ucK7GmPt7wyDxi0LljZYoZbQgSLT2v0yGZN4gBxCJWETpsABlp2bRXp8jhjc2U38GpzjNDkd8m8G8KHi8PSgFZ7Dk+Ykn6ybjS9cHVI7x+oz7zC+dgtoTShOF4wcI2dLAl/MNbvtu+lYyhpTllxJbWvlGLaIo/u+vXsK6yDU27le+jrnQt7nOMBRVJ1/KxQogyUuvnxitKWcNNXfmFDJynouD4sJ4lE8/VGVYF9y3AXxZ1SMZZIVOEA5KiGDRlt/Tv09b6YNuR8Ya3sDRkQ0cf07D82uJJEsJZp27CqbKzSTlHssqj0z38CbgUl1PaIDFG4rSnpA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microchip.com; dmarc=pass action=none header.from=microchip.com; dkim=pass header.d=microchip.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microchiptechnology.onmicrosoft.com; s=selector2-microchiptechnology-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8/0hKACaS5FCl/ib/WnESbATNEqF9mx0YDjALVqR30k=; b=jpwb5va58KMXlanwN2dhFj5siJeHJ2+0Hik2a1j5KP7y5lzMciykUTDs1XAVHR7EU3sVgELXI8wY/BKc2/Kuq3KnQK7vxq+CoQLP6O+Xvhzdv9AjeOe0IR9GKE7s+3BWeCAPFXt42rAFj3glLXoCVZkzlDNpLF7KfCIERlRDxXw= Received: from IA1PR11MB6193.namprd11.prod.outlook.com (2603:10b6:208:3eb::19) by CH3PR11MB8211.namprd11.prod.outlook.com (2603:10b6:610:15f::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6477.29; Thu, 15 Jun 2023 05:28:06 +0000 Received: from IA1PR11MB6193.namprd11.prod.outlook.com ([fe80::fae1:9490:ead6:1009]) by IA1PR11MB6193.namprd11.prod.outlook.com ([fe80::fae1:9490:ead6:1009%4]) with mapi id 15.20.6477.028; Thu, 15 Jun 2023 05:28:05 +0000 From: To: , , , , , , , , , , , , , , CC: , , , , , , Subject: Re: [PATCH 4/9] drm: atmel-hlcdc: Define SAM9X7 XLCDC specific registers Thread-Topic: [PATCH 4/9] drm: atmel-hlcdc: Define SAM9X7 XLCDC specific registers Thread-Index: AQHZncWK3LbWzccTJku2elGx3bMnpK+J3IEAgAF8QYA= Date: Thu, 15 Jun 2023 05:28:05 +0000 Message-ID: <4dd2d0df-c225-e4aa-1b3d-4a8cfddb371a@microchip.com> References: <20230613070426.467389-1-manikandan.m@microchip.com> <20230613070426.467389-5-manikandan.m@microchip.com> <45b4fc00-fd46-9594-d621-33ad1db4c4de@microchip.com> In-Reply-To: <45b4fc00-fd46-9594-d621-33ad1db4c4de@microchip.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=microchip.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: IA1PR11MB6193:EE_|CH3PR11MB8211:EE_ x-ms-office365-filtering-correlation-id: 27fb952c-8109-4d78-ee2e-08db6d614c00 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: BTQjFt+ZXguQZP4K9U/ZvZnzjf9uA7Kh1XEP/FcEx/BetOYR/A2Bx5yUx0q4z231Es7rDOMytEbDbMvboeoLCiyeCbMEUpm3eXHYCrgRy6NMUADfP57D8NU9lunoJpIvpFubK3WxvmsWvooN5qUsQKLovMkeDh78aufQ9iQz5WpPZUMUMQ7mSj0R4jujbaw05Ct+r6uxrLS2gPVwZdzDg5gjKTB3JWyABBVfnoECYvm06UXWVx4wvO2WOdjnlPwAWZsPIUupC8m1X5dGKcMlEsQUiuqoaeTdScPXBiSbApJpOvHKPnbcSzpFM1ztEwYdJ5nkCoCzDtXnue3yPBiqAy7lpRVeitT/GvK20qsE7H+mo/Bw4MtfquOTm7yQNnON0DQDHyT4AX0NA68MOg46uxHfZvLCq19HhSj/Dypk7wjHbfd7fhbyeNgkfNgLqDsWXMdj5gbUV3CBLMf9k5oX/cnqrBLDtEDxKuVU+IZwD5uLdDhvKte/dDSX7r4as3ygk7TuwHF556U2vIozrwpBafv3yfljuwwiaeI7QNrEEpUfHwHpa/8N19gQGjHrgoyUthMUVWsmikquTJ8/ugF9Tjvjd4y2Rkzf43ht7yAKcUgLp6QoCfw1aeFNExI43VWbx+IcfQPs09ChKpmiaCByOCCo+cKfMd1L20jz4R8YQ/w= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:IA1PR11MB6193.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(39860400002)(136003)(376002)(366004)(346002)(451199021)(2616005)(5660300002)(54906003)(921005)(66476007)(110136005)(71200400001)(91956017)(122000001)(6486002)(66556008)(8676002)(41300700001)(8936002)(38100700002)(66946007)(76116006)(4326008)(64756008)(316002)(478600001)(66446008)(6506007)(186003)(83380400001)(107886003)(26005)(6512007)(53546011)(31696002)(86362001)(7416002)(38070700005)(2906002)(36756003)(31686004)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?N3BLaDY1Wi9pVWlQK1NuL0ZCOXRkSkxPeWtUVEYzNmljRVUxeHdKRzBZU1Va?= =?utf-8?B?UlREZnducit4Nm9icE8xV283S3JmUlVaQ3FIN1JqVVVTNXNIOWZFUmNaWGVY?= =?utf-8?B?UXoxZUZvTDJQVjZ2L2hrZktqUjRLWUZoK05yV3V5Q0ZrTGhCUmtvc3ZYM3dz?= =?utf-8?B?V3hwYm84NkxZWnVReWs1NXF0c1RaMUNjQzI4NlVCKzg4UnlwNzBnQVFvNUE3?= =?utf-8?B?b09MZWVPc0VwaC90a2RKYUlXMXBBbVY2MEtxM0xpY1lMWGtCZllBa0NNbDZn?= =?utf-8?B?dzQ2NE5FczBqUWZGbjlTQXJ5eHVZOTRCK3ZKUTRYWHhxaUZpOE1HZmpkSUxX?= =?utf-8?B?RllnOEdxdkhCVlZhaW1HVTBJOGlta29SQmpNSC9SSVcxbVdHK0RxbnJsZVpq?= =?utf-8?B?NTZXVVRMVVJGMTFpczFGdm5ZVDNYSG9OdmsyanFyanVpeU1PZGE1OEhqVEc2?= =?utf-8?B?Z096dGtmSXAzRzB3N20vYm5KdlJUeVR6NG1iRTRJYm9VV0lOTGtNbVFyMmU1?= =?utf-8?B?TDYxeHRBaDNPM3BJK244L21XRkVMKzVzNXgzVmNlb1ZOampTMEI5OXRUekFx?= =?utf-8?B?NzFEbEVSQjN5NmxBcE44Tm9aN0gyTU51UmNub0NCRVQrWk5RNVZGVDlrekYx?= =?utf-8?B?YVJiZVE3MmJ0OWNoOUJhU0pmRnFZdi8rT1dvbjluankzSkN5NnJNLytqbSto?= =?utf-8?B?Q1hhZ3dleTZZcC9yNjZLbDZ4aXhieUVJMWxoT1BRNVVPaHpINU13OXZaUERo?= =?utf-8?B?NERBWSt4ZU9UVmMvWUpSQ1FCSzkzN0kzVnllTzFNd1FRZHpyV29qYUwzMDlL?= =?utf-8?B?blc3S01mNmpFS09BL3FsYjVnL0RIV29MdzgrcmI0T0hKQW5rbXBRRncrVUVU?= =?utf-8?B?NDVobUJDcDkwVHNYdng1RlNXb0N0TlNWdzZHcEMvVmdIVzNyc1ladDZzbXN1?= =?utf-8?B?b0VHTlc5Y3J6YUlQZ1BYbExOQkFkQ0w3K1BpaGhhYlBNZ1JacmtzbHp0Um1P?= =?utf-8?B?dUs4VmhFOU1PNHVEVnRpSkNYdjZRRXU2OGdNejZoZTdPaGxtQUJhYS85QjNj?= =?utf-8?B?S3pTZXN1UGhIQTRnRkhJaVQ4em5NeW1RMmVucDR5TlQ0Zm00aFBQa0hMNU53?= =?utf-8?B?eHVGQXB5VTVyZGxWSW5iTjI5Qkt3SFp5Y2lOdUFMQXRWdlhneEwybU5VNnFn?= =?utf-8?B?ZGJ6WVQ0cWQvWTVhc25TV3BPd1RjNzl5amlKbWhjMDNaV1NGTXFVQjdhMWpr?= =?utf-8?B?VVY2blFPdW1uZkJNa25YS2sxZThOTTFjdm5uOVVwV0gxUWJpYy9Ca3FPRUMz?= =?utf-8?B?cGd1SVFWV0hWZWlyQ0UvVDJxRDA2RDBuWmE2d1pvcTgya2krc2MzZDg1ZWRW?= =?utf-8?B?cFFSRzdzRnVwWk9ZQmtiS2drMTJNNGJwSnQ2RVhUbjU5MnBmNUZlQUJIc3NL?= =?utf-8?B?N3VhdFJZeGZETlF5bXZqQkhwQnFYZXU0RHFKc1hyTzF1OStLNHh6dHI3dS8x?= =?utf-8?B?NXUvZVlFSTV2clpIVzh1V0FnWll4THJnOU5tYTRtaWxiazBkVDN2b0kvTjV0?= =?utf-8?B?a2VEdWlJbUlQUGhLVzVrZ0g0eEhIbjdyZlBNeEd0NEV4TlpUVzBHeEFIU0x6?= =?utf-8?B?RXVmck4xM2RYVTBTNC9iMUNoOGw4SW0rQjBjTkxIVHFsczJpS1Y2ajRPTkNX?= =?utf-8?B?bTU1SnVKWlF3bUkrRjdUU3pQUkgzZU5BRitpU1ZSWjhPR21hcERqU2xBRXRG?= =?utf-8?B?WlRhYWQzNTdrUDI1cG1UWWh1dVY4ZHVZVmhiN000dWxhSGFlY1NlRTBLdE9Y?= =?utf-8?B?cUtGbFpxbkpieWtUVnZ2U1hrSjR2dDU4ZERGUFkwNkx3anpCd2ZlaDhBbGRs?= =?utf-8?B?bGR4bnpDWE5CbVB5Z2o1WDFsR1I4TFVFZGxRUW8zK25WaDBBL0RBMGMvQ2dO?= =?utf-8?B?dHE4WG0wWFh4cVFTRFNDSlc4T3JCaXFrQlB1L0l3d0VRR2Z2Z0xEU0JVaUx4?= =?utf-8?B?Rml2aWJtMG1SRG1xSFE4c09iSWU5emxNRVQyRDVBcFREMzNIaWlacmpQUCtD?= =?utf-8?B?MG5DL2RHclZpZWNYdnI1SGk4WWJ4Q2dOYURnUEtNNmRXSFMrME4yVWR0bkJh?= =?utf-8?Q?HUzhQA2+vSfM4w31VS2Tj8o9C?= Content-ID: <7D9F009588FBD2448DD0895ECF0459AC@namprd11.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: IA1PR11MB6193.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 27fb952c-8109-4d78-ee2e-08db6d614c00 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Jun 2023 05:28:05.7013 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: LWnZIRhf909piUiHeJ3KAD13tBpjGQmR3nuCd/2Ty3h7SOCPFJCBRoO9nvmA9WMfY2i4ZxgQ0MTDUtYvoDsO9svoWP0ZvxMfBU/aMq2ydRQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB8211 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230614_222817_997448_889536FC X-CRM114-Status: GOOD ( 13.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 14/06/23 12:17, Claudiu Beznea - M18063 wrote: > Hi, Manikandan, > > On 13.06.2023 10:04, Manikandan Muralidharan wrote: >> From: Durai Manickam KR >> >> The register address of the XLCDC IP used in SAM9X7 are different from >> the previous HLCDC.Defining those address space with valid macros. >> >> Signed-off-by: Durai Manickam KR >> [manikandan.m@microchip.com: Remove unused macro definitions] >> Signed-off-by: Manikandan Muralidharan >> --- >> drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h | 108 +++++++++++++++++++ >> include/linux/mfd/atmel-hlcdc.h | 10 ++ >> 2 files changed, 118 insertions(+) >> >> diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h >> index 5b5c774e0edf..aed1742b3665 100644 >> --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h >> +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h >> @@ -15,6 +15,7 @@ >> >> #include >> >> +/* LCD controller common registers */ >> #define ATMEL_HLCDC_LAYER_CHER 0x0 >> #define ATMEL_HLCDC_LAYER_CHDR 0x4 >> #define ATMEL_HLCDC_LAYER_CHSR 0x8 >> @@ -128,6 +129,113 @@ >> >> #define ATMEL_HLCDC_MAX_LAYERS 6 >> >> +/* XLCDC controller specific registers */ >> +#define ATMEL_XLCDC_LAYER_ENR 0x10 >> +#define ATMEL_XLCDC_LAYER_EN BIT(0) >> + >> +#define ATMEL_XLCDC_LAYER_IER 0x0 >> +#define ATMEL_XLCDC_LAYER_IDR 0x4 >> +#define ATMEL_XLCDC_LAYER_IMR 0x8 >> +#define ATMEL_XLCDC_LAYER_ISR 0xc >> +#define ATMEL_XLCDC_LAYER_DONE_IRQ(p) BIT(0 + (8 * (p))) >> +#define ATMEL_XLCDC_LAYER_ERROR_IRQ(p) BIT(1 + (8 * (p))) >> +#define ATMEL_XLCDC_LAYER_OVR_IRQ(p) BIT(2 + (8 * (p))) >> + >> +#define ATMEL_XLCDC_LAYER_PLANE_ADDR(p) (((p) * 0x4) + 0x18) >> + >> +#define ATMEL_XLCDC_LAYER_DMA_CFG 0 >> +#define ATMEL_XLCDC_LAYER_DMA_BLEN_MASK GENMASK(6, 4) >> +#define ATMEL_XLCDC_LAYER_DMA_BLEN_SINGLE (0 << 4) >> +#define ATMEL_XLCDC_LAYER_DMA_BLEN_INCR32 (4 << 4) >> +#define ATMEL_XLCDC_LAYER_DMA_BLENCC_MASK GENMASK(10, 8) >> +#define ATMEL_XLCDC_LAYER_DMA_BLENCC_SINGLE (0 << 8) >> +#define ATMEL_XLCDC_LAYER_DMA_BLENCC_INCR4 (1 << 8) >> +#define ATMEL_XLCDC_LAYER_DMA_BLENCC_INCR8 (2 << 8) >> +#define ATMEL_XLCDC_LAYER_DMA_BLENCC_INCR16 (3 << 8) >> +#define ATMEL_XLCDC_LAYER_DMA_BLENCC_INCR32 (4 << 8) >> + >> +#define ATMEL_XLCDC_GAM BIT(2) >> + >> +#define ATMEL_XLCDC_LAYER_POS(x, y) ((x) | ((y) << 16)) >> +#define ATMEL_XLCDC_LAYER_SIZE(w, h) (((w) - 1) | (((h) - 1) << 16)) >> + >> +#define ATMEL_XLCDC_LAYER_DMA BIT(0) >> +#define ATMEL_XLCDC_LAYER_REP BIT(1) >> +#define ATMEL_XLCDC_LAYER_CRKEY BIT(2) >> +#define ATMEL_XLCDC_LAYER_DSTKEY BIT(3) >> +#define ATMEL_XLCDC_LAYER_DISCEN BIT(4) >> +#define ATMEL_XLCDC_LAYER_VIDPRI BIT(5) >> +#define ATMEL_XLCDC_LAYER_SFACTC_MASK GENMASK(8, 6) >> +#define ATMEL_XLCDC_LAYER_SFACTC_ONE (0 << 6) >> +#define ATMEL_XLCDC_LAYER_SFACTC_ZERO (1 << 6) >> +#define ATMEL_XLCDC_LAYER_SFACTC_A0 (2 << 6) >> +#define ATMEL_XLCDC_LAYER_SFACTC_A0_MULT_AD (3 << 6) >> +#define ATMEL_XLCDC_LAYER_SFACTC_A0_MULT_AS (4 << 6) >> +#define ATMEL_XLCDC_LAYER_SFACTC_M_A0_MULT_AD (5 << 6) >> +#define ATMEL_XLCDC_LAYER_SFACTA_MASK GENMASK(10, 9) >> +#define ATMEL_XLCDC_LAYER_SFACTA_ZERO (0 << 9) >> +#define ATMEL_XLCDC_LAYER_SFACTA_ONE (1 << 9) >> +#define ATMEL_XLCDC_LAYER_SFACTA_A0 (2 << 9) >> +#define ATMEL_XLCDC_LAYER_SFACTA_A1 (3 << 9) >> +#define ATMEL_XLCDC_LAYER_DFACTC_MASK GENMASK(13, 11) >> +#define ATMEL_XLCDC_LAYER_DFACTC_ZERO (0 << 11) >> +#define ATMEL_XLCDC_LAYER_DFACTC_ONE (1 << 11) >> +#define ATMEL_XLCDC_LAYER_DFACTC_A0 (2 << 11) >> +#define ATMEL_XLCDC_LAYER_DFACTC_A1 (3 << 11) >> +#define ATMEL_XLCDC_LAYER_DFACTC_A0_MULT_AD (4 << 11) >> +#define ATMEL_XLCDC_LAYER_DFACTC_M_A0_MULT_AD (5 << 11) >> +#define ATMEL_XLCDC_LAYER_DFACTC_M_A0_MULT_AS (6 << 11) >> +#define ATMEL_XLCDC_LAYER_DFACTC_M_A0 (7 << 11) >> +#define ATMEL_XLCDC_LAYER_DFACTA_MASK GENMASK(15, 14) >> +#define ATMEL_XLCDC_LAYER_DFACTA_ZERO (0 << 14) >> +#define ATMEL_XLCDC_LAYER_DFACTA_ONE (1 << 14) >> +#define ATMEL_XLCDC_LAYER_DFACTA_M_A0_MULT_AS (2 << 14) >> +#define ATMEL_XLCDC_LAYER_DFACTA_A1 (3 << 14) >> +#define ATMEL_XLCDC_LAYER_A0_SHIFT 16 >> +#define ATMEL_XLCDC_LAYER_A0_MASK \ >> + GENMASK(23, ATMEL_XLCDC_LAYER_A0_SHIFT) >> +#define ATMEL_XLCDC_LAYER_A0(x) \ >> + ((x) << ATMEL_XLCDC_LAYER_A0_SHIFT) >> +#define ATMEL_XLCDC_LAYER_A1_SHIFT 24 >> +#define ATMEL_XLCDC_LAYER_A1_MASK \ >> + GENMASK(31, ATMEL_XLCDC_LAYER_A1_SHIFT) >> +#define ATMEL_XLCDC_LAYER_A1(x) \ >> + ((x) << ATMEL_XLCDC_LAYER_A1_SHIFT) >> + >> +#define ATMEL_XLCDC_LAYER_DISC_POS(x, y) ((x) | ((y) << 16)) >> +#define ATMEL_XLCDC_LAYER_DISC_SIZE(w, h) (((w) - 1) | (((h) - 1) << 16)) >> + >> +#define ATMEL_XLCDC_LAYER_VSCALER_LUMA_ENABLE BIT(0) >> +#define ATMEL_XLCDC_LAYER_VSCALER_CHROMA_ENABLE BIT(1) >> +#define ATMEL_XLCDC_LAYER_HSCALER_LUMA_ENABLE BIT(4) >> +#define ATMEL_XLCDC_LAYER_HSCALER_CHROMA_ENABLE BIT(5) >> + >> +#define ATMEL_XLCDC_LAYER_VXSYCFG_ZERO (0 << 0) >> +#define ATMEL_XLCDC_LAYER_VXSYCFG_ONE (1 << 0) >> +#define ATMEL_XLCDC_LAYER_VXSYCFG_TWO (2 << 0) >> +#define ATMEL_XLCDC_LAYER_VXSYCFG_THREE (3 << 0) >> +#define ATMEL_XLCDC_LAYER_VXSYTAP2_ENABLE BIT(4) >> +#define ATMEL_XLCDC_LAYER_VXSYBICU_ENABLE BIT(5) >> +#define ATMEL_XLCDC_LAYER_VXSCCFG_ZERO (0 << 16) >> +#define ATMEL_XLCDC_LAYER_VXSCCFG_ONE (1 << 16) >> +#define ATMEL_XLCDC_LAYER_VXSCCFG_TWO (2 << 16) >> +#define ATMEL_XLCDC_LAYER_VXSCCFG_THREE (3 << 16) >> +#define ATMEL_XLCDC_LAYER_VXSCTAP2_ENABLE BIT(20) >> +#define ATMEL_XLCDC_LAYER_VXSCBICU_ENABLE BIT(21) >> + >> +#define ATMEL_XLCDC_LAYER_HXSYCFG_ZERO (0 << 0) >> +#define ATMEL_XLCDC_LAYER_HXSYCFG_ONE (1 << 0) >> +#define ATMEL_XLCDC_LAYER_HXSYCFG_TWO (2 << 0) >> +#define ATMEL_XLCDC_LAYER_HXSYCFG_THREE (3 << 0) >> +#define ATMEL_XLCDC_LAYER_HXSYTAP2_ENABLE BIT(4) >> +#define ATMEL_XLCDC_LAYER_HXSYBICU_ENABLE BIT(5) >> +#define ATMEL_XLCDC_LAYER_HXSCCFG_ZERO (0 << 16) >> +#define ATMEL_XLCDC_LAYER_HXSCCFG_ONE (1 << 16) >> +#define ATMEL_XLCDC_LAYER_HXSCCFG_TWO (2 << 16) >> +#define ATMEL_XLCDC_LAYER_HXSCCFG_THREE (3 << 16) >> +#define ATMEL_XLCDC_LAYER_HXSCTAP2_ENABLE BIT(20) >> +#define ATMEL_XLCDC_LAYER_HXSCBICU_ENABLE BIT(21) >> + > > There are a bunch of defines included in this file not used anywhere in the > driver. Please check and keep only necessary. They were defined as mentioned in the datasheet for future use.I will remove those that are not used for XLCDC driver code. > > Thank you, > Claudiu > >> /** >> * Atmel HLCDC Layer registers layout structure >> * >> diff --git a/include/linux/mfd/atmel-hlcdc.h b/include/linux/mfd/atmel-hlcdc.h >> index a186119a49b5..80d675a03b39 100644 >> --- a/include/linux/mfd/atmel-hlcdc.h >> +++ b/include/linux/mfd/atmel-hlcdc.h >> @@ -22,6 +22,8 @@ >> #define ATMEL_HLCDC_DITHER BIT(6) >> #define ATMEL_HLCDC_DISPDLY BIT(7) >> #define ATMEL_HLCDC_MODE_MASK GENMASK(9, 8) >> +#define ATMEL_XLCDC_MODE_MASK GENMASK(10, 8) >> +#define ATMEL_XLCDC_DPI BIT(11) >> #define ATMEL_HLCDC_PP BIT(10) >> #define ATMEL_HLCDC_VSPSU BIT(12) >> #define ATMEL_HLCDC_VSPHO BIT(13) >> @@ -34,6 +36,12 @@ >> #define ATMEL_HLCDC_IDR 0x30 >> #define ATMEL_HLCDC_IMR 0x34 >> #define ATMEL_HLCDC_ISR 0x38 >> +#define ATMEL_XLCDC_ATTRE 0x3c >> + >> +#define ATMEL_XLCDC_BASE_UPDATE BIT(0) >> +#define ATMEL_XLCDC_OVR1_UPDATE BIT(1) >> +#define ATMEL_XLCDC_OVR3_UPDATE BIT(2) >> +#define ATMEL_XLCDC_HEO_UPDATE BIT(3) >> >> #define ATMEL_HLCDC_CLKPOL BIT(0) >> #define ATMEL_HLCDC_CLKSEL BIT(2) >> @@ -48,6 +56,8 @@ >> #define ATMEL_HLCDC_DISP BIT(2) >> #define ATMEL_HLCDC_PWM BIT(3) >> #define ATMEL_HLCDC_SIP BIT(4) >> +#define ATMEL_XLCDC_SD BIT(5) >> +#define ATMEL_XLCDC_CM BIT(6) >> >> #define ATMEL_HLCDC_SOF BIT(0) >> #define ATMEL_HLCDC_SYNCDIS BIT(1) > -- Thanks and Regards, Manikandan M. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel