From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E7FEEC27C76 for ; Sat, 28 Jan 2023 10:44:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:Cc:To:From: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gs1BrHh5sVl8pJSMFoC40GTHdTvBggBVMzTIA4X8A7c=; b=0Two1l8w3GWhAc RlVocp5pL0MM/HsSXrv1JUcGwraP0yo1gO6COO/jOWiTGOFMPRuYEGqzdmyG10IG4174z7Auxnzoi U59j/+tFZPTcge0YWLBdPRDwWun+uS7Tl+BliLeXCJQ6PA4f1zExo5PfzfZ2jJahF+O0zIr6nyvFa 23ri2tlGmhEXieRMKfdkpaW6p2layBYeSpd9YttPwO0Cc0JBbgH6IAnKSnZWCnx7VLOTY/OoIgzvD OCpWtfQGINedR4wLvGyLf5RaGbyjCggqPkg9nYfYnh6a1dIlgghYUeJbHsDkpZB87NZ5oOa6HJc54 e9t+Wgna9gtONionAFrw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pLigD-0001sd-0N; Sat, 28 Jan 2023 10:43:29 +0000 Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pLigA-0001sH-JZ for linux-arm-kernel@lists.infradead.org; Sat, 28 Jan 2023 10:43:28 +0000 Received: by mail-wm1-x332.google.com with SMTP id k16so5076849wms.2 for ; Sat, 28 Jan 2023 02:43:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=qI6QvwwoMEoMGG2lrNC8roadH7Dk5Bdka3LjXTKFsas=; b=mrEMDFPeaxlF47YSoNrlv7fMopJhfQavMyDPmPwddw79+WhlV4yJI3mKXazLZtgSYT GPl2pwOoJ61egi55HunFRMZn+ALjkvLnv8vjkZHyIHoUZEZU75ts43pf387hTtPiqGzq 5RL3b8+AH/ZfoyLRlYdFK1BWYP94yB3Sg5CtSkKb7RzGWb9j3AcyxxV9r/gN2/1+geCV vg4cPQyv2yK44r+5sWO4q9RgzIzOhTtb0wFVTm7DWFopwzuNL4V7Vhy0c9grgR5y3lQm ddIeuJ5bI/y6xVT/o9cwHV/+a873lEbGmaSWZajxmfod7Z9rRbvvBMP+kPqH1vy9A2xa WhaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qI6QvwwoMEoMGG2lrNC8roadH7Dk5Bdka3LjXTKFsas=; b=deXKJ7zvoug0OxAHmgnYHlVDWu+gM7Nd4OjGcVi6W188cX9lb46ybgO5P6SsBq/0wu cg2N45KyLKR2oW9EGOR73BAeE/JrySKVi5cNm2IVq7UDte+q3eOgF8VYylwSfmmVHjv+ az8+5o0eikD3EIrwgAVxpK1mVQ84JQf6p8mGkbnaccK+OcXPJ6eHFAz9No2l6iDwzePG JAk1Q2iEEtcctCC8hhbE/4nIL84ApK6HKeGrfruXmO2T6FCB8VSs4pCsAZ/jXy2M8T2d /IE8Jmu1FJgzU1K7KRyzk8hfODHg4R98KTeqBAmxRUFv4NqVw3vPig50O2SkclxlOkgj TjXQ== X-Gm-Message-State: AFqh2kqS+4rAhesAWgDoqLFv8xkAQ5Pcnc8uAUyV7FNF/d2TtDTmESOP fH3N40GeHo10ZbMJLWORPP4rSA== X-Google-Smtp-Source: AMrXdXtFHsnvA8WGNi+nEEgZjjW5/ECaWn9n1buzthZdLLG95KFCPxPExue3RykYjGqzhrddrej9Sw== X-Received: by 2002:a05:600c:35c1:b0:3d3:5319:b6d3 with SMTP id r1-20020a05600c35c100b003d35319b6d3mr42819876wmq.38.1674902603445; Sat, 28 Jan 2023 02:43:23 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id y3-20020a1c4b03000000b003dc434b39c2sm2508838wma.26.2023.01.28.02.43.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 28 Jan 2023 02:43:22 -0800 (PST) Message-ID: <4dea3da5-54b6-bc50-a802-cb73ddccf5d8@linaro.org> Date: Sat, 28 Jan 2023 11:43:21 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH 2/9] ARM: dts: exynos: move exynos-bus nodes out of soc in Exynos5420 Content-Language: en-US From: Krzysztof Kozlowski To: Marek Szyprowski , Rob Herring , Krzysztof Kozlowski , Alim Akhtar , Kukjin Kim , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: replicant@osuosl.org, phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, =?UTF-8?Q?Martin_J=c3=bccker?= , Henrik Grimler , Chanwoo Choi References: <20230125094513.155063-1-krzysztof.kozlowski@linaro.org> <20230125094513.155063-2-krzysztof.kozlowski@linaro.org> In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230128_024326_717699_8933CAA8 X-CRM114-Status: GOOD ( 22.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 26/01/2023 11:59, Krzysztof Kozlowski wrote: > On 26/01/2023 10:47, Marek Szyprowski wrote: >> Hi Krzysztof, >> >> On 25.01.2023 10:45, Krzysztof Kozlowski wrote: >>> The soc node is supposed to have only device nodes with MMIO addresses, >>> as reported by dtc W=1: >>> >>> arch/arm/boot/dts/exynos5420.dtsi:1070.24-1075.5: >>> Warning (simple_bus_reg): /soc/bus-wcore: missing or empty reg/ranges property >>> >>> and dtbs_check: >>> >>> exynos5420-arndale-octa.dtb: soc: bus-wcore: >>> {'compatible': ['samsung,exynos-bus'], 'clocks': [[2, 769]], 'clock-names': ['bus'], 'status': ['disabled']} should not be valid under {'type': 'object'} >>> >>> Move the bus nodes and their OPP tables out of SoC to fix this. >>> Re-order them alphabetically while moving and put some of the OPP tables >>> in device nodes (if they are not shared). >>> >>> Signed-off-by: Krzysztof Kozlowski >> >> Frankly speaking I'm not very keen on moving those bus nodes out of >> /soc. Technically speaking this is definitely a part of soc and doesn't >> make much sense outside of it. IMHO they describe SoC hardware details >> and they might be moved somehow under clock controller device(s), >> although this would require some changes in the bindings and drivers. > > That's the only way to fix it without change of drivers any ABI > compatibility issue. The same we do for Qualcomm interconnects, e.g. > arch/arm64/boot/dts/qcom/sm8450.dtsi where some interconnects have some > do not have MMIO space. > > I want to achieve finally clean dtbs_check run for all Exynos sources. > The in-tree bindings already pass, so now I am fixing the ones coming > from dtschema (simple-bus.yaml in particular). > > If you have any other idea how to seamlessly clean it up, I am happy to > hear. But I guess the main problem is that no one is being paid for > doing anything for Samsung Exynos, so for free not many put much effort > into working on it. Marek, I value your feedback a lot and I appreciate your help here. Just to be clear that I am not ignoring it, little disclaimer: Unless there is a clear NAK from you or someone else, with an idea to fix or with a commitment to change driver/bindings, I am planning to grab these changes. I really want to get the dtbs_check done. With these and my other fixes, the arm64 exynos DTS pass fully all dtschema and in-kernel dtbs_check. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel