From: Stephen Boyd <sboyd@kernel.org>
To: AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Markus Schneider-Pargmann <msp@baylibre.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Michael Turquette <mturquette@baylibre.com>
Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
Markus Schneider-Pargmann <msp@baylibre.com>,
Alexandre Mergnat <amergnat@baylibre.com>
Subject: Re: [PATCH] clk: mediatek: mt8365: Fix inverted topclk operations
Date: Mon, 12 Jun 2023 18:13:10 -0700 [thread overview]
Message-ID: <4e4327afb0c71ae299e6aaaa3dffd4f9.sboyd@kernel.org> (raw)
In-Reply-To: <20230511133226.913600-1-msp@baylibre.com>
Quoting Markus Schneider-Pargmann (2023-05-11 06:32:26)
> The given operations are inverted for the wrong registers which makes
> multiple of the mt8365 hardware units unusable. In my setup at least usb
> did not work.
>
> Fixed by swapping the operations with the inverted ones.
>
> Reported-by: Alexandre Mergnat <amergnat@baylibre.com>
Checkpatch complains now that there isn't a Closes: tag here.
> Fixes: 905b7430d3cc ("clk: mediatek: mt8365: Convert simple_gate to mtk_gate clocks")
> Signed-off-by: Markus Schneider-Pargmann <msp@baylibre.com>
> ---
Applied to clk-fixes
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-06-13 1:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230511133226.913600-1-msp@baylibre.com>
[not found] ` <8603c2b2-2a5b-48f6-9b08-9b3b518b716b@gmail.com>
2023-05-15 11:49 ` [PATCH] clk: mediatek: mt8365: Fix inverted topclk operations AngeloGioacchino Del Regno
2023-05-15 14:01 ` Markus Schneider-Pargmann
2023-05-15 14:17 ` AngeloGioacchino Del Regno
2023-05-23 11:46 ` Markus Schneider-Pargmann
2023-05-26 16:45 ` Kevin Hilman
2023-06-09 18:21 ` Kevin Hilman
2023-06-13 1:11 ` Stephen Boyd
2023-06-13 15:46 ` Kevin Hilman
2023-06-13 1:13 ` Stephen Boyd [this message]
2023-06-13 8:21 ` Markus Schneider-Pargmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e4327afb0c71ae299e6aaaa3dffd4f9.sboyd@kernel.org \
--to=sboyd@kernel.org \
--cc=amergnat@baylibre.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=msp@baylibre.com \
--cc=mturquette@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).