* [PATCH 0/3] Add MT35XU01G SPI NOR flash on i.MX952-EVK board
@ 2026-01-14 6:49 Haibo Chen
2026-01-14 6:49 ` [PATCH 1/3] spi: dt-bindings: nxp,imx94-xspi: add nxp,imx952-xspi Haibo Chen
` (3 more replies)
0 siblings, 4 replies; 14+ messages in thread
From: Haibo Chen @ 2026-01-14 6:49 UTC (permalink / raw)
To: Han Xu, Mark Brown, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team,
Fabio Estevam
Cc: linux-spi, imx, devicetree, linux-arm-kernel, linux-kernel,
Haibo Chen
on i.MX952 EVK board, there is MT35XU01G SPI NOR, i.MX952 control
this nor device through XSPI controller.
Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
---
Haibo Chen (3):
spi: dt-bindings: nxp,imx94-xspi: add nxp,imx952-xspi
arm64: dts: imx952: Add xspi node
arm64: dts: imx952-evk: add MT35XU01G spi nor flash
.../devicetree/bindings/spi/nxp,imx94-xspi.yaml | 4 +++
arch/arm64/boot/dts/freescale/imx952-evk.dts | 41 ++++++++++++++++++++++
arch/arm64/boot/dts/freescale/imx952.dtsi | 19 ++++++++++
3 files changed, 64 insertions(+)
---
base-commit: 0f853ca2a798ead9d24d39cad99b0966815c582a
change-id: 20260114-xspi-imx952-07449aed6ba8
Best regards,
--
Haibo Chen <haibo.chen@nxp.com>
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 1/3] spi: dt-bindings: nxp,imx94-xspi: add nxp,imx952-xspi
2026-01-14 6:49 [PATCH 0/3] Add MT35XU01G SPI NOR flash on i.MX952-EVK board Haibo Chen
@ 2026-01-14 6:49 ` Haibo Chen
2026-01-15 9:39 ` Krzysztof Kozlowski
2026-01-15 20:55 ` Krzysztof Kozlowski
2026-01-14 6:49 ` [PATCH 2/3] arm64: dts: imx952: Add xspi node Haibo Chen
` (2 subsequent siblings)
3 siblings, 2 replies; 14+ messages in thread
From: Haibo Chen @ 2026-01-14 6:49 UTC (permalink / raw)
To: Han Xu, Mark Brown, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team,
Fabio Estevam
Cc: linux-spi, imx, devicetree, linux-arm-kernel, linux-kernel,
Haibo Chen
Document i.MX952 XSPI compatible, which is derived from
i.MX94 XSPI.
Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
---
Documentation/devicetree/bindings/spi/nxp,imx94-xspi.yaml | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/Documentation/devicetree/bindings/spi/nxp,imx94-xspi.yaml b/Documentation/devicetree/bindings/spi/nxp,imx94-xspi.yaml
index a0f4b162c85855c55d06c6ea1a2417af5121fab2..16a0598c6d033554ce5a42a13a3265315a16992e 100644
--- a/Documentation/devicetree/bindings/spi/nxp,imx94-xspi.yaml
+++ b/Documentation/devicetree/bindings/spi/nxp,imx94-xspi.yaml
@@ -15,6 +15,10 @@ properties:
oneOf:
- enum:
- nxp,imx94-xspi
+ - items:
+ - enum:
+ - nxp,imx952-xspi
+ - const: nxp,imx94-xspi
reg:
items:
--
2.34.1
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 2/3] arm64: dts: imx952: Add xspi node
2026-01-14 6:49 [PATCH 0/3] Add MT35XU01G SPI NOR flash on i.MX952-EVK board Haibo Chen
2026-01-14 6:49 ` [PATCH 1/3] spi: dt-bindings: nxp,imx94-xspi: add nxp,imx952-xspi Haibo Chen
@ 2026-01-14 6:49 ` Haibo Chen
2026-01-14 6:49 ` [PATCH 3/3] arm64: dts: imx952-evk: add MT35XU01G spi nor flash Haibo Chen
2026-01-20 17:58 ` (subset) [PATCH 0/3] Add MT35XU01G SPI NOR flash on i.MX952-EVK board Mark Brown
3 siblings, 0 replies; 14+ messages in thread
From: Haibo Chen @ 2026-01-14 6:49 UTC (permalink / raw)
To: Han Xu, Mark Brown, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team,
Fabio Estevam
Cc: linux-spi, imx, devicetree, linux-arm-kernel, linux-kernel,
Haibo Chen
Add xspi node for i.MX952
Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
---
arch/arm64/boot/dts/freescale/imx952.dtsi | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/imx952.dtsi b/arch/arm64/boot/dts/freescale/imx952.dtsi
index 33bde271d394d19407562f2a427a8a84b85bd679..0642de798973dc61246e4728235772f7c005ee98 100644
--- a/arch/arm64/boot/dts/freescale/imx952.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx952.dtsi
@@ -654,6 +654,25 @@ mu8: mailbox@42350000 {
#mbox-cells = <2>;
status = "disabled";
};
+
+ xspi1: spi@42400000 {
+ compatible = "nxp,imx952-xspi", "nxp,imx94-xspi";
+ reg = <0x42400000 0x50000>, <0x28000000 0x8000000>;
+ reg-names = "base", "mmap";
+ interrupts = <GIC_SPI 400 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 401 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 402 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 403 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 404 IRQ_TYPE_LEVEL_HIGH>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ clocks = <&scmi_clk IMX952_CLK_XSPI1>;
+ clock-names = "per";
+ assigned-clocks = <&scmi_clk IMX952_CLK_XSPI1>;
+ assigned-clock-parents = <&scmi_clk IMX952_CLK_SYSPLL1_PFD1>;
+ assigned-clock-rates = <200000000>;
+ status = "disabled";
+ };
};
aips3: bus@42800000 {
--
2.34.1
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 3/3] arm64: dts: imx952-evk: add MT35XU01G spi nor flash
2026-01-14 6:49 [PATCH 0/3] Add MT35XU01G SPI NOR flash on i.MX952-EVK board Haibo Chen
2026-01-14 6:49 ` [PATCH 1/3] spi: dt-bindings: nxp,imx94-xspi: add nxp,imx952-xspi Haibo Chen
2026-01-14 6:49 ` [PATCH 2/3] arm64: dts: imx952: Add xspi node Haibo Chen
@ 2026-01-14 6:49 ` Haibo Chen
2026-01-14 16:43 ` Han Xu
2026-02-24 15:05 ` Frank Li
2026-01-20 17:58 ` (subset) [PATCH 0/3] Add MT35XU01G SPI NOR flash on i.MX952-EVK board Mark Brown
3 siblings, 2 replies; 14+ messages in thread
From: Haibo Chen @ 2026-01-14 6:49 UTC (permalink / raw)
To: Han Xu, Mark Brown, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team,
Fabio Estevam
Cc: linux-spi, imx, devicetree, linux-arm-kernel, linux-kernel,
Haibo Chen
Add spi nor flash MT35XU01G support, it support OCT DTR mode
at 200MHz.
Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
---
arch/arm64/boot/dts/freescale/imx952-evk.dts | 41 ++++++++++++++++++++++++++++
1 file changed, 41 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/imx952-evk.dts b/arch/arm64/boot/dts/freescale/imx952-evk.dts
index 2c753fcbae3c5d545f5d835bd70492667061d626..534c93e527d0f3fb14ff3f21114993aae1d88a88 100644
--- a/arch/arm64/boot/dts/freescale/imx952-evk.dts
+++ b/arch/arm64/boot/dts/freescale/imx952-evk.dts
@@ -111,6 +111,25 @@ &usdhc2 {
status = "okay";
};
+&xspi1 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_xspi1>;
+ status = "okay";
+
+ mt35xu01gbba: flash@0 {
+ compatible = "jedec,spi-nor";
+ reg = <0>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_xspi1_reset>;
+ reset-gpios = <&gpio5 11 GPIO_ACTIVE_LOW>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+ spi-max-frequency = <200000000>;
+ spi-tx-bus-width = <8>;
+ spi-rx-bus-width = <8>;
+ };
+};
+
&scmi_iomuxc {
pinctrl_reg_usdhc2_vmmc: regusdhc2vmmcgrp {
fsl,pins = <
@@ -214,4 +233,26 @@ pinctrl_usdhc2_gpio: usdhc2gpiogrp {
IMX952_PAD_SD2_CD_B__WAKEUPMIX_TOP_GPIO3_IO_0 0x31e
>;
};
+
+ pinctrl_xspi1: xspi1grp {
+ fsl,pins = <
+ IMX952_PAD_XSPI1_DATA0__WAKEUPMIX_TOP_XSPI1_A_DATA_0 0x39e
+ IMX952_PAD_XSPI1_DATA1__WAKEUPMIX_TOP_XSPI1_A_DATA_1 0x39e
+ IMX952_PAD_XSPI1_DATA2__WAKEUPMIX_TOP_XSPI1_A_DATA_2 0x39e
+ IMX952_PAD_XSPI1_DATA3__WAKEUPMIX_TOP_XSPI1_A_DATA_3 0x39e
+ IMX952_PAD_XSPI1_DATA4__WAKEUPMIX_TOP_XSPI1_A_DATA_4 0x39e
+ IMX952_PAD_XSPI1_DATA5__WAKEUPMIX_TOP_XSPI1_A_DATA_5 0x39e
+ IMX952_PAD_XSPI1_DATA6__WAKEUPMIX_TOP_XSPI1_A_DATA_6 0x39e
+ IMX952_PAD_XSPI1_DATA7__WAKEUPMIX_TOP_XSPI1_A_DATA_7 0x39e
+ IMX952_PAD_XSPI1_DQS__WAKEUPMIX_TOP_XSPI1_A_DQS 0x39e
+ IMX952_PAD_XSPI1_SCLK__WAKEUPMIX_TOP_XSPI1_A_SCLK 0x39e
+ IMX952_PAD_XSPI1_SS0_B__WAKEUPMIX_TOP_XSPI1_A_SS0_B 0x39e
+ >;
+ };
+
+ pinctrl_xspi1_reset: xspi1-reset-grp {
+ fsl,pins = <
+ IMX952_PAD_XSPI1_SS1_B__WAKEUPMIX_TOP_GPIO5_IO_11 0x39e
+ >;
+ };
};
--
2.34.1
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH 3/3] arm64: dts: imx952-evk: add MT35XU01G spi nor flash
2026-01-14 6:49 ` [PATCH 3/3] arm64: dts: imx952-evk: add MT35XU01G spi nor flash Haibo Chen
@ 2026-01-14 16:43 ` Han Xu
2026-02-24 15:05 ` Frank Li
1 sibling, 0 replies; 14+ messages in thread
From: Han Xu @ 2026-01-14 16:43 UTC (permalink / raw)
To: Haibo Chen
Cc: Mark Brown, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
linux-spi, imx, devicetree, linux-arm-kernel, linux-kernel
On 26/01/14 02:49PM, Haibo Chen wrote:
> Add spi nor flash MT35XU01G support, it support OCT DTR mode
> at 200MHz.
>
> Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
Reviewed-by: Han Xu <han.xu@nxp.com>
> ---
> arch/arm64/boot/dts/freescale/imx952-evk.dts | 41 ++++++++++++++++++++++++++++
> 1 file changed, 41 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx952-evk.dts b/arch/arm64/boot/dts/freescale/imx952-evk.dts
> index 2c753fcbae3c5d545f5d835bd70492667061d626..534c93e527d0f3fb14ff3f21114993aae1d88a88 100644
> --- a/arch/arm64/boot/dts/freescale/imx952-evk.dts
> +++ b/arch/arm64/boot/dts/freescale/imx952-evk.dts
> @@ -111,6 +111,25 @@ &usdhc2 {
> status = "okay";
> };
>
> +&xspi1 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_xspi1>;
> + status = "okay";
> +
> + mt35xu01gbba: flash@0 {
> + compatible = "jedec,spi-nor";
> + reg = <0>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_xspi1_reset>;
> + reset-gpios = <&gpio5 11 GPIO_ACTIVE_LOW>;
> + #address-cells = <1>;
> + #size-cells = <1>;
> + spi-max-frequency = <200000000>;
> + spi-tx-bus-width = <8>;
> + spi-rx-bus-width = <8>;
> + };
> +};
> +
> &scmi_iomuxc {
> pinctrl_reg_usdhc2_vmmc: regusdhc2vmmcgrp {
> fsl,pins = <
> @@ -214,4 +233,26 @@ pinctrl_usdhc2_gpio: usdhc2gpiogrp {
> IMX952_PAD_SD2_CD_B__WAKEUPMIX_TOP_GPIO3_IO_0 0x31e
> >;
> };
> +
> + pinctrl_xspi1: xspi1grp {
> + fsl,pins = <
> + IMX952_PAD_XSPI1_DATA0__WAKEUPMIX_TOP_XSPI1_A_DATA_0 0x39e
> + IMX952_PAD_XSPI1_DATA1__WAKEUPMIX_TOP_XSPI1_A_DATA_1 0x39e
> + IMX952_PAD_XSPI1_DATA2__WAKEUPMIX_TOP_XSPI1_A_DATA_2 0x39e
> + IMX952_PAD_XSPI1_DATA3__WAKEUPMIX_TOP_XSPI1_A_DATA_3 0x39e
> + IMX952_PAD_XSPI1_DATA4__WAKEUPMIX_TOP_XSPI1_A_DATA_4 0x39e
> + IMX952_PAD_XSPI1_DATA5__WAKEUPMIX_TOP_XSPI1_A_DATA_5 0x39e
> + IMX952_PAD_XSPI1_DATA6__WAKEUPMIX_TOP_XSPI1_A_DATA_6 0x39e
> + IMX952_PAD_XSPI1_DATA7__WAKEUPMIX_TOP_XSPI1_A_DATA_7 0x39e
> + IMX952_PAD_XSPI1_DQS__WAKEUPMIX_TOP_XSPI1_A_DQS 0x39e
> + IMX952_PAD_XSPI1_SCLK__WAKEUPMIX_TOP_XSPI1_A_SCLK 0x39e
> + IMX952_PAD_XSPI1_SS0_B__WAKEUPMIX_TOP_XSPI1_A_SS0_B 0x39e
> + >;
> + };
> +
> + pinctrl_xspi1_reset: xspi1-reset-grp {
> + fsl,pins = <
> + IMX952_PAD_XSPI1_SS1_B__WAKEUPMIX_TOP_GPIO5_IO_11 0x39e
> + >;
> + };
> };
>
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/3] spi: dt-bindings: nxp,imx94-xspi: add nxp,imx952-xspi
2026-01-14 6:49 ` [PATCH 1/3] spi: dt-bindings: nxp,imx94-xspi: add nxp,imx952-xspi Haibo Chen
@ 2026-01-15 9:39 ` Krzysztof Kozlowski
2026-01-15 11:51 ` Bough Chen
2026-01-15 15:15 ` Frank Li
2026-01-15 20:55 ` Krzysztof Kozlowski
1 sibling, 2 replies; 14+ messages in thread
From: Krzysztof Kozlowski @ 2026-01-15 9:39 UTC (permalink / raw)
To: Haibo Chen
Cc: Han Xu, Mark Brown, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team,
Fabio Estevam, linux-spi, imx, devicetree, linux-arm-kernel,
linux-kernel
On Wed, Jan 14, 2026 at 02:49:45PM +0800, Haibo Chen wrote:
> Document i.MX952 XSPI compatible, which is derived from
> i.MX94 XSPI.
>
> Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
> ---
> Documentation/devicetree/bindings/spi/nxp,imx94-xspi.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/spi/nxp,imx94-xspi.yaml b/Documentation/devicetree/bindings/spi/nxp,imx94-xspi.yaml
> index a0f4b162c85855c55d06c6ea1a2417af5121fab2..16a0598c6d033554ce5a42a13a3265315a16992e 100644
> --- a/Documentation/devicetree/bindings/spi/nxp,imx94-xspi.yaml
> +++ b/Documentation/devicetree/bindings/spi/nxp,imx94-xspi.yaml
> @@ -15,6 +15,10 @@ properties:
> oneOf:
> - enum:
> - nxp,imx94-xspi
> + - items:
> + - enum:
> + - nxp,imx952-xspi
> + - const: nxp,imx94-xspi
You never checked your DTS and broke all existing users. And existing
tools would clearly tell you that if you tried.
Use tools instead of reviewers. Reviewers time is more important, so if
you just disregard it I find it quite disrespectful.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 14+ messages in thread
* RE: [PATCH 1/3] spi: dt-bindings: nxp,imx94-xspi: add nxp,imx952-xspi
2026-01-15 9:39 ` Krzysztof Kozlowski
@ 2026-01-15 11:51 ` Bough Chen
2026-01-15 15:15 ` Frank Li
1 sibling, 0 replies; 14+ messages in thread
From: Bough Chen @ 2026-01-15 11:51 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Han Xu, Mark Brown, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team,
Fabio Estevam, linux-spi@vger.kernel.org, imx@lists.linux.dev,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@kernel.org>
> Sent: 2026年1月15日 17:39
> To: Bough Chen <haibo.chen@nxp.com>
> Cc: Han Xu <han.xu@nxp.com>; Mark Brown <broonie@kernel.org>; Rob
> Herring <robh@kernel.org>; Krzysztof Kozlowski <krzk+dt@kernel.org>; Conor
> Dooley <conor+dt@kernel.org>; Shawn Guo <shawnguo@kernel.org>; Sascha
> Hauer <s.hauer@pengutronix.de>; Pengutronix Kernel Team
> <kernel@pengutronix.de>; Fabio Estevam <festevam@gmail.com>;
> linux-spi@vger.kernel.org; imx@lists.linux.dev; devicetree@vger.kernel.org;
> linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH 1/3] spi: dt-bindings: nxp,imx94-xspi: add nxp,imx952-xspi
>
> On Wed, Jan 14, 2026 at 02:49:45PM +0800, Haibo Chen wrote:
> > Document i.MX952 XSPI compatible, which is derived from
> > i.MX94 XSPI.
> >
> > Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
> > ---
> > Documentation/devicetree/bindings/spi/nxp,imx94-xspi.yaml | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/spi/nxp,imx94-xspi.yaml
> > b/Documentation/devicetree/bindings/spi/nxp,imx94-xspi.yaml
> > index
> >
> a0f4b162c85855c55d06c6ea1a2417af5121fab2..16a0598c6d033554ce5a42a13
> a32
> > 65315a16992e 100644
> > --- a/Documentation/devicetree/bindings/spi/nxp,imx94-xspi.yaml
> > +++ b/Documentation/devicetree/bindings/spi/nxp,imx94-xspi.yaml
> > @@ -15,6 +15,10 @@ properties:
> > oneOf:
> > - enum:
> > - nxp,imx94-xspi
> > + - items:
> > + - enum:
> > + - nxp,imx952-xspi
> > + - const: nxp,imx94-xspi
>
> You never checked your DTS and broke all existing users. And existing tools
> would clearly tell you that if you tried.
>
> Use tools instead of reviewers. Reviewers time is more important, so if you just
> disregard it I find it quite disrespectful.
Hi Krzysztof,
I did run dt binding check before I send out this patch.
I list the log in the following, no error report.
Can you help point out where I have to improve?
nxa12937@shlinux89:~/linux-next$ make64 distclean
CLEAN Documentation/devicetree/bindings
CLEAN scripts/basic
CLEAN scripts/dtc
CLEAN scripts/kconfig
CLEAN include/config include/generated .config
nxa12937@shlinux89:~/linux-next$ make64 dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/spi/nxp,imx94-xspi.yaml
SCHEMA Documentation/devicetree/bindings/processed-schema.json
HOSTCC scripts/basic/fixdep
HOSTCC scripts/dtc/dtc.o
HOSTCC scripts/dtc/flattree.o
HOSTCC scripts/dtc/fstree.o
HOSTCC scripts/dtc/data.o
HOSTCC scripts/dtc/livetree.o
HOSTCC scripts/dtc/treesource.o
HOSTCC scripts/dtc/srcpos.o
HOSTCC scripts/dtc/checks.o
HOSTCC scripts/dtc/util.o
LEX scripts/dtc/dtc-lexer.lex.c
YACC scripts/dtc/dtc-parser.tab.[ch]
HOSTCC scripts/dtc/dtc-lexer.lex.o
HOSTCC scripts/dtc/dtc-parser.tab.o
HOSTLD scripts/dtc/dtc
CHKDT ./Documentation/devicetree/bindings
LINT ./Documentation/devicetree/bindings
DTEX Documentation/devicetree/bindings/spi/nxp,imx94-xspi.example.dts
DTC [C] Documentation/devicetree/bindings/spi/nxp,imx94-xspi.example.dtb
Regards
Haibo Chen
>
> Best regards,
> Krzysztof
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/3] spi: dt-bindings: nxp,imx94-xspi: add nxp,imx952-xspi
2026-01-15 9:39 ` Krzysztof Kozlowski
2026-01-15 11:51 ` Bough Chen
@ 2026-01-15 15:15 ` Frank Li
2026-01-15 20:55 ` Krzysztof Kozlowski
1 sibling, 1 reply; 14+ messages in thread
From: Frank Li @ 2026-01-15 15:15 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Haibo Chen, Han Xu, Mark Brown, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team,
Fabio Estevam, linux-spi, imx, devicetree, linux-arm-kernel,
linux-kernel
On Thu, Jan 15, 2026 at 10:39:20AM +0100, Krzysztof Kozlowski wrote:
> On Wed, Jan 14, 2026 at 02:49:45PM +0800, Haibo Chen wrote:
> > Document i.MX952 XSPI compatible, which is derived from
> > i.MX94 XSPI.
> >
> > Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
> > ---
> > Documentation/devicetree/bindings/spi/nxp,imx94-xspi.yaml | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/spi/nxp,imx94-xspi.yaml b/Documentation/devicetree/bindings/spi/nxp,imx94-xspi.yaml
> > index a0f4b162c85855c55d06c6ea1a2417af5121fab2..16a0598c6d033554ce5a42a13a3265315a16992e 100644
> > --- a/Documentation/devicetree/bindings/spi/nxp,imx94-xspi.yaml
> > +++ b/Documentation/devicetree/bindings/spi/nxp,imx94-xspi.yaml
> > @@ -15,6 +15,10 @@ properties:
> > oneOf:
> > - enum:
> > - nxp,imx94-xspi
> > + - items:
> > + - enum:
> > + - nxp,imx952-xspi
> > + - const: nxp,imx94-xspi
>
> You never checked your DTS and broke all existing users. And existing
> tools would clearly tell you that if you tried.
Krzysztof:
what's wrong?
I have not find any warnings under arch/arm64/boot/dts/freescale by
make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- -j8 CHECK_DTBS=y dtbs
Frank
>
> Use tools instead of reviewers. Reviewers time is more important, so if
> you just disregard it I find it quite disrespectful.
>
> Best regards,
> Krzysztof
>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/3] spi: dt-bindings: nxp,imx94-xspi: add nxp,imx952-xspi
2026-01-15 15:15 ` Frank Li
@ 2026-01-15 20:55 ` Krzysztof Kozlowski
0 siblings, 0 replies; 14+ messages in thread
From: Krzysztof Kozlowski @ 2026-01-15 20:55 UTC (permalink / raw)
To: Frank Li
Cc: Haibo Chen, Han Xu, Mark Brown, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team,
Fabio Estevam, linux-spi, imx, devicetree, linux-arm-kernel,
linux-kernel
On 15/01/2026 16:15, Frank Li wrote:
> On Thu, Jan 15, 2026 at 10:39:20AM +0100, Krzysztof Kozlowski wrote:
>> On Wed, Jan 14, 2026 at 02:49:45PM +0800, Haibo Chen wrote:
>>> Document i.MX952 XSPI compatible, which is derived from
>>> i.MX94 XSPI.
>>>
>>> Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
>>> ---
>>> Documentation/devicetree/bindings/spi/nxp,imx94-xspi.yaml | 4 ++++
>>> 1 file changed, 4 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/spi/nxp,imx94-xspi.yaml b/Documentation/devicetree/bindings/spi/nxp,imx94-xspi.yaml
>>> index a0f4b162c85855c55d06c6ea1a2417af5121fab2..16a0598c6d033554ce5a42a13a3265315a16992e 100644
>>> --- a/Documentation/devicetree/bindings/spi/nxp,imx94-xspi.yaml
>>> +++ b/Documentation/devicetree/bindings/spi/nxp,imx94-xspi.yaml
>>> @@ -15,6 +15,10 @@ properties:
>>> oneOf:
>>> - enum:
>>> - nxp,imx94-xspi
>>> + - items:
>>> + - enum:
>>> + - nxp,imx952-xspi
>>> + - const: nxp,imx94-xspi
>>
>> You never checked your DTS and broke all existing users. And existing
>> tools would clearly tell you that if you tried.
>
> Krzysztof:
>
> what's wrong?
>
> I have not find any warnings under arch/arm64/boot/dts/freescale by
>
> make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- -j8 CHECK_DTBS=y dtbs
I misread the diff context and patch is obviously fine. Thanks for
correcting me.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/3] spi: dt-bindings: nxp,imx94-xspi: add nxp,imx952-xspi
2026-01-14 6:49 ` [PATCH 1/3] spi: dt-bindings: nxp,imx94-xspi: add nxp,imx952-xspi Haibo Chen
2026-01-15 9:39 ` Krzysztof Kozlowski
@ 2026-01-15 20:55 ` Krzysztof Kozlowski
2026-01-15 21:07 ` Frank Li
1 sibling, 1 reply; 14+ messages in thread
From: Krzysztof Kozlowski @ 2026-01-15 20:55 UTC (permalink / raw)
To: Haibo Chen, Han Xu, Mark Brown, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team,
Fabio Estevam
Cc: linux-spi, imx, devicetree, linux-arm-kernel, linux-kernel
On 14/01/2026 07:49, Haibo Chen wrote:
> Document i.MX952 XSPI compatible, which is derived from
> i.MX94 XSPI.
>
> Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
> ---
> Documentation/devicetree/bindings/spi/nxp,imx94-xspi.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/3] spi: dt-bindings: nxp,imx94-xspi: add nxp,imx952-xspi
2026-01-15 20:55 ` Krzysztof Kozlowski
@ 2026-01-15 21:07 ` Frank Li
2026-02-08 10:24 ` Krzysztof Kozlowski
0 siblings, 1 reply; 14+ messages in thread
From: Frank Li @ 2026-01-15 21:07 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Haibo Chen, Han Xu, Mark Brown, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team,
Fabio Estevam, linux-spi, imx, devicetree, linux-arm-kernel,
linux-kernel
On Thu, Jan 15, 2026 at 09:55:57PM +0100, Krzysztof Kozlowski wrote:
> On 14/01/2026 07:49, Haibo Chen wrote:
> > Document i.MX952 XSPI compatible, which is derived from
> > i.MX94 XSPI.
> >
> > Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
> > ---
> > Documentation/devicetree/bindings/spi/nxp,imx94-xspi.yaml | 4 ++++
> > 1 file changed, 4 insertions(+)
>
Krzysztof:
You sent an empty message here.
Frank
>
>
> Best regards,
> Krzysztof
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: (subset) [PATCH 0/3] Add MT35XU01G SPI NOR flash on i.MX952-EVK board
2026-01-14 6:49 [PATCH 0/3] Add MT35XU01G SPI NOR flash on i.MX952-EVK board Haibo Chen
` (2 preceding siblings ...)
2026-01-14 6:49 ` [PATCH 3/3] arm64: dts: imx952-evk: add MT35XU01G spi nor flash Haibo Chen
@ 2026-01-20 17:58 ` Mark Brown
3 siblings, 0 replies; 14+ messages in thread
From: Mark Brown @ 2026-01-20 17:58 UTC (permalink / raw)
To: Han Xu, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shawn Guo,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam, Haibo Chen
Cc: linux-spi, imx, devicetree, linux-arm-kernel, linux-kernel
On Wed, 14 Jan 2026 14:49:44 +0800, Haibo Chen wrote:
> on i.MX952 EVK board, there is MT35XU01G SPI NOR, i.MX952 control
> this nor device through XSPI controller.
>
>
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
Thanks!
[1/3] spi: dt-bindings: nxp,imx94-xspi: add nxp,imx952-xspi
commit: 3495a5df94a9ad7a8940bcb3ebfda58255f5b952
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/3] spi: dt-bindings: nxp,imx94-xspi: add nxp,imx952-xspi
2026-01-15 21:07 ` Frank Li
@ 2026-02-08 10:24 ` Krzysztof Kozlowski
0 siblings, 0 replies; 14+ messages in thread
From: Krzysztof Kozlowski @ 2026-02-08 10:24 UTC (permalink / raw)
To: Frank Li
Cc: Haibo Chen, Han Xu, Mark Brown, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team,
Fabio Estevam, linux-spi, imx, devicetree, linux-arm-kernel,
linux-kernel
On 15/01/2026 22:07, Frank Li wrote:
> On Thu, Jan 15, 2026 at 09:55:57PM +0100, Krzysztof Kozlowski wrote:
>> On 14/01/2026 07:49, Haibo Chen wrote:
>>> Document i.MX952 XSPI compatible, which is derived from
>>> i.MX94 XSPI.
>>>
>>> Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
>>> ---
>>> Documentation/devicetree/bindings/spi/nxp,imx94-xspi.yaml | 4 ++++
>>> 1 file changed, 4 insertions(+)
>>
>
> Krzysztof:
>
> You sent an empty message here.
>
> Frank
>>
Thanks, second try:
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 3/3] arm64: dts: imx952-evk: add MT35XU01G spi nor flash
2026-01-14 6:49 ` [PATCH 3/3] arm64: dts: imx952-evk: add MT35XU01G spi nor flash Haibo Chen
2026-01-14 16:43 ` Han Xu
@ 2026-02-24 15:05 ` Frank Li
1 sibling, 0 replies; 14+ messages in thread
From: Frank Li @ 2026-02-24 15:05 UTC (permalink / raw)
To: Haibo Chen
Cc: Han Xu, Mark Brown, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team,
Fabio Estevam, linux-spi, imx, devicetree, linux-arm-kernel,
linux-kernel
On Wed, Jan 14, 2026 at 02:49:47PM +0800, Haibo Chen wrote:
> Add spi nor flash MT35XU01G support, it support OCT DTR mode
> at 200MHz.
>
> Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
> ---
> arch/arm64/boot/dts/freescale/imx952-evk.dts | 41 ++++++++++++++++++++++++++++
> 1 file changed, 41 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx952-evk.dts b/arch/arm64/boot/dts/freescale/imx952-evk.dts
> index 2c753fcbae3c5d545f5d835bd70492667061d626..534c93e527d0f3fb14ff3f21114993aae1d88a88 100644
> --- a/arch/arm64/boot/dts/freescale/imx952-evk.dts
> +++ b/arch/arm64/boot/dts/freescale/imx952-evk.dts
> @@ -111,6 +111,25 @@ &usdhc2 {
> status = "okay";
> };
>
> +&xspi1 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_xspi1>;
> + status = "okay";
> +
> + mt35xu01gbba: flash@0 {
> + compatible = "jedec,spi-nor";
> + reg = <0>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_xspi1_reset>;
> + reset-gpios = <&gpio5 11 GPIO_ACTIVE_LOW>;
> + #address-cells = <1>;
> + #size-cells = <1>;
> + spi-max-frequency = <200000000>;
> + spi-tx-bus-width = <8>;
> + spi-rx-bus-width = <8>;
> + };
> +};
> +
Can't apply, please rebase.
And move &xspi1 after &scmi_iomuxc to keep alphabet order
Frank
> &scmi_iomuxc {
> pinctrl_reg_usdhc2_vmmc: regusdhc2vmmcgrp {
> fsl,pins = <
> @@ -214,4 +233,26 @@ pinctrl_usdhc2_gpio: usdhc2gpiogrp {
> IMX952_PAD_SD2_CD_B__WAKEUPMIX_TOP_GPIO3_IO_0 0x31e
> >;
> };
> +
> + pinctrl_xspi1: xspi1grp {
> + fsl,pins = <
> + IMX952_PAD_XSPI1_DATA0__WAKEUPMIX_TOP_XSPI1_A_DATA_0 0x39e
> + IMX952_PAD_XSPI1_DATA1__WAKEUPMIX_TOP_XSPI1_A_DATA_1 0x39e
> + IMX952_PAD_XSPI1_DATA2__WAKEUPMIX_TOP_XSPI1_A_DATA_2 0x39e
> + IMX952_PAD_XSPI1_DATA3__WAKEUPMIX_TOP_XSPI1_A_DATA_3 0x39e
> + IMX952_PAD_XSPI1_DATA4__WAKEUPMIX_TOP_XSPI1_A_DATA_4 0x39e
> + IMX952_PAD_XSPI1_DATA5__WAKEUPMIX_TOP_XSPI1_A_DATA_5 0x39e
> + IMX952_PAD_XSPI1_DATA6__WAKEUPMIX_TOP_XSPI1_A_DATA_6 0x39e
> + IMX952_PAD_XSPI1_DATA7__WAKEUPMIX_TOP_XSPI1_A_DATA_7 0x39e
> + IMX952_PAD_XSPI1_DQS__WAKEUPMIX_TOP_XSPI1_A_DQS 0x39e
> + IMX952_PAD_XSPI1_SCLK__WAKEUPMIX_TOP_XSPI1_A_SCLK 0x39e
> + IMX952_PAD_XSPI1_SS0_B__WAKEUPMIX_TOP_XSPI1_A_SS0_B 0x39e
> + >;
> + };
> +
> + pinctrl_xspi1_reset: xspi1-reset-grp {
> + fsl,pins = <
> + IMX952_PAD_XSPI1_SS1_B__WAKEUPMIX_TOP_GPIO5_IO_11 0x39e
> + >;
> + };
> };
>
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2026-02-24 15:05 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-14 6:49 [PATCH 0/3] Add MT35XU01G SPI NOR flash on i.MX952-EVK board Haibo Chen
2026-01-14 6:49 ` [PATCH 1/3] spi: dt-bindings: nxp,imx94-xspi: add nxp,imx952-xspi Haibo Chen
2026-01-15 9:39 ` Krzysztof Kozlowski
2026-01-15 11:51 ` Bough Chen
2026-01-15 15:15 ` Frank Li
2026-01-15 20:55 ` Krzysztof Kozlowski
2026-01-15 20:55 ` Krzysztof Kozlowski
2026-01-15 21:07 ` Frank Li
2026-02-08 10:24 ` Krzysztof Kozlowski
2026-01-14 6:49 ` [PATCH 2/3] arm64: dts: imx952: Add xspi node Haibo Chen
2026-01-14 6:49 ` [PATCH 3/3] arm64: dts: imx952-evk: add MT35XU01G spi nor flash Haibo Chen
2026-01-14 16:43 ` Han Xu
2026-02-24 15:05 ` Frank Li
2026-01-20 17:58 ` (subset) [PATCH 0/3] Add MT35XU01G SPI NOR flash on i.MX952-EVK board Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox