From: Krzysztof Kozlowski <krzk@kernel.org>
To: Peter Chen <peter.chen@cixtech.com>, arnd@arndb.de
Cc: krzysztof.kozlowski@oss.qualcomm.com, geert+renesas@glider.be,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
cix-kernel-upstream@cixtech.com, Yunseong Kim <ysk@kzalloc.com>
Subject: Re: [PATCH v3 1/1] arm64: defconfig: Enable CIX Sky1 pinctrl, PCIe host, and Cadence GPIO
Date: Thu, 21 May 2026 17:23:41 +0200 [thread overview]
Message-ID: <4ea63bf6-d9ec-483d-a9c4-9715ec5547bc@kernel.org> (raw)
In-Reply-To: <20260327114628.3800886-1-peter.chen@cixtech.com>
On 27/03/2026 12:46, Peter Chen wrote:
> Enable the CIX Sky1 pinctrl driver (PINCTRL_SKY1), CIX Sky1 PCIe host
> controller (PCI_SKY1_HOST), and Cadence GPIO controller (GPIO_CADENCE)
> for the Radxa Orion O6 board which uses the CIX Sky1 SoC.
>
> The pinctrl driver is a dependency for other on-SoC peripherals. The
> Cadence-based PCIe host controller enables use of PCIe peripherals on
> the board. The Cadence GPIO controller provides GPIO support for the
> SoC.
>
> Cc: Yunseong Kim <ysk@kzalloc.com>
> Signed-off-by: Peter Chen <peter.chen@cixtech.com>
> ---
> Changes for v3:
> - Use specific driver names (CIX Sky1 pinctrl, CIX Sky1 PCIe host
> controller, Cadence GPIO) in subject and commit message instead of
> generic terms.
> - Remove external Debian bug reference; explain rationale directly.
> - Remove NVMe mention since only PCIe host controller is enabled.
>
> Changes for v2:
> - Delete CIX HDA configurations due to it is not used at current
> Orion O6 board device tree.
>
> arch/arm64/configs/defconfig | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index b67d5b1fc45b..f9be52484008 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -241,6 +241,7 @@ CONFIG_PCIE_XILINX_DMA_PL=y
> CONFIG_PCIE_XILINX_NWL=y
> CONFIG_PCIE_XILINX_CPM=y
> CONFIG_PCI_J721E_HOST=m
> +CONFIG_PCI_SKY1_HOST=m
This is not correctly placed and caused issues later - conflicts with my
cleanup patch.
Please fix it up before you send the patch to soc@.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-05-21 15:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-27 11:46 [PATCH v3 1/1] arm64: defconfig: Enable CIX Sky1 pinctrl, PCIe host, and Cadence GPIO Peter Chen
2026-03-30 7:56 ` Krzysztof Kozlowski
2026-05-21 15:23 ` Krzysztof Kozlowski [this message]
2026-05-21 15:46 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ea63bf6-d9ec-483d-a9c4-9715ec5547bc@kernel.org \
--to=krzk@kernel.org \
--cc=arnd@arndb.de \
--cc=cix-kernel-upstream@cixtech.com \
--cc=geert+renesas@glider.be \
--cc=krzysztof.kozlowski@oss.qualcomm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.chen@cixtech.com \
--cc=ysk@kzalloc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox