From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3A339C001B0 for ; Tue, 8 Aug 2023 08:38:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=a5KJzSL5BV1E6SO3k+noZcvaCwqIlUi2mYaIxavvpPg=; b=sH2h/aZVPZG7Vs tQRJq1HxOtDOfMduMkHQVtTs+AgtQCPRfh9htCZ9IwN7UvdF+UD+8TynpndLW7079d62o3X9i1kMd nnhdDNsJZwg7nh5uDzzIUNnTQL5wJJtwqtKYnXvJeah5WuAjpOBLWs91WcNOsJof4yBg6y0zyO7fv yDGsVOO80DNvk5fnpJxzlks4nMayD2+cxS5Vb4bnvgvE+InIhDAqZV7A1chO95lNhfHMU+rYBb0JG dh1gOByZtcfI5kUDnmPzN3+OK+Y/wMNiw0ghJYRxycTl1HoikJ6xtpMmWunJ7v6sxN5ROmRjngvRs YyiAptoF59kNTMYnwMyw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qTIDv-0023Sw-12; Tue, 08 Aug 2023 08:37:51 +0000 Received: from mail-ej1-x62f.google.com ([2a00:1450:4864:20::62f]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qTIDs-0023Ro-2R for linux-arm-kernel@lists.infradead.org; Tue, 08 Aug 2023 08:37:50 +0000 Received: by mail-ej1-x62f.google.com with SMTP id a640c23a62f3a-99c93638322so860968966b.1 for ; Tue, 08 Aug 2023 01:37:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1691483865; x=1692088665; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Yvh066U7kamHwMstcxLV5PbPWX/RDQ9l/CouVe/EHBo=; b=KHKqGn5O8kc6A+K+ppS+Wa4NY300RsZY7hCdzaclQrApwxuqHS0vRvQDZcyboHBQUX W1JafXP0h3tLL3BmjAgnvT794uUjgWD0dj9fTKlp2csWDrxTFfe4Vwrsk9FGEvn4843/ Bnw+l5d01CIUylKmWpUPepgpXuleJlSRGRSzdPmDoiPtBaa4oIfhAAWoOZ2dls4qmqQm lAmpwJbxbL2qWVrqVvt6LeAVPSjEPFH5YvOadqPeh85qtO4c3OSG7GbtjCexPRDB+vDm GjO+KQkYVqDPiTnPTBEXDeIpyb34hz/nmUdhCEHPQfBknBMaVQP82mWLtCAR2Abu2Iyn pf6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691483865; x=1692088665; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Yvh066U7kamHwMstcxLV5PbPWX/RDQ9l/CouVe/EHBo=; b=HqXLe1JasDvnrsYiFT+8mSesPH3R+WIxw3vyw2jjqSnWukQsWhV6djbmWgqzPjQdJr S63gBtNKx/c0d6s4D1zXgwOxwL+tzyAjnmX1CiclFYVUWqGbaNE6seZZoB56077GnPW9 TnJ/Qrjq30HMtFFpY4bHCSiFB33UNZwjZe+8YkHHYqZ/mUnX+LaEOLdSIkDXAIEvJDtu uu/H+pxJjRIn9sPZ+6bjk4InYECogAWQ9K+W2liHVi7G/uXzud8zk+myY+J33fHt1/Bt H/aupDsbAy5lDjJp+bHkJBLQz2hKN2knUlGA0Y36oRR4pdSVbbk2Fv/pMQSvO38K1Dnf //7Q== X-Gm-Message-State: AOJu0Yyby7lmkdhhbyDSwJlxEs+9J9RFWRW7hi5CMNWSbCG7xbstTW8h hydfHhsk32jOdoBkILAX5s/gvg== X-Google-Smtp-Source: AGHT+IEu0ccUzH7lApjEP28rWQ/D0b3cym+2k803TQ1oV+KLYehusJTAaXq8Tjyjub1CfGObHwqzrg== X-Received: by 2002:a17:906:769a:b0:99b:cb59:79b3 with SMTP id o26-20020a170906769a00b0099bcb5979b3mr9677048ejm.1.1691483865199; Tue, 08 Aug 2023 01:37:45 -0700 (PDT) Received: from [192.168.1.20] ([178.197.222.113]) by smtp.gmail.com with ESMTPSA id re15-20020a170906d8cf00b009886aaeb722sm6285193ejb.137.2023.08.08.01.37.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Aug 2023 01:37:44 -0700 (PDT) Message-ID: <4eadaf03-7378-93a0-b1c0-a640f9ae306c@linaro.org> Date: Tue, 8 Aug 2023 10:37:42 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH v3 9/9] i2c: synquacer: Use dev_err_probe in probe function Content-Language: en-US To: Liao Chang , andi.shyti@kernel.org, florian.fainelli@broadcom.com, rjui@broadcom.com, sbranden@broadcom.com, bcm-kernel-feedback-list@broadcom.com, yangyicong@hisilicon.com, aisheng.dong@nxp.com, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, kblaiech@nvidia.com, asmaa@nvidia.com, loic.poulain@linaro.org, rfoss@kernel.org, ardb@kernel.org, gcherian@marvell.com Cc: linux-i2c@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20230808012954.1643834-1-liaochang1@huawei.com> <20230808012954.1643834-10-liaochang1@huawei.com> From: Krzysztof Kozlowski In-Reply-To: <20230808012954.1643834-10-liaochang1@huawei.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230808_013748_803742_C693CDF3 X-CRM114-Status: GOOD ( 15.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 08/08/2023 03:29, Liao Chang wrote: > Use the dev_err_probe function instead of dev_err in the probe function > so that the printed messge includes the return value and also handles > -EPROBE_DEFER nicely. > > Signed-off-by: Liao Chang > i2c->base = devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(i2c->base)) > @@ -582,10 +578,8 @@ static int synquacer_i2c_probe(struct platform_device *pdev) > > ret = devm_request_irq(&pdev->dev, i2c->irq, synquacer_i2c_isr, > 0, dev_name(&pdev->dev), i2c); > - if (ret < 0) { > - dev_err(&pdev->dev, "cannot claim IRQ %d\n", i2c->irq); > - return ret; > - } > + if (ret < 0) > + return dev_err_probe(&pdev->dev, ret, "cannot claim IRQ %d\n", i2c->irq); > I don't think this is needed: https://lore.kernel.org/all/20230721094641.77189-1-frank.li@vivo.com/ Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel