From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D540EC27C4F for ; Wed, 26 Jun 2024 13:01:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ryLKnkzMXQJySebb8qmcApYN70ZrgnJgQwTJDqpQHkY=; b=yGtShchC+ExVljATClzS0z1ywv aNZDyiKZ3ninozLTIdVxWLViD4W32rIzpG3Mp1y8dHpcWR6OmSM5Oz/cfFA6h5Dy36mtSxkTYi1Fu yzsgFaxE9KEXArkVXPNrEfxlF7r6qOD4pPDbI6vgfaTygg8qjW9rCdwHZx5CEVzdTjQxDhTDhkE9H q7xaZA0WcQOYbiXvB8KukqSFVCkzFxbX2Zk/1IDtUSEN37i7JpyfnPAE53PvHYxiA3cSrMjpqBUsv nphfcaysFcJbuuXycnVaBXPlhRDLFynNX2n49MkQ26WU6Uq57xa984aQRTl2JoH7Kggse24ZOrR29 bemd5hkg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sMSHF-00000006pwJ-1uyL; Wed, 26 Jun 2024 13:01:33 +0000 Received: from mail-ej1-x62e.google.com ([2a00:1450:4864:20::62e]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sMSH6-00000006puB-3JV4 for linux-arm-kernel@lists.infradead.org; Wed, 26 Jun 2024 13:01:26 +0000 Received: by mail-ej1-x62e.google.com with SMTP id a640c23a62f3a-a7194ce90afso534630866b.2 for ; Wed, 26 Jun 2024 06:01:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1719406882; x=1720011682; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=ryLKnkzMXQJySebb8qmcApYN70ZrgnJgQwTJDqpQHkY=; b=arGij1zVz3WmE7ve9QphKE8eU2h8N/qIDMWztaKkCIMZKs57vCMg1pNZjxHm3BgytC oJWoibCWRiH0Bjya3vtQrWLo7DpowBzcJyM4Sm/lPEYicx6QIm+MVp3InGGos3ngiYEc PsXgv1j1kG8N/Qf3SuAuiWWBY0ZG3efyg8qqsCReOZ8EAE03k3WeejFAjCM7DS7BkipY EZEIDkYlugtZ5Hy/0ZQ2x8++gEn/I1GWTC+EDOwGLb4LTRfJbUO8szKMISR59eITb64Q USTaBSTHjIm4SiaiY4h/yPaPW4I0ywhykH4IntQ85PU7Kq7mf4zmxvUecxws1wVGx5tG 2mGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719406882; x=1720011682; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ryLKnkzMXQJySebb8qmcApYN70ZrgnJgQwTJDqpQHkY=; b=Mvb5oRxQIV4wVg30zblFYsD0NbFC+6igTKhkPmzufh1aoxGjGZfSwNY041oLx3EF9b wK8WUAup6sy8BmgnJliwtVRH937LGD01Bgr0hhFoy3XIYXCc7dIBxXb+LM+v9J/imhQ1 FMVNcn2aA9+bG+gO9N2mYZ5FnBkc6ANgv3/fUAdrW1kwEj4m5qcCQ5wI8q/zwGAq5dww ozXicrRtLiwrpnRqogs0iLBKDnIQ2gTtg6gZQSXijc34zBVYPAGYdesnqIgaHn1oX+Tz COlDHC7KhzedLeF3PJecB/NEGQoc8l86LO64bsRiyooNtXCA9XU+UnjMmi0F24HGUBCE fBuw== X-Gm-Message-State: AOJu0Yx35ThYc1aZI/qQ8XUwRwF9vhdQv2qrEiaBjt8eT70tDcJghLeG D1ESte5Wjt9NUx7jGBDHvUUQs/BnLmqnSiTWdOnJKoujgdyxguOSxiDXFJIXxQs= X-Google-Smtp-Source: AGHT+IFlLo0JH1gGo+HH1mWhsMDl0o3hYjx83DFQ+FDkMSeL7kdoVNdHaP78qL1EHT4N4rVF0SHhGA== X-Received: by 2002:a17:907:c249:b0:a72:6b08:ab27 with SMTP id a640c23a62f3a-a726b08acdamr348934666b.36.1719406881782; Wed, 26 Jun 2024 06:01:21 -0700 (PDT) Received: from [192.168.1.20] ([178.197.219.137]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a7250712ca5sm344543266b.100.2024.06.26.06.01.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 26 Jun 2024 06:01:21 -0700 (PDT) Message-ID: <4efb51f3-4600-4d88-a5df-e7be43294d53@linaro.org> Date: Wed, 26 Jun 2024 15:01:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] pinctrl: samsung: Add support for pull-up and pull-down To: Vishnu Reddy , 'Krzysztof Kozlowski' , s.nawrocki@samsung.com, alim.akhtar@samsung.com, linus.walleij@linaro.org Cc: linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, pankaj.dubey@samsung.com, ravi.patel@samsung.com, gost.dev@samsung.com References: <20240620103410.35786-1-vishnu.reddy@samsung.com> <38fae674-f672-46e0-a44e-1278deaaf36a@kernel.org> <07f201dac7be$e81317d0$b8394770$@samsung.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: <07f201dac7be$e81317d0$b8394770$@samsung.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240626_060124_887560_3FCFF0BF X-CRM114-Status: GOOD ( 18.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 26/06/2024 13:49, Vishnu Reddy wrote: > > >> -----Original Message----- >> From: Krzysztof Kozlowski [mailto:krzk@kernel.org] >> Sent: 24 June 2024 19:27 >> To: Vishnu Reddy ; >> krzysztof.kozlowski@linaro.org; s.nawrocki@samsung.com; >> alim.akhtar@samsung.com; linus.walleij@linaro.org >> Cc: linux-arm-kernel@lists.infradead.org; linux-samsung- >> soc@vger.kernel.org; linux-gpio@vger.kernel.org; linux- >> kernel@vger.kernel.org; pankaj.dubey@samsung.com; >> ravi.patel@samsung.com; gost.dev@samsung.com >> Subject: Re: [PATCH v2] pinctrl: samsung: Add support for pull-up and pull- >> down >> >> On 20/06/2024 12:34, Vishnu Reddy wrote: >>> gpiolib framework has the implementation of setting up the >>> PUD configuration for GPIO pins but there is no driver support. >>> >>> Add support to handle the PUD configuration request from the >>> userspace in samsung pinctrl driver. >>> >>> Signed-off-by: Vishnu Reddy >>> --- >>> Verified the offset from the user manual of following Exynos SoC series >>> and found the current code is taking care of correct offset for pull-up >>> and pull-down >>> >>> Exynos-3250 >>> Exynos-3470 >>> Exynos-4412 >>> Exynos-4415 >>> Exynos-5250 >>> Exynos-5260 >>> Exynos-5410 >>> Exynos-5420 >>> Exynos-5422 >>> Exynos-7420 >>> Exynos-7580 >>> Exynos-7880 >>> Exynos-9820 >>> Exynos-9830 >>> Exynos-4210 >>> Exynos-S5PC210 >>> Exynos-S5PV310 >>> >>> This patch is tested on FSD platform >> >> You verified but... >> >>> diff --git a/drivers/pinctrl/samsung/pinctrl-samsung.h >> b/drivers/pinctrl/samsung/pinctrl-samsung.h >>> index d50ba6f07d5d..758b623a4bea 100644 >>> --- a/drivers/pinctrl/samsung/pinctrl-samsung.h >>> +++ b/drivers/pinctrl/samsung/pinctrl-samsung.h >>> @@ -61,6 +61,13 @@ enum pincfg_type { >>> #define PIN_CON_FUNC_INPUT 0x0 >>> #define PIN_CON_FUNC_OUTPUT 0x1 >>> >>> +/* >>> + * Values for the pin PUD register. >>> + */ >>> +#define PIN_PUD_PULL_UP_DOWN_DISABLE 0x0 >>> +#define PIN_PUD_PULL_DOWN_ENABLE 0x1 >>> +#define PIN_PUD_PULL_UP_ENABLE 0x3 >> >> ... I said it is not correct, so you send the same? If you think I was >> wrong, then please respond and keep discussion going. Sending the same >> suggests you just ignored my comment. >> >> Look at two headers s5pv210-pinctrl.h and s3c64xx-pinctrl.h. How did you >> resolve these? > Thank you for sharing the s5pv210-pinctrl.h and s3c64xx-pinctrl.h file names for the pin value information. > I have not ignored your comment. Unfortunately, I don't have the user manuals for the s3c64xx and s5pv210 series. > I have an idea to handle the PIN_PULL_UP value of the s3c64xx and s5pv210 series by checking the compatibility with the of_device_is_compatible API. > Will it be okay or do you have any other suggestions? I don't remember the code used here, but usually such choices are determined by driver match data (and flags or value customized per variant). Best regards, Krzysztof