From mboxrd@z Thu Jan 1 00:00:00 1970 From: hdegoede@redhat.com (Hans de Goede) Date: Thu, 30 Jun 2016 11:49:01 +0200 Subject: [linux-sunxi] Re: [PATCH 1/4] brcmfmac: Add brcm, nvram_file_name dt property In-Reply-To: <87mvm36p4d.fsf@kamboji.qca.qualcomm.com> References: <1467209074-15634-1-git-send-email-hdegoede@redhat.com> <871t3gdj6p.fsf@purkki.adurom.net> <87mvm36p4d.fsf@kamboji.qca.qualcomm.com> Message-ID: <4f1a8cce-91e9-f386-cdde-7abcdc43b817@redhat.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, On 30-06-16 10:46, Kalle Valo wrote: > Arend Van Spriel writes: > >>> Since we are dealing with a per-board config-file here, which is >>> loaded from the os filesystem we really need to specify a basename >>> here as the list of possible boards is endless, so we cannot >>> have a lookup table in the driver. >> >> As Jonas mentioned the general principle of device tree is to be >> agnostic with regards to OS and/or driver as you undoubtedly know. His >> proposal seems like a usable solution for your problem while complying >> to the device tree principle. So instead of overriding the default >> brcmfmac should modify it when dt specifies the "module" property, ie: >> >> no "module" in DT: nvram filename = brcm/brcmfmac43362-sdio.txt >> "module=ap6210" in DT: nvram filename = brcm/brcmfmac43362-ap6210.txt > > Just out of curiosity, what does "ap6210" exactly mean? I get that 43362 > is the chip id, but not ap6210. Is it just an arbitrary name? It is more or less an arbitrary name, typically these sdio wifi chips are used as a pre-assembled module (a tiny pcb) with some things like the necessary crystal / resonator and various capacitors and resistors on there. The brcm based sdio wifi modules typically come with a metal shield cap which has a module type stamped on it, e.g. ap6210, ap6476, toc9002. Regards, Hans