From: Krzysztof Kozlowski <krzk@kernel.org>
To: Shawn Guo <shawnguo2@yeah.net>,
Wojciech Dubowik <Wojciech.Dubowik@mt.com>
Cc: linux-kernel@vger.kernel.org, "Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Shawn Guo" <shawnguo@kernel.org>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Fabio Estevam" <festevam@gmail.com>,
"Kees Cook" <kees@kernel.org>, "Tony Luck" <tony.luck@intel.com>,
"Guilherme G. Piccoli" <gpiccoli@igalia.com>,
"Alexander Stein" <alexander.stein@ew.tq-group.com>,
"Marek Vasut" <marex@denx.de>, "Frank Li" <Frank.Li@nxp.com>,
"Markus Niebel" <Markus.Niebel@tq-group.com>,
"João Paulo Gonçalves" <joao.goncalves@toradex.com>,
"Frieder Schrempf" <frieder.schrempf@kontron.de>,
"Michael Walle" <mwalle@kernel.org>,
"Heiko Schocher" <hs@denx.de>,
"Francesco Dolcini" <francesco.dolcini@toradex.com>,
"Max Merchel" <Max.Merchel@ew.tq-group.com>,
"Primoz Fiser" <primoz.fiser@norik.com>,
"Tim Harvey" <tharvey@gateworks.com>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"Heiko Stuebner" <heiko@sntech.de>,
"Caleb James DeLisle" <cjd@cjdns.fr>,
"Junhao Xie" <bigfoot@classfun.cn>,
"Andre Przywara" <andre.przywara@arm.com>,
"Rafał Miłecki" <rafal@milecki.pl>,
"Kever Yang" <kever.yang@rock-chips.com>,
"Manivannan Sadhasivam" <mani@kernel.org>,
devicetree@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-hardening@vger.kernel.org,
"Tobias Graemer" <Tobias.Graemer@mt.com>
Subject: Re: [PATCH v3 3/4] arm64: dts: freescale: Add Mettler-Toledo Snowflake V2 support
Date: Tue, 8 Jul 2025 08:27:50 +0200 [thread overview]
Message-ID: <4f2f2f95-d0f4-4d2f-8873-b1026340a8c9@kernel.org> (raw)
In-Reply-To: <aGy4qy1kN3RZ6nas@dragon>
On 08/07/2025 08:20, Shawn Guo wrote:
>> +
>> + backlight: backlight {
>> + compatible = "pwm-backlight";
>> + pwms = <&pwm1 0 500000 0>;
>> + power-supply = <®_5v>;
>> + brightness-levels = <0 100>;
>> + num-interpolated-steps = <100>;
>> + default-brightness-level = <100>;
>> + status = "okay";
>
> We usually use "okay" status to enable "disabled" devices. It doesn't
> seem to be needed here.
I already asked for this in v2. Changelog claims it was done, but I
believe nothing here improved and they just sent the same patchset
wasting review effort.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-07-08 6:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-24 11:03 [PATCH v3 0/4] Support i.MX8MM Mettler Toledo Snowflake board Wojciech Dubowik
2025-06-24 11:03 ` [PATCH v3 1/4] dt-bindings: vendor-prefixes: Add Mettler-Toledo Wojciech Dubowik
2025-06-24 11:04 ` [PATCH v3 2/4] dt-bindings: arm: fsl: Add Mettler-Toledo Snowflake V2 board Wojciech Dubowik
2025-06-24 11:04 ` [PATCH v3 3/4] arm64: dts: freescale: Add Mettler-Toledo Snowflake V2 support Wojciech Dubowik
2025-07-08 6:20 ` Shawn Guo
2025-07-08 6:27 ` Krzysztof Kozlowski [this message]
2025-07-09 9:44 ` EXTERNAL - " Wojciech Dubowik
2025-06-24 11:04 ` [PATCH v3 4/4] MAINTAINERS: Add entry for METTLER TOLEDO BOARD SUPPORT Wojciech Dubowik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4f2f2f95-d0f4-4d2f-8873-b1026340a8c9@kernel.org \
--to=krzk@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=Markus.Niebel@tq-group.com \
--cc=Max.Merchel@ew.tq-group.com \
--cc=Tobias.Graemer@mt.com \
--cc=Wojciech.Dubowik@mt.com \
--cc=alexander.stein@ew.tq-group.com \
--cc=andre.przywara@arm.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=bigfoot@classfun.cn \
--cc=cjd@cjdns.fr \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=francesco.dolcini@toradex.com \
--cc=frieder.schrempf@kontron.de \
--cc=gpiccoli@igalia.com \
--cc=heiko@sntech.de \
--cc=hs@denx.de \
--cc=imx@lists.linux.dev \
--cc=joao.goncalves@toradex.com \
--cc=kees@kernel.org \
--cc=kernel@pengutronix.de \
--cc=kever.yang@rock-chips.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mani@kernel.org \
--cc=marex@denx.de \
--cc=mwalle@kernel.org \
--cc=primoz.fiser@norik.com \
--cc=rafal@milecki.pl \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo2@yeah.net \
--cc=shawnguo@kernel.org \
--cc=tharvey@gateworks.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).